From 09d8f8506ec12968d52458bd63533502b58c3ffa Mon Sep 17 00:00:00 2001 From: Matt Atlas Date: Fri, 7 Apr 2023 14:13:17 +0200 Subject: [PATCH] Makes switching loadout tabs not refresh preview, fixes new character loading. (#16167) Co-authored-by: Matt Atlas --- .../preference_setup/loadout/loadout.dm | 2 +- code/modules/client/preferences.dm | 1 + html/changelogs/mattatlas-thediaster.yml | 42 +++++++++++++++++++ 3 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/mattatlas-thediaster.yml diff --git a/code/modules/client/preference_setup/loadout/loadout.dm b/code/modules/client/preference_setup/loadout/loadout.dm index 9f26ee7c11d..644222d9f33 100644 --- a/code/modules/client/preference_setup/loadout/loadout.dm +++ b/code/modules/client/preference_setup/loadout/loadout.dm @@ -356,7 +356,7 @@ var/list/gear_datums = list() else if(href_list["select_category"]) current_tab = href_list["select_category"] - return TOPIC_REFRESH_UPDATE_PREVIEW + return TOPIC_REFRESH else if(href_list["clear_loadout"]) pref.gear.Cut() return TOPIC_REFRESH_UPDATE_PREVIEW diff --git a/code/modules/client/preferences.dm b/code/modules/client/preferences.dm index 6b58a55bbd8..32185f16f65 100644 --- a/code/modules/client/preferences.dm +++ b/code/modules/client/preferences.dm @@ -324,6 +324,7 @@ datum/preferences else if(href_list["new_character_sql"]) new_setup(1) to_chat(usr, "Your setup has been refreshed.") + usr.client.prefs.update_preview_icon() close_load_dialog(usr) else if(href_list["close_load_dialog"]) close_load_dialog(usr) diff --git a/html/changelogs/mattatlas-thediaster.yml b/html/changelogs/mattatlas-thediaster.yml new file mode 100644 index 00000000000..896f1cbced2 --- /dev/null +++ b/html/changelogs/mattatlas-thediaster.yml @@ -0,0 +1,42 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# wip (For works in progress) +# tweak +# soundadd +# sounddel +# rscadd (general adding of nice things) +# rscdel (general deleting of nice things) +# imageadd +# imagedel +# maptweak +# spellcheck (typo fixes) +# experiment +# balance +# admin +# backend +# security +# refactor +################################# + +# Your name. +author: MattAtlas + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries. +# Please surround your changes in double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Switching tabs in the character setup should now be more performant." + - bugfix: "Loading a new character should now refresh the preview."