From 0ae0b107645ab788e48bd44ad796855762387009 Mon Sep 17 00:00:00 2001
From: Fluffy <65877598+FluffyGhoster@users.noreply.github.com>
Date: Fri, 13 Sep 2024 12:17:32 +0200
Subject: [PATCH] Refactored all the backslash ref and ref() calls to use REF()
instead (#19847)
Refactored all the backslash ref and ref() calls to use REF() instead.
Added a linting for raw ref proc calls.
---
code/ZAS/Variable Settings.dm | 2 +-
code/__DEFINES/global.dm | 2 +-
code/__DEFINES/misc.dm | 6 +-
code/__HELPERS/area_movement.dm | 2 +-
code/__HELPERS/icons.dm | 2 +-
code/__HELPERS/logging/_logging.dm | 4 +-
code/__HELPERS/text.dm | 2 +-
code/__HELPERS/unsorted.dm | 6 +-
code/_onclick/hud/radial.dm | 2 +-
code/_onclick/hud/radial_persistent.dm | 2 +-
code/controllers/subsystems/arrivals.dm | 4 +-
code/controllers/subsystems/event.dm | 46 +--
code/controllers/subsystems/garbage.dm | 2 +-
code/controllers/subsystems/pai.dm | 2 +-
.../subsystems/processing/nanoui.dm | 10 +-
code/controllers/subsystems/processing/psi.dm | 8 +-
code/controllers/subsystems/ticker.dm | 2 +-
code/controllers/subsystems/zcopy.dm | 2 +-
code/datums/browser.dm | 2 +-
code/datums/components/multitool/multitool.dm | 2 +-
code/datums/datum.dm | 2 +-
code/datums/mind.dm | 12 +-
code/datums/repositories/crew.dm | 2 +-
code/datums/state_machine.dm | 6 +-
code/game/antagonist/antagonist_panel.dm | 8 +-
code/game/antagonist/station/traitor.dm | 2 +-
code/game/atom/atom_examine.dm | 2 +-
code/game/atoms_movable.dm | 2 +-
.../gamemodes/changeling/helpers/_store.dm | 2 +-
code/game/gamemodes/cult/items/tome.dm | 2 +-
code/game/gamemodes/technomancer/catalog.dm | 52 +--
code/game/machinery/ai_slipper.dm | 4 +-
code/game/machinery/autolathe/autolathe.dm | 4 +-
code/game/machinery/biogenerator.dm | 12 +-
code/game/machinery/camera/camera.dm | 6 +-
code/game/machinery/chem_heater.dm | 22 +-
code/game/machinery/computer/arcade.dm | 8 +-
code/game/machinery/computer/arcade_orion.dm | 44 +--
code/game/machinery/computer/atmos_alert.dm | 4 +-
code/game/machinery/computer/cloning.dm | 40 +--
code/game/machinery/computer/guestpass.dm | 18 +-
code/game/machinery/computer/pod.dm | 14 +-
code/game/machinery/computer/sentencing.dm | 50 +--
code/game/machinery/computer/slotmachine.dm | 4 +-
code/game/machinery/cryopod.dm | 6 +-
.../machinery/doors/airlock_electronics.dm | 18 +-
code/game/machinery/doors/brigdoors.dm | 12 +-
code/game/machinery/hologram.dm | 4 +-
code/game/machinery/navbeacon.dm | 16 +-
code/game/machinery/newscaster.dm | 124 ++++----
code/game/machinery/nuclear_bomb.dm | 2 +-
code/game/machinery/pipe/pipe_dispenser.dm | 154 ++++-----
code/game/machinery/requests_console.dm | 2 +-
code/game/machinery/spaceheater.dm | 8 +-
code/game/machinery/stargazer.dm | 2 +-
code/game/machinery/suit_storage_unit.dm | 26 +-
.../telecomms/computers/logbrowser.dm | 14 +-
.../machinery/telecomms/computers/message.dm | 36 +--
.../telecomms/computers/telemonitor.dm | 12 +-
.../telecomms/computers/traffic_control.dm | 16 +-
.../telecomms/machine_interactions.dm | 30 +-
.../telecomms/machines/message_server.dm | 8 +-
code/game/machinery/turret_control.dm | 2 +-
code/game/objects/effects/chem/chemsmoke.dm | 4 +-
code/game/objects/items.dm | 4 +-
code/game/objects/items/devices/paicard.dm | 14 +-
.../items/devices/radio/electropack.dm | 18 +-
.../game/objects/items/devices/radio/radio.dm | 2 +-
.../objects/items/devices/slide_projector.dm | 6 +-
.../objects/items/devices/transfer_valve.dm | 4 +-
code/game/objects/items/devices/tvcamera.dm | 6 +-
code/game/objects/items/devices/uplink.dm | 4 +-
code/game/objects/items/eightball.dm | 2 +-
code/game/objects/items/stacks/stack.dm | 16 +-
code/game/objects/items/stacks/wrap.dm | 2 +-
.../weapons/implants/implants/explosive.dm | 24 +-
.../weapons/implants/implants/loyalty.dm | 2 +-
code/game/objects/items/weapons/landmines.dm | 2 +-
.../objects/items/weapons/storage/secure.dm | 2 +-
.../objects/items/weapons/teleportation.dm | 14 +-
code/game/objects/structures/noticeboard.dm | 2 +-
code/game/objects/structures/safe.dm | 4 +-
.../game/objects/structures/tank_dispenser.dm | 4 +-
.../game/objects/structures/under_wardrobe.dm | 6 +-
code/game/verbs/ooc.dm | 2 +-
code/modules/admin/DB ban/functions.dm | 18 +-
code/modules/admin/NewBan.dm | 2 +-
code/modules/admin/admin.dm | 300 +++++++++---------
code/modules/admin/admin_investigate.dm | 2 +-
code/modules/admin/admin_verbs.dm | 2 +-
code/modules/admin/banjob.dm | 82 ++---
code/modules/admin/create_mob.dm | 2 +-
code/modules/admin/create_object.dm | 2 +-
code/modules/admin/create_turf.dm | 2 +-
code/modules/admin/law_manager.dm | 4 +-
code/modules/admin/player_notes.dm | 8 +-
code/modules/admin/player_notes_sql.dm | 10 +-
code/modules/admin/player_panel.dm | 6 +-
code/modules/admin/ticket.dm | 12 +-
code/modules/admin/topic.dm | 22 +-
code/modules/admin/verbs/adminhelp.dm | 8 +-
code/modules/admin/verbs/adminpm.dm | 6 +-
code/modules/admin/verbs/adminsay.dm | 2 +-
code/modules/admin/verbs/antag-ooc.dm | 2 +-
code/modules/admin/verbs/massmodvar.dm | 2 +-
code/modules/admin/verbs/modifyvariables.dm | 2 +-
code/modules/admin/verbs/pray.dm | 8 +-
code/modules/admin/verbs/warning.dm | 16 +-
code/modules/admin/view_variables/helpers.dm | 90 +++---
.../admin/view_variables/view_variables.dm | 22 +-
code/modules/asset_cache/asset_cache.dm | 6 +-
.../awaymissions/bluespaceartillery.dm | 4 +-
code/modules/battlemonsters/items/deck.dm | 2 +-
code/modules/cargo/delivery/backpack.dm | 4 +-
code/modules/cciaa/cciaa.dm | 4 +-
code/modules/client/client_procs.dm | 6 +-
.../antagonism/01_candidacy.dm | 6 +-
.../preference_setup/antagonism/02_setup.dm | 4 +-
.../preference_setup/general/01_basic.dm | 38 +--
.../preference_setup/general/02_language.dm | 6 +-
.../preference_setup/general/03_body.dm | 72 ++---
.../preference_setup/general/04_equipment.dm | 20 +-
.../preference_setup/general/05_background.dm | 6 +-
.../preference_setup/general/06_flavor.dm | 34 +-
.../preference_setup/general/07_psionics.dm | 4 +-
.../client/preference_setup/global/01_ui.dm | 24 +-
.../preference_setup/global/02_settings.dm | 22 +-
.../preference_setup/global/03_language.dm | 2 +-
.../client/preference_setup/global/04_pai.dm | 8 +-
.../preference_setup/loadout/loadout.dm | 12 +-
.../preference_setup/occupation/occupation.dm | 20 +-
.../client/preference_setup/origin/origin.dm | 22 +-
.../preference_setup/other/01_incidents.dm | 2 +-
.../preference_setup/preference_setup.dm | 2 +-
code/modules/client/preferences.dm | 18 +-
.../client/preferences_notification.dm | 4 +-
code/modules/clothing/clothing_accessories.dm | 2 +-
.../spacesuits/rig/modules/modules.dm | 2 +-
.../clothing/under/accessories/buddy_tag.dm | 8 +-
code/modules/cooking/machinery/icecream.dm | 20 +-
code/modules/economy/EFTPOS.dm | 18 +-
code/modules/heavy_vehicle/components/arms.dm | 2 +-
code/modules/heavy_vehicle/components/body.dm | 6 +-
.../modules/heavy_vehicle/components/frame.dm | 18 +-
code/modules/heavy_vehicle/components/head.dm | 8 +-
code/modules/heavy_vehicle/components/legs.dm | 2 +-
code/modules/heavy_vehicle/mecha.dm | 2 +-
code/modules/holodeck/HolodeckControl.dm | 18 +-
code/modules/hydroponics/trays/tray_tools.dm | 2 +-
.../integrated_electronics/core/assemblies.dm | 26 +-
.../core/integrated_circuit.dm | 32 +-
.../integrated_electronics/core/pins.dm | 2 +-
.../core/special_pins/list_pin.dm | 18 +-
code/modules/library/lib_machines.dm | 70 ++--
code/modules/lighting/lighting_verbs.dm | 6 +-
code/modules/mining/machine_vending.dm | 2 +-
code/modules/mining/mint.dm | 26 +-
code/modules/mob/abstract/new_player/poll.dm | 30 +-
.../modules/mob/abstract/observer/observer.dm | 6 +-
code/modules/mob/abstract/unauthed/login.dm | 4 +-
code/modules/mob/hear_say.dm | 4 +-
code/modules/mob/language/language.dm | 6 +-
code/modules/mob/language/synthetic.dm | 2 +-
code/modules/mob/living/bot/farmbot.dm | 16 +-
code/modules/mob/living/bot/medbot.dm | 24 +-
code/modules/mob/living/carbon/diona_base.dm | 2 +-
code/modules/mob/living/carbon/human/emote.dm | 20 +-
.../mob/living/carbon/human/examine.dm | 76 ++---
code/modules/mob/living/carbon/human/human.dm | 38 +--
.../living/carbon/human/human_attackhand.dm | 6 +-
.../mob/living/carbon/human/human_powers.dm | 4 +-
code/modules/mob/living/silicon/ai/ai.dm | 2 +-
.../silicon/robot/drone/drone_console.dm | 6 +-
.../living/silicon/robot/drone/drone_items.dm | 10 +-
.../modules/mob/living/silicon/robot/robot.dm | 14 +-
code/modules/mob/living/silicon/silicon.dm | 8 +-
.../simple_animal/constructs/soulstone.dm | 4 +-
.../mob/living/simple_animal/hostile/mimic.dm | 2 +-
.../mob/living/simple_animal/parrot.dm | 4 +-
code/modules/mob/login.dm | 4 +-
code/modules/mob/mob.dm | 20 +-
code/modules/mob/mob_helpers.dm | 4 +-
.../modular_computers/NTNet/NTNRC/message.dm | 2 +-
.../programs/command/account_database.dm | 2 +-
.../programs/command/teleporter.dm | 8 +-
.../programs/engineering/atmoscontrol.dm | 2 +-
.../programs/generic/lawmanager.dm | 4 +-
.../programs/security/guntracker.dm | 2 +-
.../programs/security/implant_tracker.dm | 4 +-
.../programs/security/penalmechs.dm | 6 +-
code/modules/nano/modules/ghost_menu.dm | 2 +-
code/modules/nano/nanoui.dm | 6 +-
code/modules/ntsl2/ntsl2_types.dm | 2 +-
code/modules/organs/blood.dm | 2 +-
.../overmap/ships/computers/engine_control.dm | 2 +-
code/modules/overmap/ships/computers/helm.dm | 2 +-
.../overmap/ships/computers/sensors.dm | 6 +-
code/modules/overmap/ships/computers/ship.dm | 6 +-
code/modules/paperwork/clipboard.dm | 10 +-
code/modules/paperwork/faxmachine.dm | 4 +-
code/modules/paperwork/filingcabinet.dm | 2 +-
code/modules/paperwork/folders.dm | 8 +-
code/modules/paperwork/paper.dm | 4 +-
code/modules/paperwork/paper_bundle.dm | 14 +-
code/modules/power/apc.dm | 4 +-
.../power/fusion/consoles/core_control.dm | 2 +-
.../power/fusion/consoles/gyrotron_control.dm | 2 +-
.../power/fusion/consoles/injector_control.dm | 2 +-
code/modules/power/gravitygenerator.dm | 6 +-
code/modules/power/singularity/emitter.dm | 4 +-
.../particle_accelerator/particle_control.dm | 12 +-
code/modules/power/solar.dm | 12 +-
.../projectiles/guns/projectile/dartgun.dm | 8 +-
code/modules/psionics/complexus/complexus.dm | 2 +-
code/modules/reagents/Chemistry-Machinery.dm | 6 +-
.../reagents/reagent_containers/borghydro.dm | 2 +-
code/modules/recycling/disposal.dm | 24 +-
code/modules/recycling/sortingmachinery.dm | 4 +-
code/modules/research/rdconsole.dm | 170 +++++-----
code/modules/research/server.dm | 22 +-
.../artifact/artifact_replicator.dm | 2 +-
.../machinery/artifact_analyser.dm | 6 +-
.../machinery/artifact_harvester.dm | 10 +-
.../tools/ano_device_battery.dm | 12 +-
.../tools/tools_depthscanner.dm | 10 +-
.../xenoarchaeology/tools/tools_locater.dm | 12 +-
.../security levels/keycard authentication.dm | 10 +-
code/modules/telesci/telesci_computer.dm | 16 +-
code/modules/tgs/core/core.dm | 2 +-
code/modules/turbolift/turbolift_map.dm | 2 +-
code/unit_tests/mob_tests.dm | 2 +-
html/changelogs/fluffyghost-ref.yml | 59 ++++
tools/ci/check_grep.sh | 10 +
233 files changed, 1629 insertions(+), 1564 deletions(-)
create mode 100644 html/changelogs/fluffyghost-ref.yml
diff --git a/code/ZAS/Variable Settings.dm b/code/ZAS/Variable Settings.dm
index 1caf76cb9e1..3bbeccbc3ec 100644
--- a/code/ZAS/Variable Settings.dm
+++ b/code/ZAS/Variable Settings.dm
@@ -111,7 +111,7 @@ var/global/vs_control/vsc = new
vw = vars[ch]
if("[ch]_DESC" in vars) vw_desc = vars["[ch]_DESC"]
if("[ch]_NAME" in vars) vw_name = vars["[ch]_NAME"]
- dat += "[vw_name] = [vw] \[Change\]
"
+ dat += "[vw_name] = [vw] \[Change\]
"
dat += "[vw_desc]
"
user << browse(dat,"window=settings")
diff --git a/code/__DEFINES/global.dm b/code/__DEFINES/global.dm
index 587f280f7ad..c191056e9ea 100644
--- a/code/__DEFINES/global.dm
+++ b/code/__DEFINES/global.dm
@@ -51,7 +51,7 @@ GLOBAL_PROTECT(admin_log)
GLOBAL_LIST_EMPTY(signal_log)
GLOBAL_PROTECT(signal_log)
-GLOBAL_LIST_EMPTY(lastsignalers) // Keeps last 100 signals here in format: "[src] used \ref[src] @ location [src.loc]: [freq]/[code]"
+GLOBAL_LIST_EMPTY(lastsignalers) // Keeps last 100 signals here in format: "[src] used REF(src) @ location [src.loc]: [freq]/[code]"
GLOBAL_PROTECT(lastsignalers)
GLOBAL_LIST_EMPTY(lawchanges) // Stores who uploaded laws to which silicon-based lifeform, and what the law was.
diff --git a/code/__DEFINES/misc.dm b/code/__DEFINES/misc.dm
index e7c869585cb..ef377742c13 100644
--- a/code/__DEFINES/misc.dm
+++ b/code/__DEFINES/misc.dm
@@ -267,7 +267,7 @@
#define MIDNIGHT_ROLLOVER 864000 //number of deciseconds in a day
-#define DEBUG_REF(D) (D ? "\ref[D]|[D] ([D.type])" : "NULL")
+#define DEBUG_REF(D) (D ? "[REF(D)]|[D]] ([D.type])" : "NULL")
// MultiZAS directions.
#define NORTHUP (NORTH|UP)
@@ -283,10 +283,6 @@
#define NL_TEMPORARY_DISABLE 1
#define NL_PERMANENT_DISABLE 2
-///Used for creating soft references to objects. A manner of storing an item reference
-///DO NOT USE, USE `WEAKREF()`
-#define SOFTREF(A) ref(A)
-
#define ADD_VERB_IN(the_atom,time,verb) addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(add_verb), the_atom, verb), time, TIMER_UNIQUE | TIMER_OVERRIDE | TIMER_NO_HASH_WAIT)
#define ADD_VERB_IN_IF(the_atom,time,verb,callback) addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(add_verb), the_atom, verb, callback), time, TIMER_UNIQUE | TIMER_OVERRIDE | TIMER_NO_HASH_WAIT)
diff --git a/code/__HELPERS/area_movement.dm b/code/__HELPERS/area_movement.dm
index 957c3dc9298..859848c63bd 100644
--- a/code/__HELPERS/area_movement.dm
+++ b/code/__HELPERS/area_movement.dm
@@ -53,7 +53,7 @@
if(!A || !src) return
- var/list/turfs_src = get_area_turfs("\ref[src]")
+ var/list/turfs_src = get_area_turfs("[REF(src)]")
if(!turfs_src.len)
return
diff --git a/code/__HELPERS/icons.dm b/code/__HELPERS/icons.dm
index faa63ffee7a..34981221127 100644
--- a/code/__HELPERS/icons.dm
+++ b/code/__HELPERS/icons.dm
@@ -1139,7 +1139,7 @@ lighting determines lighting capturing (optional), suppress_errors suppreses err
// Either an atom or somebody fucked up and is gonna get a runtime, which I'm fine with.
var/atom/A = thing
- var/key = "[istype(A.icon, /icon) ? "[ref(A.icon)]" : A.icon]:[A.icon_state]"
+ var/key = "[istype(A.icon, /icon) ? "[REF(A.icon)]" : A.icon]:[A.icon_state]"
if (!bicon_cache[key]) // Doesn't exist, make it.
diff --git a/code/__HELPERS/logging/_logging.dm b/code/__HELPERS/logging/_logging.dm
index 0b3fdcbdfd1..616b156b685 100644
--- a/code/__HELPERS/logging/_logging.dm
+++ b/code/__HELPERS/logging/_logging.dm
@@ -142,7 +142,7 @@ GLOBAL_LIST_INIT(testing_global_profiler, list("_PROFILE_NAME" = "Global"))
if(key)
if(include_link && C)
- . += ""
+ . += ""
if(C && C.holder && C.holder.fakekey && !include_name)
. += "Administrator"
@@ -176,7 +176,7 @@ GLOBAL_LIST_INIT(testing_global_profiler, list("_PROFILE_NAME" = "Global"))
// Helper procs for building detailed log lines
/datum/proc/get_log_info_line()
- return "[src] ([type]) (\ref[src])"
+ return "[src] ([type]) ([REF(src)])"
/area/get_log_info_line()
return "[..()] ([isnum(z) ? "[x],[y],[z]" : "0,0,0"])"
diff --git a/code/__HELPERS/text.dm b/code/__HELPERS/text.dm
index ab47363a992..bbcb1ae92f2 100644
--- a/code/__HELPERS/text.dm
+++ b/code/__HELPERS/text.dm
@@ -500,7 +500,7 @@
var/list/urls = list()
var/i = 1
while (url_find_lazy.Find_char(message))
- urls["\ref[urls]-[i]"] = url_find_lazy.match
+ urls["[REF(urls)]-[i]"] = url_find_lazy.match
i++
for (var/ref in urls)
diff --git a/code/__HELPERS/unsorted.dm b/code/__HELPERS/unsorted.dm
index 96a2e38f389..2a6b21c0c8d 100644
--- a/code/__HELPERS/unsorted.dm
+++ b/code/__HELPERS/unsorted.dm
@@ -1187,8 +1187,8 @@ var/global/known_proc = /proc/get_type_ref_bytes
return "appearance"
return "unknown-object([refType])" // If you see this you found a new undetectable type. Feel free to add it here.
-/proc/get_type_ref_bytes(var/V) // returns first 4 bytes from \ref which denote the object type (for objects that is)
- return lowertext(copytext(ref(V), 4, 6))
+/proc/get_type_ref_bytes(var/V) // returns first 4 bytes from a ref which denote the object type (for objects that is)
+ return lowertext(copytext(ref(V), 4, 6)) //Only allowed to remain the builtin ref proc because this shit depends on it and wasn't updated yet
/proc/format_text(text)
return replacetext(replacetext(text,"\proper ",""),"\improper ","")
@@ -1196,7 +1196,7 @@ var/global/known_proc = /proc/get_type_ref_bytes
/proc/topic_link(var/datum/D, var/arglist, var/content)
if(istype(arglist,/list))
arglist = list2params(arglist)
- return "[content]"
+ return "[content]"
/proc/get_random_colour(var/simple, var/lower, var/upper)
var/colour
diff --git a/code/_onclick/hud/radial.dm b/code/_onclick/hud/radial.dm
index 709f7be8b62..3dbdebceefb 100644
--- a/code/_onclick/hud/radial.dm
+++ b/code/_onclick/hud/radial.dm
@@ -311,7 +311,7 @@ GLOBAL_LIST_EMPTY(radial_menus)
if(!user || !anchor || !length(choices))
return
if(!uniqueid)
- uniqueid = "defmenu_[SOFTREF(user)]_[SOFTREF(anchor)]"
+ uniqueid = "defmenu_[REF(user)]_[REF(anchor)]"
if(GLOB.radial_menus[uniqueid])
if(!no_repeat_close)
diff --git a/code/_onclick/hud/radial_persistent.dm b/code/_onclick/hud/radial_persistent.dm
index 183f2d8c462..b3cdfef090a 100644
--- a/code/_onclick/hud/radial_persistent.dm
+++ b/code/_onclick/hud/radial_persistent.dm
@@ -53,7 +53,7 @@
if(!user || !anchor || !length(choices) || !select_proc)
return
if(!uniqueid)
- uniqueid = "defmenu_\ref[user]_\ref[anchor]"
+ uniqueid = "defmenu_[REF(user)]_[REF(anchor)]"
if(GLOB.radial_menus[uniqueid])
return
diff --git a/code/controllers/subsystems/arrivals.dm b/code/controllers/subsystems/arrivals.dm
index dc255c8cefe..bf868ba700a 100644
--- a/code/controllers/subsystems/arrivals.dm
+++ b/code/controllers/subsystems/arrivals.dm
@@ -35,7 +35,7 @@ SUBSYSTEM_DEF(arrivals)
return
if (istype(M))
- current_mobs += SOFTREF(M)
+ current_mobs += REF(M)
can_fire = TRUE // Wake the process.
@@ -43,7 +43,7 @@ SUBSYSTEM_DEF(arrivals)
set_launch_countdown()
/datum/controller/subsystem/arrivals/proc/on_hotzone_exit(mob/living/M)
- current_mobs -= SOFTREF(M)
+ current_mobs -= REF(M)
//called when the shuttle has arrived.
diff --git a/code/controllers/subsystems/event.dm b/code/controllers/subsystems/event.dm
index a14358aec5f..c011b93b32a 100644
--- a/code/controllers/subsystems/event.dm
+++ b/code/controllers/subsystems/event.dm
@@ -123,12 +123,12 @@ SUBSYSTEM_DEF(events)
to_world(message)
/datum/controller/subsystem/events/proc/GetInteractWindow()
- var/html = "Refresh"
- html += "Pause All - [GLOB.config.allow_random_events ? "Pause" : "Resume"]"
+ var/html = "Refresh"
+ html += "Pause All - [GLOB.config.allow_random_events ? "Pause" : "Resume"]"
if(selected_event_container)
var/event_time = max(0, selected_event_container.next_event_time - world.time)
- html += "Back
"
+ html += "Back
"
html += "Time till start: [round(event_time / 600, 0.1)]
"
html += "
"
html += "
Available [severity_to_string[selected_event_container.severity]] Events (queued & running events will not be displayed)
"
@@ -138,13 +138,13 @@ SUBSYSTEM_DEF(events)
for(var/datum/event_meta/EM in selected_event_container.available_events)
html += "
"
html += "| [EM.name] | "
- html += "[EM.weight] | "
+ html += "[EM.weight] | "
html += "[EM.min_weight] | "
html += "[EM.max_weight] | "
- html += "[EM.one_shot] | "
- html += "[EM.enabled] | "
+ html += "[EM.one_shot] | "
+ html += "[EM.enabled] | "
html += "[selected_event_container.get_weight(EM, active_with_role)] | "
- html += "Remove | "
+ html += "Remove | "
html += "
"
html += ""
html += "
"
@@ -154,16 +154,16 @@ SUBSYSTEM_DEF(events)
html += ""
- html += "Add
"
+ html += "Add
"
html += ""
else
- html += "Round End Report: [report_at_round_end ? "On": "Off"]
"
+ html += "Round End Report: [report_at_round_end ? "On": "Off"]
"
html += ""
@@ -224,7 +224,7 @@ SUBSYSTEM_DEF(events)
html += "[EM.name] | "
html += "[worldtime2text(ends_at)] | "
html += "[ends_in] | "
- html += "Stop | "
+ html += "Stop | "
html += ""
html += ""
html += ""
diff --git a/code/controllers/subsystems/garbage.dm b/code/controllers/subsystems/garbage.dm
index ce20a13f9c0..ac95fef20da 100644
--- a/code/controllers/subsystems/garbage.dm
+++ b/code/controllers/subsystems/garbage.dm
@@ -234,7 +234,7 @@ SUBSYSTEM_DEF(garbage)
if(!check_rights(R_ADMIN, user = admin?.mob))
continue
// Used to be to_chat(admin, "## TESTING: GC: -- [ADMIN_VV(D)] | [type] was unable to be GC'd --") but we do not have that macro
- to_chat(admin, "## TESTING: GC: -- VV | [type] was unable to be GC'd --")
+ to_chat(admin, "## TESTING: GC: -- VV | [type] was unable to be GC'd --")
#endif
I.failures++
diff --git a/code/controllers/subsystems/pai.dm b/code/controllers/subsystems/pai.dm
index 94ddfc25182..54d61d7ea8d 100644
--- a/code/controllers/subsystems/pai.dm
+++ b/code/controllers/subsystems/pai.dm
@@ -278,7 +278,7 @@ SUBSYSTEM_DEF(pai)
diff --git a/code/controllers/subsystems/processing/nanoui.dm b/code/controllers/subsystems/processing/nanoui.dm
index 85881096c5b..b6e6425b82b 100644
--- a/code/controllers/subsystems/processing/nanoui.dm
+++ b/code/controllers/subsystems/processing/nanoui.dm
@@ -42,7 +42,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* * ui_key - A string key used for the ui
*/
/datum/controller/subsystem/processing/nanoui/proc/get_open_ui(mob/user, src_object, ui_key)
- var/src_object_key = SOFTREF(src_object)
+ var/src_object_key = REF(src_object)
if (!LAZYLEN(open_uis[src_object_key]) || !LAZYLEN(open_uis[src_object_key][ui_key]))
return null
@@ -61,7 +61,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* Returns the number of UIs updated
*/
/datum/controller/subsystem/processing/nanoui/proc/update_uis(src_object)
- var/src_object_key = SOFTREF(src_object)
+ var/src_object_key = REF(src_object)
if (!LAZYLEN(open_uis[src_object_key]))
return 0
@@ -82,7 +82,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* Returns the number of UIs closed
*/
/datum/controller/subsystem/processing/nanoui/proc/close_uis(src_object)
- var/src_object_key = SOFTREF(src_object)
+ var/src_object_key = REF(src_object)
if (!open_uis[src_object_key] || !islist(open_uis[src_object_key]))
return 0
@@ -134,7 +134,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* * ui - The `/nanoui` ui to add
*/
/datum/controller/subsystem/processing/nanoui/proc/ui_opened(datum/nanoui/ui)
- var/src_object_key = SOFTREF(ui.src_object)
+ var/src_object_key = REF(ui.src_object)
LAZYINITLIST(open_uis[src_object_key])
LAZYADD(ui.user.open_uis, ui)
@@ -151,7 +151,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
* Returns FALSE if no ui was removed, TRUE if removed successfully
*/
/datum/controller/subsystem/processing/nanoui/proc/ui_closed(datum/nanoui/ui)
- var/src_object_key = SOFTREF(ui.src_object)
+ var/src_object_key = REF(ui.src_object)
var/ui_key = ui.ui_key
var/list/obj_uis = open_uis[src_object_key]
diff --git a/code/controllers/subsystems/processing/psi.dm b/code/controllers/subsystems/processing/psi.dm
index 6c3cb671f13..289aed120fd 100644
--- a/code/controllers/subsystems/processing/psi.dm
+++ b/code/controllers/subsystems/processing/psi.dm
@@ -32,10 +32,10 @@ PROCESSING_SUBSYSTEM_DEF(psi)
if(PC.psionic_rank >= PSI_RANK_SENSITIVE)
to_chat(PC.owner, SPAN_NOTICE(FONT_HUGE("The Nlom field prompts you for your emotional state.")))
to_chat(PC.owner,
- "Calm | Happy | \
- Sad | Fearful | \
- Angry | Stressed | \
- ConfusedCalm | Happy | \
+ Sad | Fearful | \
+ Angry | Stressed | \
+ Confused= complete_nlom_time)
diff --git a/code/controllers/subsystems/ticker.dm b/code/controllers/subsystems/ticker.dm
index 1583524456d..545d4df3239 100644
--- a/code/controllers/subsystems/ticker.dm
+++ b/code/controllers/subsystems/ticker.dm
@@ -483,7 +483,7 @@ var/datum/controller/subsystem/ticker/SSticker
var/datum/space_sector/current_sector = SSatlas.current_sector
var/html = SPAN_NOTICE("Current sector: [current_sector].") + {"\
\
- Click here \
+ Click here \
to see every possible site/ship that can potentially spawn here.\
\
"}
diff --git a/code/controllers/subsystems/zcopy.dm b/code/controllers/subsystems/zcopy.dm
index aa7bdda7d48..83afc220cb3 100644
--- a/code/controllers/subsystems/zcopy.dm
+++ b/code/controllers/subsystems/zcopy.dm
@@ -641,7 +641,7 @@ SUBSYSTEM_DEF(zcopy)
out += "