From 0b296ee7a47936b69cde5d7d99c8e56663f0d696 Mon Sep 17 00:00:00 2001 From: William Lemon Date: Sat, 16 May 2020 02:58:46 +1000 Subject: [PATCH] Fix Ambition Box (#8874) --- code/datums/mind.dm | 2 +- code/game/antagonist/antagonist_objectives.dm | 2 +- html/changelogs/tehflamintaco - FixAmbitionBox.yml | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 html/changelogs/tehflamintaco - FixAmbitionBox.yml diff --git a/code/datums/mind.dm b/code/datums/mind.dm index f2c943a7d23..6ed7c81b9bd 100644 --- a/code/datums/mind.dm +++ b/code/datums/mind.dm @@ -217,7 +217,7 @@ memory = new_memo else if (href_list["amb_edit"]) - var/new_ambition = input("Enter a new ambition", "Memory",src.ambitions) as null|message + var/new_ambition = input("Enter a new ambition", "Memory",html_decode(src.ambitions)) as null|message if(isnull(new_ambition)) return src.ambitions = sanitize(new_ambition) diff --git a/code/game/antagonist/antagonist_objectives.dm b/code/game/antagonist/antagonist_objectives.dm index d0c9d4d4d08..96591eae1ed 100644 --- a/code/game/antagonist/antagonist_objectives.dm +++ b/code/game/antagonist/antagonist_objectives.dm @@ -42,7 +42,7 @@ return var/new_ambitions = input(src, "Write a short sentence of what your character hopes to accomplish \ today as an antagonist. Remember that this is purely optional. It will be shown at the end of the \ - round for everybody else.", "Ambitions", mind.ambitions) as null|message + round for everybody else.", "Ambitions", html_decode(mind.ambitions)) as null|message if(isnull(new_ambitions)) return new_ambitions = sanitize(new_ambitions) diff --git a/html/changelogs/tehflamintaco - FixAmbitionBox.yml b/html/changelogs/tehflamintaco - FixAmbitionBox.yml new file mode 100644 index 00000000000..9e8d5e51ee9 --- /dev/null +++ b/html/changelogs/tehflamintaco - FixAmbitionBox.yml @@ -0,0 +1,4 @@ +author: Teh Flamin'Taco +delete-after: True +changes: + - bugfix: "Set-Ambition should no-longer be filled with HTML constructs when edited."