From 0e24efc541fdadd3e37caf7b52c305b86a12d19f Mon Sep 17 00:00:00 2001
From: Fluffy <65877598+FluffyGhoster@users.noreply.github.com>
Date: Sun, 24 Dec 2023 18:19:37 +0100
Subject: [PATCH] Sounds static reference check (#18023)

* sfad

* sadfa

* dsfsd

* sdf

* sd

* sdaf

* this is supposed to fail

* nice
---
 .../fluffyghost-soundstaticrefcheck.yml       | 41 +++++++++++++++++++
 tools/ci/check_grep.sh                        | 11 +++++
 2 files changed, 52 insertions(+)
 create mode 100644 html/changelogs/fluffyghost-soundstaticrefcheck.yml

diff --git a/html/changelogs/fluffyghost-soundstaticrefcheck.yml b/html/changelogs/fluffyghost-soundstaticrefcheck.yml
new file mode 100644
index 00000000000..d68d6e64ba1
--- /dev/null
+++ b/html/changelogs/fluffyghost-soundstaticrefcheck.yml
@@ -0,0 +1,41 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes:
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   maptweak
+#   spellcheck (typo fixes)
+#   experiment
+#   balance
+#   admin
+#   backend
+#   security
+#   refactor
+#################################
+
+# Your name.
+author: FluffyGhost
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
+# Please surround your changes in  double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
+changes:
+  - backend: "The CI now checks that all sounds are referenced with a static path."
diff --git a/tools/ci/check_grep.sh b/tools/ci/check_grep.sh
index ab67d4f53af..1d77ab443d0 100755
--- a/tools/ci/check_grep.sh
+++ b/tools/ci/check_grep.sh
@@ -111,6 +111,17 @@ else
     echo "PASS: Did not find any DMM being included to be compiled."
 fi
 
+# Check that all the files in sound/ are referenced with static paths
+echo "Verifying sounds are referenced with static paths" >> code_error.log
+DYNAMIC_SOUNDS_REFERENCES=`grep -r --include \*.dm -E --regexp='"(sound\/.*)"'`
+if [[ $DYNAMIC_SOUNDS_REFERENCES != '' ]]; then
+    ERROR_COUNT=$(($ERROR_COUNT+1))
+    echo "FAIL: Found sound files referenced with dynamic paths:" >> code_error.log
+	echo $DYNAMIC_SOUNDS_REFERENCES >> code_error.log
+else
+    echo "PASS: All sounds are referenced with static paths" >> code_error.log
+fi
+
 echo "Found $ERROR_COUNT errors while performing code check"
 
 if [ $ERROR_COUNT -ne 0 ]; then