From 11359f0a3786ff2b95968906a469a2e0deca19d1 Mon Sep 17 00:00:00 2001 From: Doxxmedearly <38594443+Doxxmedearly@users.noreply.github.com> Date: Fri, 10 Jun 2022 06:51:30 -0400 Subject: [PATCH] Makes away ships no longer shuttle subtypes (#14224) --- code/modules/overmap/ships/computers/ship.dm | 4 +- .../overmap/ships/computers/shuttle.dm | 3 +- .../doxxmdearly-ships_not_shuttles.yml | 9 + icons/turf/areas.dmi | Bin 35790 -> 35928 bytes maps/_common/areas/special.dm | 9 + maps/away/ships/biesel.dm | 53 +- maps/away/ships/corporate.dm | 106 +-- maps/away/ships/ee_spy_ship.dmm | 324 +++---- maps/away/ships/fsf_patrol_ship.dmm | 642 +++++++------- maps/away/ships/orion_express_ship.dmm | 378 +++++---- maps/away/ships/sfa_patrol_ship.dmm | 678 +++++++-------- maps/away/ships/sol.dm | 106 +-- maps/away/ships/tcfl_peacekeeper_ship.dmm | 796 +++++++++--------- maps/away/ships/tramp_freighter.dmm | 492 ++++++----- maps/away/ships/wildcard.dm | 53 +- maps/sccv_horizon/code/sccv_horizon.dm | 6 - .../sccv_horizon/code/sccv_horizon_overmap.dm | 2 +- maps/sccv_horizon/sccv_horizon-3_deck_3.dmm | 62 +- 18 files changed, 1798 insertions(+), 1925 deletions(-) create mode 100644 html/changelogs/doxxmdearly-ships_not_shuttles.yml diff --git a/code/modules/overmap/ships/computers/ship.dm b/code/modules/overmap/ships/computers/ship.dm index dd365ebce60..3b2dfa01067 100644 --- a/code/modules/overmap/ships/computers/ship.dm +++ b/code/modules/overmap/ships/computers/ship.dm @@ -128,7 +128,5 @@ somewhere on that shuttle. Subtypes of these can be then used to perform ship ov . = ..() if(current_map.use_overmap && !linked) var/my_sector = map_sectors["[z]"] - if (istype(my_sector, /obj/effect/overmap/visitable)) + if(istype(my_sector, /obj/effect/overmap/visitable/ship)) attempt_hook_up(my_sector) - if(istype(linked, /obj/effect/overmap/visitable/ship)) - connected = linked diff --git a/code/modules/overmap/ships/computers/shuttle.dm b/code/modules/overmap/ships/computers/shuttle.dm index 1755535ac15..7e787fb4a65 100644 --- a/code/modules/overmap/ships/computers/shuttle.dm +++ b/code/modules/overmap/ships/computers/shuttle.dm @@ -50,11 +50,10 @@ if(href_list["pick"]) var/list/possible_d = shuttle.get_possible_destinations() var/D - if(possible_d.len) + if(length(possible_d)) D = input("Choose shuttle destination", "Shuttle Destination") as null|anything in possible_d else to_chat(usr,"No valid landing sites in range.") - possible_d = shuttle.get_possible_destinations() if(CanInteract(usr, physical_state) && (D in possible_d)) shuttle.set_destination(possible_d[D]) return TOPIC_REFRESH diff --git a/html/changelogs/doxxmdearly-ships_not_shuttles.yml b/html/changelogs/doxxmdearly-ships_not_shuttles.yml new file mode 100644 index 00000000000..3e263d6dedd --- /dev/null +++ b/html/changelogs/doxxmdearly-ships_not_shuttles.yml @@ -0,0 +1,9 @@ +author: Doxxmedearly +delete-after: True +changes: + - tweak: "Away ships are no longer shuttle subtypes. The ships will spawn on the overmap, there is no need to 'launch to open space' first, and there will not be a 'faint ship activity' sector. Away ships still have their own shuttles." + - maptweak: "Replaced the no longer needed shuttle control consoles with engine control consoles in away ship helms, if the ship did not have one in the helm." + - maptweak: "Added a navpoint to all away ships at their external airlocks; if a shuttle can fit, it can dock right up against the ship!" + - bugfix: "Fixed the generic shuttle landing point for away ships not appearing as a valid destination, and renamed them to better describe the landing area." + - bugfix: "Fixed bugs relating to airlocks disappearing or not functioning once one leaves the 'faint ship activity' area, since this no longer happens." + \ No newline at end of file diff --git a/icons/turf/areas.dmi b/icons/turf/areas.dmi index 81b119a5cd2ca73523a7796579519df5987ebb18..9a690d4b36b609a20b4ec351dcd5a04e44d7a100 100755 GIT binary patch delta 4319 zcmV<55Fqc)mjc+B0+1vDoUtW|1{*-FgfBH~zTW)w`z9G)OctMRwZ=(PW#D6j7SRl0}5yMoJnJcNW481@9RNA%Xt@NVAoND6`u@ z6^SNNuuG6gLz7A2-1XVB=iFa&XYQRh-;eb4=Kegh@2z&ed(OG{Zk^cC&^$su5hR6< zmameKpsRU=d?H8+9q9p*?G~2MvGRF*{U(2>@n!NkaF38Y^1{ju;)kbNb-7`(j-EW* zd%6%MniQG$GbH@wutHZc;V)n4%ZE?I#O48o`p1YQE^Hi@aFKmua)?sHU+&!(#?r!F z+8E6S(fOohUeAR}uGdD6(S%Y6E3d~AIW3AGi*o`<6BN=rLo`l4P0aaSL))7~hQEKL z$4Az2LhTWPM~0)M$4Az2LhZ4FhhvGKT(sr%2!UP17xoH?8M*2!B!qaq1{XLQwM35- zHu7Dz=a3r4ifJp+KO|hZXGrrHIZ~3JH4&84*BayMcsVxLCwGi5Tow`|PP7bJ#g!|d zoS5nRgTKWHo7TmT43|ZFfTRejMecuQinBxW{%G%|<`-z*AMHICIey4yhg>xIJVRzZ z&g$~6@*0v8lrvTeoRARv+Y^!6)Ma55QW7g^|OSt&jOD037 zgt?>`N==-$LRoU9S8P&riO`rs6EB)~hhOvXm$fo1WS1v5b5D@F)>ec`kI^sKf++Ur z42`o@U{(%|mXk9U(vGybh_F{KmOv^koD3|16eFBMg2xJR#f%NjdoYu=dPxG#9g=%F z0cVpsdq)9^lY)CY59uyE8#cRr(gKa9_lN@|X0X~yw zd^iENlc0PS19g9-lev5@0k@Ord`30(PXC*{+XeuDVLW`Q`$J9p@BWGYQPX~HI_h7j zY5$wcFFdSi|Cjs!zEacv(mCy^>i2)YdA=ahDMu^h;lOlq!3Jd_y1Rp=TvikVZ zl~pbK-2vT`W%uIk@?E?3m0Puc#zA*T>;5QspzlF7aykP1Z4@JoTCeP`_R=quwT}G zj!2O0F?0CDPfh!&Y}@zWnte<3wCEwSkb+|j@iVD?mkT6?&IH1T=t(Y+6gm(-+ez-K zE^Qv42+H;VacZv)f&H@fOUyS!eAKo-)YjB&ll>TP4{zt9$g1b-j-P5 zQQQ7GtOV##VzjS50V@GIlo;)+kKq>GI)5Z0x<2^J@YEN_mi=i;d3J%a5-dvMDKJ%5<<_FHu8@DANM zlI=0#1NNt9asgEPKXKR(+bSdrvjv2$1=q_+K`%>Das(f%9H zJ=|!X9xW6m+ca8TMV3SIzCIucp9ds&KG;v=lXt$oB44@oizh+L2Z>ziA?r&6`{nIh zfCED#C|Th z=YgGtz*eWfQ2*F(cK)?D?AGFV_L@9I{N}sQH z=tAh?;FM&Z$EEcS?GX|E`5v_Ydr#eeiRcm${p31m^Jvum-2-4QOd@=I$6jnXlXHS5 ze{qX~XH4&v{H&e$u|$w1Xg=KOeoORN2z|KI9WLl2>`9{6+13*vOwE*Hae8=zP6c* zAEI#5Zs-ADTA;*wfJ)jUy66py9XBQX{I8tE>0&!UTMs2m6iL4S;m19m_rpV2e<^iV zxJ!;%oy=P@toL9(+ zBPou|J z;VNxKSjgj}5n5U16Fs3ZyuVgg3SYQO_OVu$xq3NPNpwEPm>!{A!Q&G-DRXLGnyE#R zB~~n9lrpa+l5&BV0ozDOV1xw8RAH)Z!wD28Oo-?jD_ZQ0G$7P`Q?U)*1S%N8x1LFxY*%kizET$^X_OXb5guP(mN9pE8GLb^M|zZ zx%(`f_oI1ud|n@4_)8NkJ`YbQ#Knb<6g_iEf(ANPsLQG^C4L-Mf8LMPmk3@X0D#WZ zue_ojRTC0H(yOC+fP8jG%>i=bV^)D#f+yDdBkMwCiEj@eUw%+3miX}r5=#VWWvgCm zn?n+~{QYrtF=I>S72VtE_N-N4lGuK+3=M(Bh#xIsnb&E;B}D{j;~<6r07OqbHPWM# zJC8PpW}}&-FaQ9{e`D&SFeGz63Zn!Uj>4E29EGuLN*;xgLq|ka4~pp5^kGf=cb|K| z>K}l&9=&zHrv0l=-+Qg5eXwkPe($r(HSPcL_wUy|G{zq?rz5nKW?%lP&eE*}j>)qY< z!asLkAKtE&-8H@^007X@_W|+=m99IzAVLTkF8}}qM@d9MRDxtVB$g`C9nihe4-+gz zzv}<#uDeb5f08VxjE^1TupXLR3=xGzk~Rj|l>D6Vc>@4|pS+!*xd@tx$eE+~;iAQf zAYLcSTAdrG^_7$guV~%~cqPhWi6w-{001D4rgDHBxgji{$m!Q~V`-r=CwNMDe|%^n zN6zWy4bAV%f0>fdeZb&0;unI z&R!NHd4HUU$q_4|adQztPO!)@mWHp7^Zdlj<4Ao-@rNycFw5{5pFd_!Eu0p*uTp}8 z-}_K+RqD?kONx+`_mFZQR%lc9vF=fRh9y4J(tNOao&LJ|?A%L=Ac!IWwhvtZb=~RN z%Yui%lk$f-f2n1h_>pKL2mr8MG!+7qqDL$9m(@3=ZLY-R^bnE z@oTG{ms1~(@*ytg<)ImAe=1LmZ}pobrk@rc;$BwowED0Jaxh0BK<@ z-_rIJ5d^X1#S$sLvL$G=F(I)u)&nwS-cT57tOsrGoWA?bxmVw3WeLofIaNKGBl)6x%t}7!@FPHJ#zJTzqotE-!*uDSN8R9 zmAQvBh9+KHtEp0LELAAQdaNYUtCKP&^&W|kfAkE%5@|{R5&09HW5=epNu+qm!HK3J zb2wz!%9Z&tcU~77?;~fm)znG1QzrJ7S`}CFzLtU|etaS)MKDPqf&f?+%?Y4Zkm4m( z5J?dgJKhp2R=o?EwHVqeDUzh{;tANHgz34^@cedKrvz`_r&+P?Ej;k`86eDuCC$_;M9k4%*KSNW3>Lh z-K1-ahuEzFroXf8LlZ$#xa6!LE4}Ire*lnAQvztNIPZ|p%Oex0W3l%C(b`MlJIr** zMv2z(7?$l?g!V$JiQMN$iXKZC`P!|%eB(*&cOpb0tj3rX2)mWn3QouY5&pZ%r|F2#o7nlr9=Bw)m0u-A z3ZEO|2Y_~f0BV>Pm$rjp#3pn5e{yAFMC7&#&9Mjx6RTZIj82^!08j_)0|X`m59N5Y zLrtwcf?Pd5TL1uv2Oc0W8F)a4;X=l@zmX%g9smHqV<3P4XoM+FaECAg0D#9J1O@;A z0D#2-0R#X50D#2-0R#X50D#2-0R#X5BY`FG0JIAP5C8xG02asp01@0p5dj8Pn2Z1b N002ovPDHLkV1gEkV`~5a delta 4217 zcmV-<5QgvAm;%n10+1vDnXx5_1{i#)mGJfEr{CXf-n@Hz`7ghI;BY{m{qM8M2FP)L zBpM`|m}a+)5KXoTY0|AMSw#4~v?j%=n`9zQuI$FL;LV~X5 z5%P&3DRiUaZcWGlZ8$=hA zmU%rFD!E=8IYtvoA*{R}OXRdDek?8sAWcw6?+np6`7|--cMWZC5*hxI9v@kM#|gDZ z2p$=Zk{%yf#|gE^3LcInesa;4(<20S8DH2dBxdBQuaFSp^%`8@Xw(utPT0tI*`7mc z7%Qf&ME{U*;hrJQW8_Fle%3@#PG4(`tK;R^T%X)AzHnJcj5yIUWEEGgfO2A{@7I5c z5jL%h9~mx-_5eu{REylr6laHj=Kay$OU*CPyg%A|E^_>k%?`O}@_B~LdYskeUF9_- zCn#sE6gVM4G!)H?b8g$S+ACC+^T`!tDS|0AA=^nj9d2z&VrCdoCjE3aiuZWD2pP0RaSvNI&8tW{l<$3fTbT zqvaE&Vl7?YwUZ-!N&zvGZhSZzb~RK602qgmcgJcAd3Zu|LI43kWQ&$ff2@+HO*fCyS&>50DxgUey;mtP5U4IiT+X3er-DHU#V&TyQ{A}u4(@_hyT7-)Be&q z>#6GZf9{iNeIx|uh@SnEl6@ipN|UvHB?y-Z3ZU(2_l1+E^vSi=J1;%nrpzB2gN+c4jS$^ozS=>*1+g|lyngt@hKT69 zhcB<)wJVpjkBt!PQeq=S>HSF&L0AO_0BC|wpIlpg`sCWGmi=x`4`kWBc)NVpu6^ZJ z?Vq#mj%d>#2M_dJcSq+hUKhF!aQ*Oy&36x9UURXd37_kSKWyB8i`Rv&!EPZ1Pf9op z0tf)m1gYMgDd;zJ%h#@nmVQIGe@X(wimn4f1#`>E{O_us007s9IP8S>F@=vJ(EXRrvVZQt?& zS#5=}yg*hPSQa;b@4ogpH76)b0OcHAz}tte=7IgP_H#snY>%14Cw^+$Pi5D>|JLkV zqNhayO9{h_v|W|!>8czbv|7e!V*Zx4wm=S^{fK?^a-G29D(V|ip^JutQH6Vb)QXPE~i zMUd<#lcqB~L_G0X<^f3&B>TyvX?Td{i6&ZdMUhVg6%jzOl>9Fg_NTEQvnNmJ0XRf_ z)V5!eIez~w*yqBI@vDA$o{aeQ_ADxn_m+_NP-4lR{Q-Q+$*Nunj`mtTiZUU zgHNzHF=TmjWIY#0CGQdJCfb8rKIr+woVVYhJ4g5E-mz?t5g)KWJ(CNd+W(2ee%O8q zv7jX?5A`}tWq(ZO@cq}e&xMK=%Hr=aK>UDM+(X=dD#y;DUBkZ4&AYEX4!u(BYx8UM zMFddo2Mg>Ev+u-#d&P<*_lljv5+Swi4`uG(e~b3tdFk<1^Ymz;FxjTj>MF7vlK1ri zN%%Y35T0ThRN)K6I8rUyy-x3U3*_t#SEld#fJIm$`d?h@OSO zCf!>o;V26*j5~DahwZu4R0w^%*X8Z^(E1JtOx$w@`5v21`?QSj_bl`~SX%J#kl2I0 z?ts_3vJ9K?ej%n7Je<{PdjiqZKBIeow2cnsyRU8L;)f`lv>STBmli0o9-xx;h%S4> zV#iGhKmRKyak|(}(AGoA5=D|9fBN}==l$>yR)0#J74DK_R;Tk4K`BTPWYuxF*T?4t zS}I)RXk|`pzZj%v$cZFg&xMm#zdk)Xk$qytmh%cZaU_M3D|7FWL)Ke!0MH8B!(ZzY z)1D&;V!~*?-IvGmzJzv&u1)T$u?qsIbl4zP{A~B1dT6+K;ki3nK9AMchc7Q^yX_Bn z4u232hsp4mD{K9&I(a>I$Sovzh@O7tDI!qj0hJU;zA)DmbGDH1Y>65vRxCj?MCfR6 zp<-P-a@zoCiJVOX-Fqo9Aj4_eyVZY8+m^jhIfnhNJ3qhewC_LP@46eOeZMB6-~Rvl z^Zl;7A^W)U&Aa_t%n>XTCFB5c?~c#QV}FGvLhuK%3|DC@!a^P&jnK+6pXdpV;r+F` zQuxAMvX8a0%+<@WN}}@x#`Fl~3Lc-xNtsjg(o8LiEU{t4A@0N0wW|y zrV3N-8cv`%VM0VVSosDKeRJCP-^f0eu#xi`Hp+&;vd0GUel(Gjvtq2&Dl?8;Ie%u= zMbB3#2g-?{m^R#w&&wBdD9 z+-OKa!^I9STOd5@_&A;zC`dE0RVKKfAdZCsG5)nl3pFn1LU(iY7USa zAF~R~5X>q zQ5Yq-bQH$K;3$k`Q}QT`96BPZdQe2ap^t0YzyH!-tNsCa@5y@)Yudm5{DZe^+6T+# z*AM=7wWj^AzWVCJn)U$z^=RTOFaQ7m0Dvih00IC20KnpCN&xXQZmcqYrL}@-(5CET-J|>rOMIpP08j#5 z0CnBj`I8ceJ%0%R09vG}5SSD_TA9DBzA0^UB_^kbD9xKhlrJD;-cKn(B5nAD$1Wrg z=X&4d9NP7mKm-8*=0;u;G!K0>mO%l^j3n9w3n0s<_Xmw+LE)YQgfPXom3m`45SOB~;`ZCOk7BOfi?{K2Uw)OAbFfc%8?ei$7Eq4}+ei1mynpQK?|*s!n7?cA{;urn-zswtX$(!gwpLT6+E}VkiuG7Yq*o_pOzJ%X z0G3Hp0*J_;=o~vXwM`<$OAbyn4Vl9s!&a`$mw&nQy3lwZIjgOvPP&~kvA5K!xRUp^ z6fE)M6FKnq003fXP5`xn6fdcQNQ$V~@s?Pz>RrgJ#n4tsktBr|Prwc(OwR>u6c`6Y z4gjD8d8@!iM24uO*Jj8r(L?TQs8^_@H)u?;6LSb>te2?dJ;}`#wRWv7HEdP;h>6gO zEr0Fj4E^j=tpWo8fH~2W0E!VixhKBQW&a=T%&#dKb9EJe0H;2TV>TvC9i#R4?IvAY zJj8AdF#VkY0KoicN&w9j=NO-r#w9PR?^K&eLBA2vV@3Gea0ML{G z3Wcd+kGn{nw?$HRc(%sz_L8C~_8~~rw%7?#