From 11359f0a3786ff2b95968906a469a2e0deca19d1 Mon Sep 17 00:00:00 2001
From: Doxxmedearly <38594443+Doxxmedearly@users.noreply.github.com>
Date: Fri, 10 Jun 2022 06:51:30 -0400
Subject: [PATCH] Makes away ships no longer shuttle subtypes (#14224)
---
code/modules/overmap/ships/computers/ship.dm | 4 +-
.../overmap/ships/computers/shuttle.dm | 3 +-
.../doxxmdearly-ships_not_shuttles.yml | 9 +
icons/turf/areas.dmi | Bin 35790 -> 35928 bytes
maps/_common/areas/special.dm | 9 +
maps/away/ships/biesel.dm | 53 +-
maps/away/ships/corporate.dm | 106 +--
maps/away/ships/ee_spy_ship.dmm | 324 +++----
maps/away/ships/fsf_patrol_ship.dmm | 642 +++++++-------
maps/away/ships/orion_express_ship.dmm | 378 +++++----
maps/away/ships/sfa_patrol_ship.dmm | 678 +++++++--------
maps/away/ships/sol.dm | 106 +--
maps/away/ships/tcfl_peacekeeper_ship.dmm | 796 +++++++++---------
maps/away/ships/tramp_freighter.dmm | 492 ++++++-----
maps/away/ships/wildcard.dm | 53 +-
maps/sccv_horizon/code/sccv_horizon.dm | 6 -
.../sccv_horizon/code/sccv_horizon_overmap.dm | 2 +-
maps/sccv_horizon/sccv_horizon-3_deck_3.dmm | 62 +-
18 files changed, 1798 insertions(+), 1925 deletions(-)
create mode 100644 html/changelogs/doxxmdearly-ships_not_shuttles.yml
diff --git a/code/modules/overmap/ships/computers/ship.dm b/code/modules/overmap/ships/computers/ship.dm
index dd365ebce60..3b2dfa01067 100644
--- a/code/modules/overmap/ships/computers/ship.dm
+++ b/code/modules/overmap/ships/computers/ship.dm
@@ -128,7 +128,5 @@ somewhere on that shuttle. Subtypes of these can be then used to perform ship ov
. = ..()
if(current_map.use_overmap && !linked)
var/my_sector = map_sectors["[z]"]
- if (istype(my_sector, /obj/effect/overmap/visitable))
+ if(istype(my_sector, /obj/effect/overmap/visitable/ship))
attempt_hook_up(my_sector)
- if(istype(linked, /obj/effect/overmap/visitable/ship))
- connected = linked
diff --git a/code/modules/overmap/ships/computers/shuttle.dm b/code/modules/overmap/ships/computers/shuttle.dm
index 1755535ac15..7e787fb4a65 100644
--- a/code/modules/overmap/ships/computers/shuttle.dm
+++ b/code/modules/overmap/ships/computers/shuttle.dm
@@ -50,11 +50,10 @@
if(href_list["pick"])
var/list/possible_d = shuttle.get_possible_destinations()
var/D
- if(possible_d.len)
+ if(length(possible_d))
D = input("Choose shuttle destination", "Shuttle Destination") as null|anything in possible_d
else
to_chat(usr,"No valid landing sites in range.")
- possible_d = shuttle.get_possible_destinations()
if(CanInteract(usr, physical_state) && (D in possible_d))
shuttle.set_destination(possible_d[D])
return TOPIC_REFRESH
diff --git a/html/changelogs/doxxmdearly-ships_not_shuttles.yml b/html/changelogs/doxxmdearly-ships_not_shuttles.yml
new file mode 100644
index 00000000000..3e263d6dedd
--- /dev/null
+++ b/html/changelogs/doxxmdearly-ships_not_shuttles.yml
@@ -0,0 +1,9 @@
+author: Doxxmedearly
+delete-after: True
+changes:
+ - tweak: "Away ships are no longer shuttle subtypes. The ships will spawn on the overmap, there is no need to 'launch to open space' first, and there will not be a 'faint ship activity' sector. Away ships still have their own shuttles."
+ - maptweak: "Replaced the no longer needed shuttle control consoles with engine control consoles in away ship helms, if the ship did not have one in the helm."
+ - maptweak: "Added a navpoint to all away ships at their external airlocks; if a shuttle can fit, it can dock right up against the ship!"
+ - bugfix: "Fixed the generic shuttle landing point for away ships not appearing as a valid destination, and renamed them to better describe the landing area."
+ - bugfix: "Fixed bugs relating to airlocks disappearing or not functioning once one leaves the 'faint ship activity' area, since this no longer happens."
+
\ No newline at end of file
diff --git a/icons/turf/areas.dmi b/icons/turf/areas.dmi
index 81b119a5cd2ca73523a7796579519df5987ebb18..9a690d4b36b609a20b4ec351dcd5a04e44d7a100 100755
GIT binary patch
delta 4319
zcmV<55Fqc)mjc+B0+1vDoUtW|1{*-FgfBH~zTW)w`z9G)OctMRwZ=(PW#D6j7SRl0}5yMoJnJcNW481@9RNA%Xt@NVAoND6`u@
z6^SNNuuG6gLz7A2-1XVB=iFa&XYQRh-;eb4=Kegh@2z&ed(OG{Zk^cC&^$su5hR6<
zmameKpsRU=d?H8+9q9p*?G~2MvGRF*{U(2>@n!NkaF38Y^1{ju;)kbNb-7`(j-EW*
zd%6%MniQG$GbH@wutHZc;V)n4%ZE?I#O48o`p1YQE^Hi@aFKmua)?sHU+&!(#?r!F
z+8E6S(fOohUeAR}uGdD6(S%Y6E3d~AIW3AGi*o`<6BN=rLo`l4P0aaSL))7~hQEKL
z$4Az2LhTWPM~0)M$4Az2LhZ4FhhvGKT(sr%2!UP17xoH?8M*2!B!qaq1{XLQwM35-
zHu7Dz=a3r4ifJp+KO|hZXGrrHIZ~3JH4&84*BayMcsVxLCwGi5Tow`|PP7bJ#g!|d
zoS5nRgTKWHo7TmT43|ZFfTRejMecuQinBxW{%G%|<`-z*AMHICIey4yhg>xIJVRzZ
z&g$~6@*0v8lrvTeoRARv+Y^!6)Ma55QW7g^|OSt&jOD037
zgt?>`N==-$LRoU9S8P&riO`rs6EB)~hhOvXm$fo1WS1v5b5D@F)>ec`kI^sKf++Ur
z42`o@U{(%|mXk9U(vGybh_F{KmOv^koD3|16eFBMg2xJR#f%NjdoYu=dPxG#9g=%F
z0cVpsdq)9^lY)CY59uyE8#cRr(gKa9_lN@|X0X~yw
zd^iENlc0PS19g9-lev5@0k@Ord`30(PXC*{+XeuDVLW`Q`$J9p@BWGYQPX~HI_h7j
zY5$wcFFdSi|Cjs!zEacv(mCy^>i2)YdA=ahDMu^h;lOlq!3Jd_y1Rp=TvikVZ
zl~pbK-2vT`W%uIk@?E?3m0Puc#zA*T>;5QspzlF7aykP1Z4@JoTCeP`_R=quwT}G
zj!2O0F?0CDPfh!&Y}@zWnte<3wCEwSkb+|j@iVD?mkT6?&IH1T=t(Y+6gm(-+ez-K
zE^Qv42+H;VacZv)f&H@fOUyS!eAKo-)YjB&ll>TP4{zt9$g1b-j-P5
zQQQ7GtOV##VzjS50V@GIlo;)+kKq>GI)5Z0x<2^J@YEN_mi=i;d3J%a5-dvMDKJ%5<<_FHu8@DANM
zlI=0#1NNt9asgEPKXKR(+bSdrvjv2$1=q_+K`%>Das(f%9H
zJ=|!X9xW6m+ca8TMV3SIzCIucp9ds&KG;v=lXt$oB44@oizh+L2Z>ziA?r&6`{nIh
zfCED#C|Th
z=YgGtz*eWfQ2*F(cK)?D?AGFV_L@9I{N}sQH
z=tAh?;FM&Z$EEcS?GX|E`5v_Ydr#eeiRcm${p31m^Jvum-2-4QOd@=I$6jnXlXHS5
ze{qX~XH4&v{H&e$u|$w1Xg=KOeoORN2z|KI9WLl2>`9{6+13*vOwE*Hae8=zP6c*
zAEI#5Zs-ADTA;*wfJ)jUy66py9XBQX{I8tE>0&!UTMs2m6iL4S;m19m_rpV2e<^iV
zxJ!;%oy=P@toL9(+
zBPou|J
z;VNxKSjgj}5n5U16Fs3ZyuVgg3SYQO_OVu$xq3NPNpwEPm>!{A!Q&G-DRXLGnyE#R
zB~~n9lrpa+l5&BV0ozDOV1xw8RAH)Z!wD28Oo-?jD_ZQ0G$7P`Q?U)*1S%N8x1LFxY*%kizET$^X_OXb5guP(mN9pE8GLb^M|zZ
zx%(`f_oI1ud|n@4_)8NkJ`YbQ#Knb<6g_iEf(ANPsLQG^C4L-Mf8LMPmk3@X0D#WZ
zue_ojRTC0H(yOC+fP8jG%>i=bV^)D#f+yDdBkMwCiEj@eUw%+3miX}r5=#VWWvgCm
zn?n+~{QYrtF=I>S72VtE_N-N4lGuK+3=M(Bh#xIsnb&E;B}D{j;~<6r07OqbHPWM#
zJC8PpW}}&-FaQ9{e`D&SFeGz63Zn!Uj>4E29EGuLN*;xgLq|ka4~pp5^kGf=cb|K|
z>K}l&9=&zHrv0l=-+Qg5eXwkPe($r(HSPcL_wUy|G{zq?rz5nKW?%lP&eE*}j>)qY<
z!asLkAKtE&-8H@^007X@_W|+=m99IzAVLTkF8}}qM@d9MRDxtVB$g`C9nihe4-+gz
zzv}<#uDeb5f08VxjE^1TupXLR3=xGzk~Rj|l>D6Vc>@4|pS+!*xd@tx$eE+~;iAQf
zAYLcSTAdrG^_7$guV~%~cqPhWi6w-{001D4rgDHBxgji{$m!Q~V`-r=CwNMDe|%^n
zN6zWy4bAV%f0>fdeZb&0;unI
z&R!NHd4HUU$q_4|adQztPO!)@mWHp7^Zdlj<4Ao-@rNycFw5{5pFd_!Eu0p*uTp}8
z-}_K+RqD?kONx+`_mFZQR%lc9vF=fRh9y4J(tNOao&LJ|?A%L=Ac!IWwhvtZb=~RN
z%Yui%lk$f-f2n1h_>pKL2mr8MG!+7qqDL$9m(@3=ZLY-R^bnE
z@oTG{ms1~(@*ytg<)ImAe=1LmZ}pobrk@rc;$BwowED0Jaxh0BK<@
z-_rIJ5d^X1#S$sLvL$G=F(I)u)&nwS-cT57tOsrGoWA?bxmVw3WeLofIa