From 127d026485460c90ed3c238ba3a931facbdca601 Mon Sep 17 00:00:00 2001 From: hazelrat <83198434+hazelrat@users.noreply.github.com> Date: Mon, 10 Aug 2026 01:37:14 +0100 Subject: [PATCH] IPC P2P QoL (#23015) Messages are now sent to both parties in IPC P2P communications, to make the mechanic a little more responsive. Also adjusts some of the code to get it functional on my machine. --- .../tgui/modules/neural_configuration.dm | 7 ++- html/changelogs/hazelmouse-feedback.yml | 58 +++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/hazelmouse-feedback.yml diff --git a/code/modules/tgui/modules/neural_configuration.dm b/code/modules/tgui/modules/neural_configuration.dm index 71e2c3a03c5..fabf6f48b91 100644 --- a/code/modules/tgui/modules/neural_configuration.dm +++ b/code/modules/tgui/modules/neural_configuration.dm @@ -72,9 +72,14 @@ var/message = sanitize_tg(tgui_input_text(owner, "Enter a peer-to-peer message to send to [connected_ipc.real_name].", "Virtual Communication", max_length = MAX_MESSAGE_LEN)) // re-do all the checks just in case. bit ass but oh well - if(message && !port.is_broken() && (port.access_cable.target && port.access_cable.target == connected_ipc && !other_port.is_broken())) + var/mob/target_owner + if(istype(port.access_cable.target, /obj/item/organ/internal/machine/access_port)) + var/obj/item/organ/internal/machine/access_port/target_port = port.access_cable.target + target_owner = target_port.owner + if(message && !port.is_broken() && (target_owner == connected_ipc && !other_port.is_broken())) var/p2p_message = SPAN_ITALIC("Virtual Communication, ") + SPAN_BOLD("[owner.real_name] transmits: ") + SPAN_MACHINE_WARNING(message) to_chat(connected_ipc, p2p_message) + to_chat(owner, p2p_message) log_say("VIRTUAL COMMUNICATION: [owner]/[owner.client.ckey] to [connected_ipc]/[connected_ipc.client.ckey]: [message]") . = TRUE else diff --git a/html/changelogs/hazelmouse-feedback.yml b/html/changelogs/hazelmouse-feedback.yml new file mode 100644 index 00000000000..b17cee43e01 --- /dev/null +++ b/html/changelogs/hazelmouse-feedback.yml @@ -0,0 +1,58 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: hazelmouse + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - rscadd: "IPC P2P communications now sends messages of transmissions to the chatboxes of both parties."