Fix Silicons See Offship (#21798)

It was possible for a player to incorrectly be able to view the
ghostroles in the Off-ship Manifest by entering any sort of camera, then
opening the manifest. This was most trivial to do with Borgs and AI, but
was also possible for player characters in some situations. This fixes
that by making it so that Eyes (a type of abstract mob used for cameras
and borgs), are specially excluded from viewing the Off-ship manifest.
Other types of observers should remain unaffected.
This commit is contained in:
VMSolidus
2026-02-06 15:25:05 -05:00
committed by GitHub
parent f6e4c08fcb
commit 16724e956c
3 changed files with 7 additions and 3 deletions
@@ -18,6 +18,6 @@
/datum/computer_file/program/manifest/ui_static_data(mob/user)
var/list/data = list()
data["manifest"] = SSrecords.get_manifest_list()
data["allow_follow"] = isobserver(usr)
data["show_ooc_roles"] = isabstractmob(usr)
data["allow_follow"] = isobserver(user)
data["show_ooc_roles"] = isabstractmob(user) && !isEye(user)
return data