diff --git a/aurorastation.dme b/aurorastation.dme index d38d5971b4e..a01acef097a 100644 --- a/aurorastation.dme +++ b/aurorastation.dme @@ -1678,7 +1678,6 @@ #include "code\modules\admin\verbs\diagnostics.dm" #include "code\modules\admin\verbs\dice.dm" #include "code\modules\admin\verbs\fps.dm" -#include "code\modules\admin\verbs\getlogs.dm" #include "code\modules\admin\verbs\map_template_loadverb.dm" #include "code\modules\admin\verbs\mapping.dm" #include "code\modules\admin\verbs\massmodvar.dm" diff --git a/code/__HELPERS/files.dm b/code/__HELPERS/files.dm index aebdf979c35..8a3649cb30c 100644 --- a/code/__HELPERS/files.dm +++ b/code/__HELPERS/files.dm @@ -24,57 +24,6 @@ return folders -//Sends resource files to client cache -/client/proc/getFiles() - for(var/file in args) - send_rsc(src, file, null) - -/client/proc/browse_files(root="data/logs/", max_iterations=10, list/valid_extensions=list(".txt",".log",".htm", ".json")) - var/path = root - - for(var/i=0, i 0) - to_chat(src, SPAN_WARNING("Error: file_spam_check(): Spam. Please wait [round(time_to_wait/10)] seconds.")) - return 1 - GLOB.fileaccess_timer = world.time + FTPDELAY - return 0 -#undef FTPDELAY - /// Returns the md5 of a file at a given path. /proc/md5filepath(path) . = md5(file(path)) diff --git a/code/modules/admin/admin_verbs.dm b/code/modules/admin/admin_verbs.dm index 3e797896526..2e5950c6cfb 100644 --- a/code/modules/admin/admin_verbs.dm +++ b/code/modules/admin/admin_verbs.dm @@ -30,7 +30,6 @@ GLOBAL_LIST_INIT(admin_verbs_admin, list( /client/proc/cmd_admin_delete, /*delete an instance/object/mob/etc*/ /client/proc/cmd_admin_check_contents, /*displays the contents of an instance*/ /datum/admins/proc/access_news_network, /*allows access of newscasters*/ - /client/proc/getserverlog, /*allows us to fetch server logs (diary) for other days*/ /client/proc/jumptocoord, /*we ghost and jump to a coordinate*/ /client/proc/jumptozlevel, /client/proc/jumptoshuttle, @@ -188,7 +187,6 @@ GLOBAL_LIST_INIT(admin_verbs_server, list( )) GLOBAL_LIST_INIT(admin_verbs_debug, list( - /client/proc/getruntimelog, // allows us to access runtime logs to somebody, /client/proc/cmd_admin_list_open_jobs, /client/proc/Debug2, /client/proc/DebugToggle, @@ -414,9 +412,7 @@ GLOBAL_LIST_INIT(admin_verbs_hideable, list( /datum/admins/proc/set_odyssey_canonicity, /client/proc/cmd_display_init_log, /client/proc/cmd_generate_lag, - /client/proc/getruntimelog, /client/proc/toggledebuglogs, - /client/proc/getserverlog, /client/proc/view_chemical_reaction_logs, /datum/admins/proc/capture_map, /turf/proc/view_chunk, @@ -489,7 +485,6 @@ GLOBAL_LIST_INIT(admin_verbs_dev, list( //will need to be altered - Ryan784 /client/proc/debug_controller, /client/proc/debug_variables, /client/proc/dsay, - /client/proc/getruntimelog, /client/proc/hide_most_verbs, /client/proc/kill_air, /client/proc/kill_airgroup, diff --git a/code/modules/admin/verbs/getlogs.dm b/code/modules/admin/verbs/getlogs.dm deleted file mode 100644 index 769e68fc2f3..00000000000 --- a/code/modules/admin/verbs/getlogs.dm +++ /dev/null @@ -1,55 +0,0 @@ -/* - HOW DO I LOG RUNTIMES? - Firstly, start dreamdeamon if it isn't already running. Then select "world>Log Session" (or press the F3 key) - navigate the popup window to the data/logs/runtime/ folder from where your tgstation .dmb is located. - (you may have to make this folder yourself) - - OPTIONAL: you can select the little checkbox down the bottom to make dreamdeamon save the log everytime you - start a world. Just remember to repeat these steps with a new name when you update to a new revision! - - Save it with the name of the revision your server uses (e.g. r3459.txt). - Game Masters will now be able to grant access any runtime logs you have archived this way! - This will allow us to gather information on bugs across multiple servers and make maintaining the TG - codebase for the entire /TG/station commuity a TONNE easier :3 Thanks for your help! -*/ - -/** - * Allows a client that has this proc to download the runtime logs of the current round - */ -/client/proc/getruntimelog() - set name = ".getruntimelog" - set desc = "Retrieve any session logfiles saved by dreamdeamon." - set category = null - - var/path = LOGPATH(GLOB.config.logfiles["world_runtime_log"]) - - if(file_spam_check()) - return - - message_admins("[key_name_admin(src)] accessed file: [path]") - src << run( file(path) ) - to_chat(src, "Attempting to send file, this may take a fair few minutes if the file is very large.") - - -//This proc allows download of past server logs saved within the data/logs/ folder. -//It works similarly to show-server-log. -/** - * Allows a client that has this proc the download of a log file of the active round - * - * Assigned only to admins currently - */ -/client/proc/getserverlog() - set name = ".getserverlog" - set desc = "Fetch logfiles from data/logs" - set category = null - - var/path = browse_files(LOGPATH("")) //Prompt for which file to download, understands subfolders from files - if(!path) - return - - if(file_spam_check()) - return - - message_admins("[key_name_admin(src)] accessed file: [path]") - src << run( file(path) ) - to_chat(src, "Attempting to send file, this may take a fair few minutes if the file is very large.") diff --git a/html/changelogs/arrow768-remove-file-access.yml b/html/changelogs/arrow768-remove-file-access.yml new file mode 100644 index 00000000000..745c4162045 --- /dev/null +++ b/html/changelogs/arrow768-remove-file-access.yml @@ -0,0 +1,58 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: arrow768 + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - server: "Removes verbs to get log files from the server, use the WI, TGS or logging infrastructure."