From 20b7dcc752cd617e5399aa1f5b7a5e9c5fab0b2d Mon Sep 17 00:00:00 2001
From: OneOneThreeEight <oneonethreeeight@outlook.com>
Date: Wed, 16 Jan 2019 16:19:22 -0500
Subject: [PATCH] Buffs ore summoners (#5849)

Allow me to explain in the event someone potentially complains about this.

Each vein of ore in a single tile drops roughly 5 bits of that ore type. It doesn't matter if it's diamonds, coal or whatever else.

The problem with this, however, is that the ore summoner is only adjusted to grab 10 bits of ore and nothing else, making it inefficient and useless to buy in the mining vendor.

This was changed because of 'performance problems' (whether this is true I have no idea) but only 10 bits of ore is just ridiculous in my opinion, because it means it'll only draw from 2 veins mined out, which is not effective in the slightest. You'd be better off using the ore magnet right now.

Of course, this change hopes to change that so that this isn't a useless item to buy from the ore vendor and to (somewhat) restore it to its former glory. Albeit with a sanity check.
---
 code/modules/mining/mine_items.dm             | 26 ++++++++-----
 .../SchevOreSummoner-27-12-2019.yml           | 37 +++++++++++++++++++
 2 files changed, 53 insertions(+), 10 deletions(-)
 create mode 100644 html/changelogs/SchevOreSummoner-27-12-2019.yml

diff --git a/code/modules/mining/mine_items.dm b/code/modules/mining/mine_items.dm
index 3ea052a60d0..f29ee5190f8 100644
--- a/code/modules/mining/mine_items.dm
+++ b/code/modules/mining/mine_items.dm
@@ -1130,17 +1130,23 @@ var/list/total_extraction_beacons = list()
 	force = 15
 	throwforce = 5
 	origin_tech = list(TECH_BLUESPACE = 4, TECH_ENGINEERING = 3)
+	var/last_oresummon_time = 0
 
 /obj/item/weapon/oreportal/attack_self(mob/user)
-	user << "<span class='info'>You pulse the ore summoner.</span>"
-	var/limit = 10
-	for(var/obj/item/weapon/ore/O in orange(7,user))
-		if(limit <= 0)
-			break
-		single_spark(O.loc)
-		do_teleport(O, user, 0)
-		limit -= 1
-		CHECK_TICK
+	if(world.time - last_oresummon_time >= 25)
+		to_chat(user, "<span class='notice'>You pulse the ore summoner.</span>")
+		last_oresummon_time = world.time
+		var/limit = 50
+		for(var/obj/item/weapon/ore/O in orange(7,user))
+			if(limit <= 0)
+				break
+			single_spark(O.loc)
+			do_teleport(O, user, 0)
+			limit -= 1
+			CHECK_TICK
+	else
+		to_chat(user, "The ore summoner is in the middle of some calibrations.")
+		return 0
 
 /******************************Sculpting*******************************/
 /obj/item/weapon/autochisel
@@ -1362,4 +1368,4 @@ var/list/total_extraction_beacons = list()
 
 	if(target)
 		target.overlays -= image_overlay
-	qdel(src)
\ No newline at end of file
+	qdel(src)
diff --git a/html/changelogs/SchevOreSummoner-27-12-2019.yml b/html/changelogs/SchevOreSummoner-27-12-2019.yml
new file mode 100644
index 00000000000..1a369c2415f
--- /dev/null
+++ b/html/changelogs/SchevOreSummoner-27-12-2019.yml
@@ -0,0 +1,37 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes: 
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   maptweak
+#   spellcheck (typo fixes)
+#   experiment
+#   balance
+#################################
+
+# Your name.  
+author: Scheveningen
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
+# Please surround your changes in  double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
+changes: 
+  - tweak: "Buffs ore summoners."