cyberpresidentvanellope/Aurora.3
1
0
Fork 0
mirror of https://github.com/Aurorastation/Aurora.3.git synced 2025-12-26 10:02:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes VueUI not updating (or closing or working properly) when re-opening existing UI (#10541)

Browse Source
This commit is contained in:
Jiří Barouš
2020-11-14 12:21:56 +01:00
committed by GitHub
parent dc97e90855
commit 215a1f3060
3 changed files with 21 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
code/controllers/subsystems/processing/vueui.dm
View File

@@ -110,10 +110,8 @@ Byond Vue UI framework's management subsystem
*/
/datum/controller/subsystem/processing/vueui/proc/ui_opened(var/datum/vueui/ui)
var/src_object_key = SOFTREF(ui.object)
LAZYINITLIST(open_uis[src_object_key])
LAZYINITLIST(ui.user.open_vueui_uis)
LAZYADD(ui.user.open_vueui_uis, ui)
LAZYADD(open_uis[src_object_key], ui)
LAZYDISTINCTADD(ui.user.open_vueui_uis, ui)
LAZYDISTINCTADD(open_uis[src_object_key], ui)
START_PROCESSING(SSvueui, ui)
/**
@@ -126,18 +124,19 @@ Byond Vue UI framework's management subsystem
/datum/controller/subsystem/processing/vueui/proc/ui_closed(var/datum/vueui/ui)
var/src_object_key = SOFTREF(ui.object)
if (!LAZYLEN(open_uis[src_object_key]))
return 0 // Wasn't open.
STOP_PROCESSING(SSvueui, ui)
if(!QDELETED(ui.user)) // Sanity check in case a user has been deleted (say a blown up borg watching the alarm interface)
LAZYREMOVE(ui.user.open_vueui_uis, ui)
open_uis[src_object_key] -= ui
if(!QDELETED(ui.user)) // Sanity check in case a user has been deleted (say a blown up borg watching the alarm interface)
LAZYREMOVE(ui.user.open_vueui_uis, ui) // remove the UI from the user
if (!LAZYLEN(open_uis[src_object_key]))
return FALSE // Wasn't open.
// remove this UI from the list of UIs for the object
open_uis[src_object_key] -= ui
if(!LAZYLEN(open_uis[src_object_key])) // remove the object from the open UI list if it references no more open UIs
open_uis -= src_object_key
return 1
return TRUE
/**
* Alerts of subsystem of logged off user and closes there uis.