Adds a unit test to check for any missing initial icon states (#8332)

2026-08-22 04:22:39 +01:00 · 2020-02-23 02:43:12 -03:00
parent bc7286647e
commit 21f348ec57
106 changed files with 214 additions and 304 deletions
@@ -182,7 +182,7 @@
 	anchored = 1
 	layer = 2
 	icon = 'icons/effects/blood.dmi'
-	icon_state = "gibbl5"
+	icon_state = "gib1"
 	random_icon_states = list("gib1", "gib2", "gib3", "gib4", "gib5", "gib6")
 	var/fleshcolor = "#FFFFFF"

@@ -1,7 +1,7 @@
 /obj/effect/projectile
 	name = "pew"
 	icon = 'icons/obj/projectiles.dmi'
-	icon_state = "nothing"
+	icon_state = null
 	layer = 4.5
 	anchored = TRUE
 	unacidable = TRUE
@@ -1,5 +1,6 @@
 /obj/effect/temp_visual/dir_setting/bloodsplatter
 	icon = 'icons/effects/bloodspatter.dmi'
+	icon_state = null
 	duration = 5
 	randomdir = FALSE
 	layer = BELOW_MOB_LAYER
@@ -3,7 +3,7 @@
 	name = "queen bee packet"
 	desc = "Place her into an apiary so she can get busy."
 	icon = 'icons/obj/seeds.dmi'
-	icon_state = "seed-kudzu"
+	icon_state = "vine2"
 	w_class = 1


@@ -47,7 +47,7 @@

 /obj/item/book/manual/hydroponics_beekeeping
 	name = "The Ins and Outs of Apiculture - A Precise Art"
-	icon_state ="bookHydroponicsBees"
+	icon_state ="bookbee"
 	author = "Beekeeper Dave"
 	title = "The Ins and Outs of Apiculture - A Precise Art"
 	dat = {"<html>
@@ -302,7 +302,7 @@ var/global/list/obj/item/device/pda/PDAs = list()

 // Special AI/pAI PDAs that cannot explode.
 /obj/item/device/pda/ai
-	icon_state = "NONE"
+	icon_state = null
 	ttone = "data"
 	newstone = "news"
 	detonate = 0
@@ -71,8 +71,8 @@ proc/within_jamming_range(var/atom/test) // tests if an object is near a radio j
 	var/last_updated = null
 	radius = 5
 	icon = 'icons/obj/assemblies/new_assemblies.dmi'
+	icon_state = "improvised_jammer_inactive"
 	icon_state_active = "improvised_jammer_active"
-	icon_state_inactive = "improvised_jammer_inactive"


 /obj/item/device/radiojammer/improvised/New(var/obj/item/device/assembly_holder/incoming_holder, var/obj/item/cell/incoming_cell, var/mob/user)
@@ -125,5 +125,5 @@ proc/within_jamming_range(var/atom/test) // tests if an object is near a radio j
 		last_updated = world.time
 	else
 		active_radio_jammers -= src
-		icon_state = icon_state_inactive
+		icon_state = initial(icon_state)
 		STOP_PROCESSING(SSprocessing, src)
@@ -3,7 +3,7 @@
 /obj/item/device/animaltagger
 	name = "animal tagger"
 	desc = "Used for tagging animals to be identified by a ear tag."
-	icon_state = "tagger0"
+	icon_state = "animal_tagger0"
 	force = 5.0
 	w_class = 2.0
 	throwforce = 5.0
@@ -39,4 +39,4 @@
 	if(!inputtag || !length(inputtag))
 		to_chat(user, "<span class='notice'>Invalid tag line.</span>")
 		return
-	animaltag = inputtag
+	animaltag = inputtag
@@ -237,7 +237,7 @@
 	name = ""
 	desc = ""
 	icon = 'icons/obj/toy.dmi'
-	icon_state = "null"
+	icon_state = null
 	anchored = 1
 	density = 0

@@ -84,6 +84,7 @@ obj/item/clothing/mask/chewable/Destroy()
 /obj/item/trash/spitwad
 	name = "spit wad"
 	desc = "A disgusting spitwad."
+	icon = 'icons/obj/clothing/masks.dmi'
 	icon_state = "spit-chew"

 /obj/item/clothing/mask/chewable/proc/spitout(var/mob/user, var/no_message)
@@ -138,6 +139,7 @@ obj/item/clothing/mask/chewable/Destroy()
 /obj/item/trash/spitgum
 	name = "old gum"
 	desc = "A disgusting chewed up wad of gum."
+	icon = 'icons/obj/clothing/masks.dmi'
 	icon_state = "spit-gum"

 /obj/item/clothing/mask/chewable/candy/gum
@@ -180,6 +182,7 @@ obj/item/clothing/mask/chewable/Destroy()
 /obj/item/trash/lollibutt
 	name = "popsicle stick"
 	desc = "A popsicle stick devoid of pop."
+	icon = 'icons/obj/clothing/masks.dmi'
 	icon_state = "lollipop_stick"

 /obj/item/clothing/mask/chewable/candy/lolli/update_icon()
@@ -224,4 +227,4 @@ obj/item/clothing/mask/chewable/Destroy()
 				"norepinephrine"))
 	reagents.add_reagent(payload, 15)
 	color = reagents.get_color()
-	desc = "[desc] This one is labeled '[initial(payload.name)]'."
+	desc = "[desc] This one is labeled '[initial(payload.name)]'."
@@ -1,7 +1,6 @@
 /obj/item/material/ashtray
 	name = "ashtray"
 	icon = 'icons/obj/ashtray.dmi'
-	icon_state = "blank"
 	randpixel = 5
 	force_divisor = 0.1
 	thrown_force_divisor = 0.1
@@ -98,4 +98,4 @@
 	thrown_force_divisor = 0.04 // 5 with weight 20 (steel)
 	throw_speed = 2
 	throw_range = 3
-	w_class = 2
+	w_class = 2
@@ -556,8 +556,8 @@
 	desc = "An old farming tool, not something you would find at hydroponics."

 /obj/item/material/twohanded/zweihander
-	icon_state = "zweihander"
-	base_icon = "zweihander"
+	icon_state = "zweihander0"
+	base_icon = "zweihander0"
 	name = "zweihander"
 	desc = "A german upgrade to the einhander models of ancient times."
 	force = 20
@@ -2,7 +2,7 @@
 /obj/item/taperoll
 	name = "tape roll"
 	icon = 'icons/policetape.dmi'
-	icon_state = "rollstart"
+	icon_state = "tape"
 	w_class = 2.0
 	var/turf/start
 	var/turf/end
@@ -109,7 +109,7 @@
 	name = "box of chewing wads master"
 	desc = "A generic brand of Waffle Co Wads, unflavored chews. Why do these exist?"
 	icon = 'icons/obj/cigs_lighters.dmi'
-	icon_state = "placeholder"
+	icon_state = "cigpacket"
 	item_state = "cigpacket"
 	drop_sound = 'sound/items/drop/shovel.ogg'
 	use_sound = 'sound/items/storage/pillbottle.ogg'
@@ -1,18 +0,0 @@
-// WIRES
-
-/obj/item/wire/proc/update()
-	if (src.amount > 1)
-		src.icon_state = "spool_wire"
-		src.desc = text("This is just spool of regular insulated wire. It consists of about [] unit\s of wire.", src.amount)
-	else
-		src.icon_state = "item_wire"
-		src.desc = "This is just a simple piece of regular insulated wire."
-	return
-
-/obj/item/wire/attack_self(mob/user as mob)
-	if (src.laying)
-		src.laying = 0
-		to_chat(user, "<span class='notice'>You're done laying wire!</span>")
-	else
-		to_chat(user, "<span class='warning'>You are not using this to lay wire...</span>")
-	return
@@ -621,7 +621,7 @@
 	name = "random coin"
 	desc = "This is a random coin."
 	icon = 'icons/obj/coins.dmi'
-	icon_state = "coin"
+	icon_state = "coin__heads"
 	problist = list(
 		/obj/item/coin/iron = 5,
 		/obj/item/coin/silver = 3,
@@ -441,6 +441,7 @@
 /obj/structure/closet/secure_closet/wall
 	name = "wall locker"
 	req_access = list(access_security)
+	icon = 'icons/obj/walllocker.dmi'
 	icon_state = "wall-locker1"
 	density = 1
 	icon_closed = "wall-locker"
@@ -132,6 +132,7 @@

 /obj/structure/door_assembly/multi_tile
 	icon = 'icons/obj/doors/door_assembly2x1.dmi'
+	icon_state = null //only have icons for the glass version
 	dir = EAST
 	var/width = 1

@@ -194,7 +194,7 @@
 /obj/structure/sign/directions
 	name = "direction sign"
 	desc = "A direction sign, claiming to know the way."
-	icon_state = "direction"
+	icon_state = null

 /obj/structure/sign/directions/science
 	name = "\improper Science department"
@@ -448,8 +448,8 @@
 /obj/structure/window/phoronreinforced/skrell
 	name = "advanced borosilicate-alloy window"
 	desc = "A window made out of a higly advanced borosilicate alloy. It seems to be extremely strong."
-	basestate = "skrell_phoronwindow"
-	icon_state = "skrell_phoronwindow"
+	basestate = "phoronwindow"
+	icon_state = "phoronwindow"
 	maxhealth = 250

 /obj/structure/window/reinforced