From 22f69e5e308518312d6f4e038529ecd118a7b698 Mon Sep 17 00:00:00 2001 From: Matt Atlas Date: Sat, 18 Apr 2020 18:39:50 +0200 Subject: [PATCH] Fixes gunfire text errors (#8686) --- code/modules/projectiles/gun.dm | 12 ++++---- html/changelogs/mattatlas-youfir.yml | 41 ++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 6 deletions(-) create mode 100644 html/changelogs/mattatlas-youfir.yml diff --git a/code/modules/projectiles/gun.dm b/code/modules/projectiles/gun.dm index 41eb3b43f19..92cb59ac5ff 100644 --- a/code/modules/projectiles/gun.dm +++ b/code/modules/projectiles/gun.dm @@ -394,16 +394,16 @@ if (playemote) if(reflex) user.visible_message( - span("reflex_shoot","\The [user] fires \the [src][pointblank ? " point blank at \the [target]":""] by reflex!"), - span("reflex_shoot", "You fire \the [src] by reflex!"), + SPAN_DANGER("\The [user] fires \the [src][pointblank ? " point blank at \the [target]" : ""] by reflex!"), + SPAN_DANGER("You fire \the [src][pointblank ? " point blank at \the [target]" : ""] by reflex!"), "You hear a [fire_sound_text]!" - ) + ) else user.visible_message( - span("danger","\The [user] fires \the [src][pointblank ? " point blank at \the [target]":""]!"), - span("warning","You fire \the [src]!"), + SPAN_DANGER("\The [user] fires \the [src][pointblank ? " point blank at \the [target]" : ""]!"), + SPAN_DANGER("You fire \the [src][pointblank ? " point blank at \the [target]" : ""]!"), "You hear a [fire_sound_text]!" - ) + ) if(muzzle_flash) set_light(muzzle_flash) diff --git a/html/changelogs/mattatlas-youfir.yml b/html/changelogs/mattatlas-youfir.yml new file mode 100644 index 00000000000..74e1fa0fd3b --- /dev/null +++ b/html/changelogs/mattatlas-youfir.yml @@ -0,0 +1,41 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# wip (For works in progress) +# tweak +# soundadd +# sounddel +# rscadd (general adding of nice things) +# rscdel (general deleting of nice things) +# imageadd +# imagedel +# maptweak +# spellcheck (typo fixes) +# experiment +# balance +# admin +# backend +# security +# refactor +################################# + +# Your name. +author: MattAtlas + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries. +# Please surround your changes in double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog. +changes: + - spellcheck: "Fixed gun fire message wonkiness."