Spark Fixes (#1764)

changes:

Removed shim for old spark system.
Converted all calls to old spark system with calls to new one.
Processor-based effects are no longer pooled, as it had minimal performance impact and was breaking things.
Tweaked some visible_messages for rogue drones.
PB effects' handling of location is now done at the /datum/effect_system level.
This commit is contained in:
Lohikar
2017-02-14 06:37:16 -06:00
committed by skull132
parent 59cedff4b9
commit 2b9aa21421
88 changed files with 247 additions and 458 deletions

View File

@@ -5,7 +5,7 @@
var/datum/controller/process/effects/effect_master
/var/list/datum/effect_system/effects_objects = list() // The effect-spawning objects. Shouldn't be many of these.
/var/list/obj/visual_effect/effects_visuals = list() // The visible component of an effect. Should be created by effect objects.
/var/list/obj/visual_effect/effects_visuals = list() // The visible component of an effect. May be created without an effect object.
/datum/controller/process/effects
var/tmp/list/processing_effects = list()
@@ -37,7 +37,7 @@ var/datum/controller/process/effects/effect_master
effects_objects += E
if (EFFECT_DESTROY)
returnToPool(E)
qdel(E)
F_SCHECK
@@ -61,7 +61,7 @@ var/datum/controller/process/effects/effect_master
if (EFFECT_DESTROY)
effects_visuals -= V
V.end()
returnToPool(V)
qdel(V)
F_SCHECK
@@ -78,6 +78,13 @@ var/datum/controller/process/effects/effect_master
effects_objects += E
enable()
/datum/controller/process/effects/proc/queue_simple(var/obj/visual_effect/V)
if (!V || V.gcDestroyed)
return
effects_visuals += V
enable()
/datum/controller/process/effects/statProcess()
..()
stat(null, "Effect process is [disabled ? "sleeping" : "processing"].")