Clean up runtime errors, fix VueUIs opening offscreen (#14025)

* Clean up runtime errors, fix VueUIs opening offscreen

* woops

* myazaki is based
This commit is contained in:
Wildkins
2022-05-20 18:36:14 +02:00
committed by GitHub
parent da0000f7f2
commit 2bb8db37b9
14 changed files with 51 additions and 22 deletions
+7 -3
View File
@@ -352,7 +352,7 @@ var/datum/controller/subsystem/ticker/SSticker
if(!istype(prefs) || force_name)
// trawl the whole list - we only do this on logout or job swap, aka when we can't guarantee the job datum being accurate
for(var/dept in ready_player_jobs)
if(LAZYISIN(ready_player_jobs[dept], ident))
if(!. && LAZYISIN(ready_player_jobs[dept], ident))
. = TRUE
ready_player_jobs[dept] -= ident
if(.)
@@ -361,10 +361,14 @@ var/datum/controller/subsystem/ticker/SSticker
var/datum/job/ready_job = prefs.return_chosen_high_job()
if(!istype(ready_job))
// literally how
return FALSE
for(var/dept in ready_job.departments)
if(ready_player_jobs[dept][prefs.real_name])
if(!. && ready_player_jobs[dept][prefs.real_name])
. = TRUE
LAZYREMOVE(ready_player_jobs[dept], prefs.real_name)
ready_player_jobs[dept] -= prefs.real_name
if(.)
update_ready_count()