From 2e9e4a0c57baf3b1a414faa7498c3cc80e0d3ede Mon Sep 17 00:00:00 2001 From: Fluffy <65877598+FluffyGhoster@users.noreply.github.com> Date: Thu, 25 Jul 2024 15:11:53 +0200 Subject: [PATCH] Fixed a runtime where a nullcheck was not present (#19666) Fixed a runtime where a nullcheck was not present, possibly slightly sped up the proc too --- .../mob/living/carbon/human/update_icons.dm | 3 +- html/changelogs/fluffyghost-fixruntime.yml | 58 +++++++++++++++++++ 2 files changed, 59 insertions(+), 2 deletions(-) create mode 100644 html/changelogs/fluffyghost-fixruntime.yml diff --git a/code/modules/mob/living/carbon/human/update_icons.dm b/code/modules/mob/living/carbon/human/update_icons.dm index 4dde03f0fff..721f48cfb76 100644 --- a/code/modules/mob/living/carbon/human/update_icons.dm +++ b/code/modules/mob/living/carbon/human/update_icons.dm @@ -397,8 +397,7 @@ There are several things that need to be remembered: SSicon_cache.human_icon_cache[icon_key] = base_icon - for(var/thing in organs) - var/obj/item/organ/external/part = thing + for(var/obj/item/organ/external/part in organs) part.cut_additional_images(src) var/list/add_images = part.get_additional_images(src) if(add_images) diff --git a/html/changelogs/fluffyghost-fixruntime.yml b/html/changelogs/fluffyghost-fixruntime.yml new file mode 100644 index 00000000000..8010978a5ca --- /dev/null +++ b/html/changelogs/fluffyghost-fixruntime.yml @@ -0,0 +1,58 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: FluffyGhost + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Fixed a runtime where a nullcheck was not present, possibly slightly sped up the proc too."