From 3c102ea5853d15b2cd9845f689fa84dba83efac6 Mon Sep 17 00:00:00 2001
From: Matt Atlas <mattiathebest2000@hotmail.it>
Date: Sat, 6 Jan 2024 15:59:23 +0100
Subject: [PATCH] Fixes the server runtiming out the ass when picking flora
 types. (#18155)

Co-authored-by: Matt Atlas <liermattia@gmail.com>
---
 .../overmap/exoplanets/exoplanet_flora.dm     |  6 +--
 html/changelogs/mattatlas-notalazylist.yml    | 41 +++++++++++++++++++
 2 files changed, 44 insertions(+), 3 deletions(-)
 create mode 100644 html/changelogs/mattatlas-notalazylist.yml

diff --git a/code/modules/overmap/exoplanets/exoplanet_flora.dm b/code/modules/overmap/exoplanets/exoplanet_flora.dm
index e15e6311bb2..e9442faf968 100644
--- a/code/modules/overmap/exoplanets/exoplanet_flora.dm
+++ b/code/modules/overmap/exoplanets/exoplanet_flora.dm
@@ -39,15 +39,15 @@
 	name = "spawn exoplanet plant"
 
 /obj/effect/landmark/exoplanet_spawn/plant/do_spawn(var/obj/effect/overmap/visitable/sector/exoplanet/planet)
-	if(LAZYLEN(planet.small_flora_types))
-		var/seed_path = pick(planet.big_flora_types)
+	if(length(planet.small_flora_types))
+		var/seed_path = pick(planet.small_flora_types)
 		new /obj/machinery/portable_atmospherics/hydroponics/soil/invisible(get_turf(src), new seed_path(), TRUE)
 
 /obj/effect/landmark/exoplanet_spawn/large_plant
 	name = "spawn exoplanet large plant"
 
 /obj/effect/landmark/exoplanet_spawn/large_plant/do_spawn(var/obj/effect/overmap/visitable/sector/exoplanet/planet)
-	if(LAZYLEN(planet.big_flora_types))
+	if(length(planet.big_flora_types))
 		var/seed_path = pick(planet.big_flora_types)
 		new /obj/machinery/portable_atmospherics/hydroponics/soil/invisible(get_turf(src), new seed_path(), TRUE)
 
diff --git a/html/changelogs/mattatlas-notalazylist.yml b/html/changelogs/mattatlas-notalazylist.yml
new file mode 100644
index 00000000000..4b55b91daa0
--- /dev/null
+++ b/html/changelogs/mattatlas-notalazylist.yml
@@ -0,0 +1,41 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes:
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   maptweak
+#   spellcheck (typo fixes)
+#   experiment
+#   balance
+#   admin
+#   backend
+#   security
+#   refactor
+#################################
+
+# Your name.
+author: MattAtlas
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
+# Please surround your changes in  double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
+changes:
+  - bugfix: "Fixes a runtime with exoplanet init."