Minor span refactoring (#19177)

Minor span refactoring

code/modules/client/preference_setup/antagonism/01_candidacy.dm

@@ -49,9 +49,9 @@
 		dat += "<tr><td>[antag.role_text]: </td><td>"
 		var/ban_reason = jobban_isbanned(preference_mob(), antag.bantype)
 		if(ban_reason == "AGE WHITELISTED")
-			dat += "<span class='danger'>\[IN [player_old_enough_for_role(preference_mob(), antag.bantype)] DAYS\]</span><br>"
+			dat += SPAN_DANGER("\[IN [player_old_enough_for_role(preference_mob(), antag.bantype)] DAYS\]<br>")
 		else if(is_global_banned || ban_reason)
-			dat += "<span class='danger'>\[<a href='?src=\ref[user.client];view_jobban=[is_global_banned ? "Antagonist" : "[antag.bantype]"];'>BANNED</a>\]</span><br>"
+			dat += SPAN_DANGER("\[<a href='?src=\ref[user.client];view_jobban=[is_global_banned ? "Antagonist" : "[antag.bantype]"];'>BANNED</a>\]<br>")
 		else if(establish_db_connection(GLOB.dbcon) && antag.required_age && antag.required_age > user.client?.player_age)
 			dat += "<span class='notice'>ACC TOO YOUNG</span><br>"
 		else if(antag.role_type in pref.be_special_role)

code/modules/client/preference_setup/general/02_language.dm

@@ -57,7 +57,7 @@
 
 	if (pref.alternate_languages.len > S.num_alternate_languages)
 		if(pref.client)
-			to_chat(pref.client, "<span class='warning'>You have too many languages saved for [pref.species].<br><b>The list has been reset. Please check your languages in character creation!</b></span>")
+			to_chat(pref.client, SPAN_WARNING("You have too many languages saved for [pref.species].<br><b>The list has been reset. Please check your languages in character creation!</b>"))
 		pref.alternate_languages.Cut()
 		return
 
@@ -70,11 +70,11 @@
 	var/list/bad_langs = pref.alternate_languages - langs
 	if (bad_langs.len)
 		if(pref.client)
-			to_chat(pref.client, "<span class='warning'>[bad_langs.len] invalid language\s were found in your character setup! Please save your character again to stop this error from repeating!</span>")
+			to_chat(pref.client, SPAN_WARNING("[bad_langs.len] invalid language\s were found in your character setup! Please save your character again to stop this error from repeating!"))
 
 		for (var/L in bad_langs)
 			if(pref.client)
-				to_chat(pref.client, "<span class='notice'>Removing the language \"[L]\" from your character.</span>")
+				to_chat(pref.client, SPAN_NOTICE("Removing the language \"[L]\" from your character."))
 			pref.alternate_languages -= L
 
 		var/datum/category_group/player_setup_category/cat = category

code/modules/client/preference_setup/general/03_body.dm

@@ -765,7 +765,7 @@ var/global/list/valid_bloodtypes = list("A+", "A-", "B+", "B-", "AB+", "AB-", "O
 				limb = BP_HEAD
 				carries_organs = 1
 			else
-				to_chat(user, "<span class='notice'>Cancelled.</span>")
+				to_chat(user, SPAN_NOTICE("Cancelled."))
 				return TOPIC_NOACTION
 
 		var/list/available_states = mob_species.possible_external_organs_modifications
@@ -965,9 +965,9 @@ var/global/list/valid_bloodtypes = list("A+", "A-", "B+", "B-", "AB+", "AB-", "O
 
 	if(restricted)
 		if(restricted == 1)
-			dat += "<span class='warning'><b>You cannot play as this species.</br><small>If you wish to be whitelisted, you can make an application post on <a href='?src=\ref[user];preference=open_whitelist_forum'>the forums</a>.</small></b></span></br>"
+			dat += SPAN_WARNING("<b>You cannot play as this species.</br><small>If you wish to be whitelisted, you can make an application post on <a href='?src=\ref[user];preference=open_whitelist_forum'>the forums</a>.</small></b></br>")
 		else if(restricted == 2)
-			dat += "<span class='warning'><b>You cannot play as this species.</br><small>This species is not available for play as a station race.</small></b></span></br>"
+			dat += SPAN_WARNING("<b>You cannot play as this species.</br><small>This species is not available for play as a station race.</small></b></br>")
 	if(!restricted || check_rights(R_ADMIN, 0))
 		dat += "\[<a href='?src=\ref[src];set_species=[html_encode(pref.species_preview)]'>select</a>\]"
 	dat += "</center>"

code/modules/client/preference_setup/general/05_background.dm

@@ -53,7 +53,7 @@
 	var/list/dat = list("<br/><b>Records</b>:<br/>")
 
 	if(jobban_isbanned(user, "Records"))
-		dat += "<span class='danger'>You are banned from using character records.</span><br>"
+		dat += SPAN_DANGER("You are banned from using character records.<br>")
 	else
 		dat += "Medical Records:<br>"
 		dat += "<a href='?src=\ref[src];set_medical_records=1'>[TextPreview(pref.med_record,40)]</a><a href='?src=\ref[src];clear=medical'>Clear</a><br><br>"

code/modules/client/preference_setup/loadout/loadout.dm

@@ -159,16 +159,16 @@ var/list/gear_datums = list()
 	var/list/player_valid_gear_choices = valid_gear_choices()
 	for(var/gear_name in pref.gear)
 		if(!gear_datums[gear_name])
-			to_chat(preference_mob, "<span class='warning'>You cannot have more than one of the \the [gear_name]</span>")
+			to_chat(preference_mob, SPAN_WARNING("You cannot have more than one of the \the [gear_name]"))
 			pref.gear -= gear_name
 		else if(!(gear_name in player_valid_gear_choices))
-			to_chat(preference_mob, "<span class='warning'>You cannot take \the [gear_name] as you are not whitelisted for the species.</span>")
+			to_chat(preference_mob, SPAN_WARNING("You cannot take \the [gear_name] as you are not whitelisted for the species."))
 			pref.gear -= gear_name
 		else
 			var/datum/gear/G = gear_datums[gear_name]
 			if(total_cost + G.cost > GLOB.config.loadout_cost)
 				pref.gear -= gear_name
-				to_chat(preference_mob, "<span class='warning'>You cannot afford to take \the [gear_name]</span>")
+				to_chat(preference_mob, SPAN_WARNING("You cannot afford to take \the [gear_name]"))
 			else
 				total_cost += G.cost
 

code/modules/client/preference_setup/occupation/occupation.dm

@@ -501,14 +501,14 @@
 	var/datum/faction/faction = SSjobs.name_factions[selected_faction]
 
 	if (!faction)
-		to_client_chat("<span class='danger'>Invalid faction chosen. Resetting to default.</span>")
+		to_client_chat(SPAN_DANGER("Invalid faction chosen. Resetting to default."))
 		selected_faction = SSjobs.default_faction.name
 
 	ResetJobs() // How to be horribly lazy.
 
 	pref.faction = selected_faction
 
-	to_client_chat("<span class='notice'>New faction chosen. Job preferences reset.</span>")
+	to_client_chat(SPAN_NOTICE("New faction chosen. Job preferences reset."))
 
 /datum/preferences/proc/GetPlayerAltTitle(datum/job/job)
 	return player_alt_titles[job.title] || job.title