From 419b3e7e3216ba360acaf52b5ae4a264c6ada51a Mon Sep 17 00:00:00 2001 From: ike709 Date: Thu, 20 Nov 2025 09:36:03 -0600 Subject: [PATCH] Fixes pointless `for()` loops (#21613) OpenDream's `EmptyBlock` pragma had a bug that prevented it from firing in certain cases of empty `for()` loops. That has been resolved and it's uncovered a few issues with your code. Please merge this ASAP as it has no impact on current behavior (besides saving CPU cycles) and the bad code is currently blocking OpenDream CI for the linked PR. --- code/game/objects/items/devices/uplink.dm | 2 -- code/modules/events/electrical_storm.dm | 1 - code/unit_tests/species_tests.dm | 1 - 3 files changed, 4 deletions(-) diff --git a/code/game/objects/items/devices/uplink.dm b/code/game/objects/items/devices/uplink.dm index 57388eced93..c1363bf1c17 100644 --- a/code/game/objects/items/devices/uplink.dm +++ b/code/game/objects/items/devices/uplink.dm @@ -263,8 +263,6 @@ Then check if it's true, if true return. This will stop the normal menu appearin for (var/i = 1, i <= pages, i++) contracts_pages.Add(i) - for (var/a in contracts_pages) - tgui_data["contracts_pages"] = contracts_pages if (tgui_data["contracts_current_page"] > pages) diff --git a/code/modules/events/electrical_storm.dm b/code/modules/events/electrical_storm.dm index e1fa9a02b41..9cc0d25d795 100644 --- a/code/modules/events/electrical_storm.dm +++ b/code/modules/events/electrical_storm.dm @@ -60,7 +60,6 @@ var/list/picked_apcs = list() // Up to 2/4/6 APCs per tick depending on severity - for(var/i = 0, i < ((severity + 1)), i++) for(var/i = 0, i < (severity * 2), i++) picked_apcs |= pick(valid_apcs) diff --git a/code/unit_tests/species_tests.dm b/code/unit_tests/species_tests.dm index 2719680d29b..89000ada5fd 100644 --- a/code/unit_tests/species_tests.dm +++ b/code/unit_tests/species_tests.dm @@ -18,7 +18,6 @@ failed_species |= species.type if(failed_species.len) - for(var/fail in failed_species) TEST_FAIL("SPECIES: Invalid injection_mod var set on species: [english_list(failed_species)]") else TEST_PASS("SPECIES: All species had valid injection_mod vars set.")