cyberpresidentvanellope/Aurora.3
1
0
Fork 0
mirror of https://github.com/Aurorastation/Aurora.3.git synced 2026-07-21 21:10:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix DPI scaling with TGUI, TGUI Say, and Tooltips (#20734)

Browse Source 
Got tired of the issues here when working on something else.

Ported several PRs from /tg/station to fix DPI scaling issues. This was
not a problem before 516, however 516 now respects Window's DPI setting,
causing misalignment in several of our UI elements.

This PR implements these ~~four~~ ~~five~~ six PRs:
https://github.com/tgstation/tgstation/pull/65686
https://github.com/tgstation/tgstation/pull/89994
https://github.com/tgstation/tgstation/pull/90416
https://github.com/tgstation/tgstation/pull/90418
https://github.com/tgstation/tgstation/pull/90796
https://github.com/cmss13-devs/cmss13/pull/8734

~~Does not include fixes with TGUI-Say. /tg/station refactored TGUI-Say
after their port to React before they fixed DPI scaling, and this would
be pain to deconstruct to port over to Inferno. Since porting to React
is "inevitable", I considered it not worth my time to fix this.~~

Thanks to the assistance of harry, TGUI-Say fixes now included.
This commit is contained in:
Cody Brittain
2025-05-14 08:39:41 -04:00
committed by GitHub
parent 5b54dd2557
commit 45139cea5c
43 changed files with 1248 additions and 498 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/client/preference_setup/global/01_ui.dm
+22 -2
View File
@@ -14,6 +14,8 @@
S["tgui_inputs"] >> pref.tgui_inputs
S["tgui_buttons_large"] >> pref.tgui_buttons_large
S["tgui_inputs_swapped"] >> pref.tgui_inputs_swapped
S["tgui_say_light_mode"] >> pref.tgui_say_light_mode
S["ui_scale"] >> pref.ui_scale
/datum/category_item/player_setup_item/player_global/ui/save_preferences(var/savefile/S)
S["UI_style"] << pref.UI_style
@@ -27,6 +29,8 @@
S["tgui_inputs"] << pref.tgui_inputs
S["tgui_buttons_large"] << pref.tgui_buttons_large
S["tgui_inputs_swapped"] << pref.tgui_inputs_swapped
S["tgui_say_light_mode"] << pref.tgui_say_light_mode
S["ui_scale"] << pref.ui_scale
/datum/category_item/player_setup_item/player_global/ui/gather_load_query()
return list(
@@ -42,7 +46,9 @@
"tooltip_style",
"tgui_inputs",
"tgui_buttons_large",
"tgui_inputs_swapped"
"tgui_inputs_swapped",
"tgui_say_light_mode",
"ui_scale",
),
"args" = list("ckey")
)
@@ -65,6 +71,7 @@
"tgui_inputs",
"tgui_buttons_large",
"tgui_inputs_swapped",
"ui_scale",
"ckey" = 1
)
)
@@ -82,7 +89,8 @@
"tooltip_style" = pref.tooltip_style,
"tgui_inputs" = pref.tgui_inputs,
"tgui_buttons_large" = pref.tgui_buttons_large,
"tgui_inputs_swapped" = pref.tgui_inputs_swapped
"tgui_inputs_swapped" = pref.tgui_inputs_swapped,
"ui_scale" = pref.ui_scale
)
/datum/category_item/player_setup_item/player_global/ui/sanitize_preferences()
@@ -110,6 +118,8 @@
dat += "<b>TGUI Inputs:</b> <a href='byond://?src=[REF(src)];tgui_inputs=1'><b>[pref.tgui_inputs ? "ON" : "OFF"]</b></a><br>"
dat += "<b>TGUI Input Large Buttons:</b> <a href='byond://?src=[REF(src)];tgui_inputs_large=1'><b>[pref.tgui_buttons_large ? "ON" : "OFF"]</b></a><br>"
dat += "<b>TGUI Input Swapped Buttons:</b> <a href='byond://?src=[REF(src)];tgui_inputs_swapped=1'><b>[pref.tgui_inputs_swapped ? "ON" : "OFF"]</b></a><br>"
dat += "<b>TGUI Say Light Mode:</b> <a href='byond://?src=[REF(src)];tgui_say_light_mode=1'><b>[pref.tgui_say_light_mode ? "ON" : "OFF"]</b></a><br>"
dat += "<b>UI Scaling:</b> <a href='byond://?src=[REF(src)];ui_scale=1'><b>[pref.ui_scale ? "ON" : "OFF"]</b></a><br>"
dat += "<b>FPS:</b> <a href='byond://?src=[REF(src)];select_fps=1'><b>[pref.clientfps]</b></a> - <a href='byond://?src=[REF(src)];reset=fps'>reset</a><br>"
if(can_select_ooc_color(user))
dat += "<b>OOC Color:</b> "
@@ -159,6 +169,16 @@
pref.tgui_inputs_swapped = !pref.tgui_inputs_swapped
return TOPIC_REFRESH
else if(href_list["tgui_say_light_mode"])
pref.tgui_say_light_mode = !pref.tgui_say_light_mode
user.client.tgui_say?.load()
return TOPIC_REFRESH
else if(href_list["ui_scale"])
pref.ui_scale = !pref.ui_scale
user.client.tgui_say?.load()
return TOPIC_REFRESH
else if(href_list["select_ooc_color"])
var/new_ooccolor = input(user, "Choose OOC color:", "Global Preference") as color|null
if(new_ooccolor && can_select_ooc_color(user) && CanUseTopic(user))