From 478413400af32f234fbcb35ae8f6e85e4bc72f3d Mon Sep 17 00:00:00 2001
From: mikomyazaki <47489928+mikomyazaki@users.noreply.github.com>
Date: Sun, 1 Mar 2020 12:30:17 +0000
Subject: [PATCH] Removes icon unit test. (#8370)

"Random" unit test failures appear to be a long-existing BYOND issue (~4 years at least). If I figure out how to solve this I'll resubmit... (unlikely)

We can keep in the various icon fixes from the PR that added this test.
---
 aurorastation.dme                    |  1 -
 code/unit_tests/icon_tests.dm        | 38 ----------------------------
 html/changelogs/revert_icon_test.yml |  6 +++++
 3 files changed, 6 insertions(+), 39 deletions(-)
 delete mode 100644 code/unit_tests/icon_tests.dm
 create mode 100644 html/changelogs/revert_icon_test.yml

diff --git a/aurorastation.dme b/aurorastation.dme
index 9c87d2ac305..b37356816da 100644
--- a/aurorastation.dme
+++ b/aurorastation.dme
@@ -2650,7 +2650,6 @@
 #include "code\unit_tests\chemistry_tests.dm"
 #include "code\unit_tests\equipment_tests.dm"
 #include "code\unit_tests\foundation_tests.dm"
-#include "code\unit_tests\icon_tests.dm"
 #include "code\unit_tests\map_tests.dm"
 #include "code\unit_tests\mob_tests.dm"
 #include "code\unit_tests\object_tests.dm"
diff --git a/code/unit_tests/icon_tests.dm b/code/unit_tests/icon_tests.dm
deleted file mode 100644
index a549db516c1..00000000000
--- a/code/unit_tests/icon_tests.dm
+++ /dev/null
@@ -1,38 +0,0 @@
-/datum/unit_test/icon_test
-	name = "ICON STATE template"
-
-/datum/unit_test/icon_test/all_initial_icon_states_shall_exist
-	name = "ICON STATE - All initial icon states shall exist"
-	var/list/excepted_atoms = list() // Any specific atoms that should not be included
-	var/list/excepted_icon_files = list() //Contains any .dmi files you do not want this test to run on
-	var/list/excepted_icon_states = list() //Any individual icon states you do not want this test to run on
-
-/datum/unit_test/icon_test/all_initial_icon_states_shall_exist/start_test()
-	var/list/failed_icons = list()
-
-	for(var/atom_type in (subtypesof(/atom) - excepted_atoms))
-		var/failed = FALSE
-		var/atom/test_atom = atom_type
-
-		var/atom_icon = initial(test_atom.icon)
-		if(atom_icon in excepted_icon_files)
-			continue
-		if(atom_icon)
-			var/atom_icon_state = initial(test_atom.icon_state)
-			if(!atom_icon_state || (atom_icon_state in excepted_icon_states))
-				continue
-
-			var/list/valid_states = icon_states(atom_icon)
-			if(!(atom_icon_state in valid_states))
-				failed = TRUE
-				log_unit_test("[ascii_red]--------------- [atom_type] - Icon state [atom_icon_state] was not found in [atom_icon].")
-
-		if(failed)
-			failed_icons += atom_type
-
-	if(LAZYLEN(failed_icons))
-		fail("[LAZYLEN(failed_icons)] atom initial icons were not found.")
-	else
-		pass("All atom initial icons were valid.")
-
-	return TRUE
diff --git a/html/changelogs/revert_icon_test.yml b/html/changelogs/revert_icon_test.yml
new file mode 100644
index 00000000000..9c8f99dd1b6
--- /dev/null
+++ b/html/changelogs/revert_icon_test.yml
@@ -0,0 +1,6 @@
+author: mikomyazaki
+
+delete-after: True
+
+changes:
+  - backend: "Removes recently added icon state unit test due to BYOND issues."