Horizon mapping cleanup and bugfixes (#21450)

Fixes https://github.com/Aurorastation/Aurora.3/issues/21289
Fixes https://github.com/Aurorastation/Aurora.3/issues/15779

Handles a lot of mapping cleanup, container definitions for the Horizon,
and several bugfixes found along the way.

changes:
- code_imp: "Added set definitions for several Horizon-specific
containers."
- code_imp: "Updated 'full' material stacks on the Horizon from sneaky
var-edited singles to properly defined full stacks"
- code_imp: "Cleaned up all Air Alarms, Fire Alarms, and APCs on the
Horizon that were directional children with their dir var edited."
- code_imp: "Cleaned up all Power Cables on the Horizon that had d1 or
d2 var edited instead of just icon_state."
- code_imp: "Adjusted pixel shifts for 'south' (north-facing) Air
Alarms, Fire Alarms, APCs, and Extinguisher Cabinets to address layering
issues when standing vs. leaning."
- code_imp: "Minor refactor of shuttle/* Air Alarms and APCs to reduce
excess children; req_one_access perms now assigned based on
/area/horizon/shuttle/*."
  - qol: "Adds feedback hint for uses remaining to Emag cards."
- qol: "Added Tip about the shift-click behavior of the 'up-hint'/'Look
Up' button."
- bugfix: "See-through turfs (like lattices/catwalks over open space)
can now be Looked Up through from below."
- bugfix: "Fixed the shift-click behavior of 'up-hint'/'Look Up' button,
allowing you to see nearby turfs that can be Looked Up through."
- bugfix: "Maintenance Panels located on the floor have had their
layering issues fixed."
- bugfix: "Borg eye emissive effects MAYBE no longer visible through
higher z-levels."
- bugfix: "Added missing leanable component to window/shuttle obj type."
This commit is contained in:
Batrachophreno
2025-10-07 22:12:03 +00:00
committed by GitHub
parent dfe57a310f
commit 4d41b0595f
19 changed files with 5002 additions and 5541 deletions
+40
View File
@@ -444,5 +444,45 @@
return test_status
// At present, only fire alarms have NSEW as immediate children, whereas APCs and Air Alarms also have them as sub-children.
// In the future, areas should have additional vars to populate APC data automatically, allowing them to have directional
// immediate children too for mapping testing.
/datum/unit_test/map_test/no_panel_dir_var_edits
name = "MAP: Check for Fire Alarm dir var edits"
/datum/unit_test/map_test/no_panel_dir_var_edits/start_test()
var/test_status = UNIT_TEST_PASSED
var/checks = 0
var/failed_checks = 0
var/firealarm_increment
var/turf/T
for(var/obj/machinery/firealarm/F in world)
T = get_turf(F)
firealarm_increment = 0
if(istype(F, /obj/machinery/firealarm/north))
if(F.dir != NORTH)
firealarm_increment++
if(istype(F, /obj/machinery/firealarm/south))
if(F.dir != SOUTH)
firealarm_increment++
if(istype(F, /obj/machinery/firealarm/east))
if(F.dir != EAST)
firealarm_increment++
if(istype(F, /obj/machinery/firealarm/west))
if(F.dir != WEST)
firealarm_increment++
checks++
if(firealarm_increment > 1)
failed_checks++
TEST_FAIL("Manually var edited [F] at ([F.x],[F.y],[F.z]) in [T.loc].")
if(failed_checks)
TEST_FAIL("\[[failed_checks] / [checks]\] Some fire alarms had their dir var manually edited instead of using a preset variant. Please also check new APCs and air alarms in the area.")
else
TEST_PASS("All \[[checks]\] fire alarms mapped properly.")
return test_status
#undef SUCCESS
#undef FAILURE