From 4e4c4c4905fef3ee27366f7bc2be657cd29424b9 Mon Sep 17 00:00:00 2001 From: FabianK3 <21039694+FabianK3@users.noreply.github.com> Date: Mon, 13 Apr 2026 14:30:43 +0200 Subject: [PATCH] Fix admin spawn verb (#22178) # Summary This PR adds a argument check to the spawn verb to prevent server lag caused by searching all atoms. ## Changes - Added length check to admin Spawn verb. --- code/modules/admin/admin.dm | 4 ++++ html/changelogs/fabiank3-admin-spawn-verb-length-check.yml | 6 ++++++ 2 files changed, 10 insertions(+) create mode 100644 html/changelogs/fabiank3-admin-spawn-verb-length-check.yml diff --git a/code/modules/admin/admin.dm b/code/modules/admin/admin.dm index 15cf50b8ec5..2e6f44b2dc2 100644 --- a/code/modules/admin/admin.dm +++ b/code/modules/admin/admin.dm @@ -1024,6 +1024,10 @@ var/global/enabled_spooking = 0 if(!check_rights(R_SPAWN)) return + if(!length(object)) // Prevent server lag caused by searching all atoms + to_chat(src, SPAN_WARNING("Spawn verb requires an argument, partial or full type path, e.g.: Spawn \"/obj/item/toy")) + return + var/list/matches = typesof(/atom) for(var/path in matches) diff --git a/html/changelogs/fabiank3-admin-spawn-verb-length-check.yml b/html/changelogs/fabiank3-admin-spawn-verb-length-check.yml new file mode 100644 index 00000000000..d512a9ea481 --- /dev/null +++ b/html/changelogs/fabiank3-admin-spawn-verb-length-check.yml @@ -0,0 +1,6 @@ +author: FabianK3 + +delete-after: True + +changes: + - code_imp: "Fixed server lag when using the admin spawn verb with an empty argument."