mirror of
https://github.com/Aurorastation/Aurora.3.git
synced 2026-08-23 13:05:44 +01:00
Ruins sanitization and unit test (#18923)
Properly split and use prefixes and suffixes, unit test to verify the file exists and is not empty, and that the format convention is respected
This commit is contained in:
+29
-4
@@ -40,11 +40,30 @@
|
||||
*/
|
||||
var/list/sectors_blacklist = list()
|
||||
|
||||
/// Prefix part of the path to the dmm maps.
|
||||
/**
|
||||
* Static part of the ruin path, ie the folder
|
||||
* have to start without a slash, and end with a slash
|
||||
*
|
||||
* eg. `away_site/`
|
||||
*
|
||||
* Gets combined with the other prefixes in the inheritance tree
|
||||
* (under /New()) to form the relative path from the root of the codebase
|
||||
* to the folder this ruin is in
|
||||
*
|
||||
* If you implement a subtype of another subtype, it is *your* responsibility to
|
||||
* ensure that `/New()` chains the path correctly
|
||||
*/
|
||||
var/prefix = null
|
||||
|
||||
/// A list of suffix parts of paths of the dmm maps.
|
||||
/// Combined with prefix to get the actual path.
|
||||
/**
|
||||
* The dynamic part of the ruin path, ie the files
|
||||
*
|
||||
* A `/list` with only the file names of the DMM files
|
||||
*
|
||||
* eg. `my_awesome_ruin.dmm`
|
||||
*
|
||||
* Gets combined with the prefix to form the path to the map files, that are loaded when the ruin loads
|
||||
*/
|
||||
var/list/suffixes = null
|
||||
|
||||
/// Template flags for this ruin
|
||||
@@ -59,7 +78,13 @@
|
||||
///Listed ruins are removed from the set of available spawns
|
||||
var/list/ban_ruins
|
||||
|
||||
/datum/map_template/ruin/New()
|
||||
/**
|
||||
* Ensure to call the parent constructor *last*
|
||||
*
|
||||
* If you have subtypes and you change the `prefix`, it is *your* responsibility to
|
||||
* chain your changed `prefix` here, before calling the parent constructor
|
||||
*/
|
||||
/datum/map_template/ruin/New(var/list/paths = null, rename = null)
|
||||
// get the map paths
|
||||
if (suffixes)
|
||||
mappaths = list()
|
||||
|
||||
Reference in New Issue
Block a user