From 4e99f9f34f482fe36211b125782a27021ca634cd Mon Sep 17 00:00:00 2001 From: SidVeld Date: Mon, 1 Apr 2024 17:41:50 +0300 Subject: [PATCH] Fix null client field value in examine (#18808) * fix(examine): handle the client's null value * chore: add changelog * Update code/modules/mob/living/carbon/human/examine.dm Co-authored-by: Fluffy <65877598+FluffyGhoster@users.noreply.github.com> Signed-off-by: Werner <1331699+Arrow768@users.noreply.github.com> * fix: take out the extra tabs Co-authored-by: Fluffy <65877598+FluffyGhoster@users.noreply.github.com> Signed-off-by: SidVeld --------- Signed-off-by: Werner <1331699+Arrow768@users.noreply.github.com> Signed-off-by: SidVeld Co-authored-by: Werner <1331699+Arrow768@users.noreply.github.com> Co-authored-by: Fluffy <65877598+FluffyGhoster@users.noreply.github.com> --- code/modules/mob/living/carbon/human/examine.dm | 2 +- html/changelogs/example copy.yml | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/example copy.yml diff --git a/code/modules/mob/living/carbon/human/examine.dm b/code/modules/mob/living/carbon/human/examine.dm index f213288d2eb..3972b7b01be 100644 --- a/code/modules/mob/living/carbon/human/examine.dm +++ b/code/modules/mob/living/carbon/human/examine.dm @@ -390,7 +390,7 @@ if(print_flavor_text()) msg += "[print_flavor_text()]\n" - if (GLOB.config.allow_Metadata && client.prefs.metadata) + if(GLOB.config.allow_Metadata && client?.prefs.metadata) msg += "OOC Notes: \[View\]\n" msg += "" diff --git a/html/changelogs/example copy.yml b/html/changelogs/example copy.yml new file mode 100644 index 00000000000..47801ef89f7 --- /dev/null +++ b/html/changelogs/example copy.yml @@ -0,0 +1,6 @@ +author: SidVeld + +delete-after: True + +changes: + - bugfix: "Fixed an issue that caused the character examine message to disappear when the player controlling it is not in the body."