From 5a58b71ddca89033c33e3fe25ae2408f30eec5a2 Mon Sep 17 00:00:00 2001
From: FabianK3 <21039694+FabianK3@users.noreply.github.com>
Date: Thu, 13 Aug 2026 16:19:36 +0000
Subject: [PATCH] Revert vent ambience (#23034)

# Summary

This PR removes the ambience sounds introduced in
https://github.com/Aurorastation/Aurora.3/pull/22789. Due to performance
degradation by the sheer amount of active sounds, these are removed
again. The sounds added in the original PR stay for re-use.
---
 .../modules/atmospherics/components/unary/vent_pump.dm | 10 +---------
 .../atmospherics/components/unary/vent_scrubber.dm     |  8 --------
 html/changelogs/fabiank3-revert-vent-ambience.yml      |  6 ++++++
 3 files changed, 7 insertions(+), 17 deletions(-)
 create mode 100644 html/changelogs/fabiank3-revert-vent-ambience.yml

diff --git a/code/modules/atmospherics/components/unary/vent_pump.dm b/code/modules/atmospherics/components/unary/vent_pump.dm
index a58d0622b86..845eb2e1de6 100644
--- a/code/modules/atmospherics/components/unary/vent_pump.dm
+++ b/code/modules/atmospherics/components/unary/vent_pump.dm
@@ -50,8 +50,6 @@
 
 	var/broadcast_status_next_process = FALSE
 
-	var/datum/looping_sound/ventilation_humming/ventilation_humming
-
 /obj/structure/machinery/atmospherics/unary/vent_pump/mechanics_hints(mob/user, distance, is_adjacent)
 	. += ..()
 	. += "This pumps the contents of the attached pipe out into the atmosphere, if needed."
@@ -120,7 +118,6 @@
 		assign_uid()
 		id_tag = num2text(uid)
 	setup_radio()
-	ventilation_humming = new(src)
 
 /obj/structure/machinery/atmospherics/unary/vent_pump/proc/setup_radio()
 	//some vents work his own special way
@@ -222,12 +219,7 @@
 
 	if (!node)
 		update_use_power(POWER_USE_OFF)
-	if(can_pump())
-		if(ventilation_humming && !ventilation_humming.loop_started)
-			ventilation_humming.start()
-	else
-		if(ventilation_humming && ventilation_humming.loop_started)
-			ventilation_humming.stop()
+	if(!can_pump())
 		return 0
 
 	if(!loc) return FALSE
diff --git a/code/modules/atmospherics/components/unary/vent_scrubber.dm b/code/modules/atmospherics/components/unary/vent_scrubber.dm
index d0c58f7cbb4..30b7bf2668c 100644
--- a/code/modules/atmospherics/components/unary/vent_scrubber.dm
+++ b/code/modules/atmospherics/components/unary/vent_scrubber.dm
@@ -31,8 +31,6 @@
 
 	var/broadcast_status_next_process = FALSE
 
-	var/datum/looping_sound/ventilation_humming/ventilation_humming
-
 /obj/structure/machinery/atmospherics/unary/vent_scrubber/mechanics_hints(mob/user, distance, is_adjacent)
 	. += ..()
 	. += "This filters the atmosphere of harmful gas. Filtered gas goes to the pipes connected to it, typically a scrubber pipe."
@@ -62,7 +60,6 @@
 		LAZYADD(T.blueprints, I)
 
 	. = ..()
-	ventilation_humming = new(src)
 	air_contents.volume = ATMOS_DEFAULT_VOLUME_FILTER
 
 	initial_loc = get_area(loc)
@@ -198,12 +195,7 @@
 		broadcast_status_next_process = FALSE
 
 	if((!use_power || (stat & (NOPOWER|BROKEN)) || !loc) || welded)
-		if(ventilation_humming && ventilation_humming.loop_started)
-			ventilation_humming.stop()
 		return 0
-	else
-		if(ventilation_humming && !ventilation_humming.loop_started)
-			ventilation_humming.start()
 
 	var/datum/gas_mixture/environment = loc.return_air()
 
diff --git a/html/changelogs/fabiank3-revert-vent-ambience.yml b/html/changelogs/fabiank3-revert-vent-ambience.yml
new file mode 100644
index 00000000000..544b0d7d680
--- /dev/null
+++ b/html/changelogs/fabiank3-revert-vent-ambience.yml
@@ -0,0 +1,6 @@
+author: FabianK3
+
+delete-after: True
+
+changes:
+  - rscdel: "Removed the ambience sounds from vents and scrubbers. The amount of sounds degrade performance. The sound files added with it are still available."