OpenDream linting (#16468)

* I wanna set the universe on fire

* dfsaaf

* setup

* dir issue?

* dsf

* Perhaps the script

* saf

* cry

* pain

* sdfas

* Try reintroduction of tag-matcher

* Failed

* Tries to suppress dotnet compile warnings

* Like this maybe?

* woopsie

* Damn pathings

* Hate

* Pragmas

* unlint?

* Maybe?

* GDI

* Redundant ifdef removed and changelog

* Did I forgot the tag matcher, or it was still broken?

* Yea no that script is still broken

* Removed tag-matcher as requested

* *sigh*

* test

* bro what?

* hope

* just fixing the input

* Let's see if we catch it...

code/modules/mob/abstract/observer/observer.dm

@@ -12,7 +12,7 @@
 	invisibility = INVISIBILITY_OBSERVER
 	simulated = FALSE
 	var/can_reenter_corpse
-	var/datum/hud/living/carbon/hud = null // hud
+	var/datum/hud/hud = null // hud
 	var/bootime = 0
 	var/started_as_observer //This variable is set to 1 when you enter the game as an observer.
 							//If you died in the game and are a ghsot - this will remain as null.

code/modules/mob/living/carbon/human/say.dm

@@ -235,11 +235,12 @@
 		if("whisper")
 			whisper(message, speaking, is_singing)
 			return TRUE
-		else if(message_mode)
-			var/obj/item/device/radio/R = get_radio()
-			if(R)
-				used_radios += R
-				R.talk_into(src, message, message_mode, verb, speaking)
+		else
+			if(message_mode)
+				var/obj/item/device/radio/R = get_radio()
+				if(R)
+					used_radios += R
+					R.talk_into(src, message, message_mode, verb, speaking)
 
 /mob/living/carbon/human/handle_speech_sound()
 	var/list/returns = ..()

code/modules/mob/living/carbon/human/species/species_attack.dm

@@ -236,7 +236,7 @@
 	attack_verb = list("scorched", "burned")
 	attack_noun = list("flaming fist")
 	damage = 10
-	attack_sound = 'sound/items/welder.ogg'
+	attack_sound = 'sound/items/Welder.ogg'
 	attack_name = "flaming touch"
 	damage_type = DAMAGE_BURN
 
@@ -289,4 +289,4 @@
 	user.visible_message(SPAN_DANGER("\The [user] crackles with energy!"))
 	if(iscarbon(target))
 		var/mob/living/carbon/L = target
-		L.electrocute_act(20,user, 1, user.zone_sel.selecting)
+		L.electrocute_act(20,user, 1, user.zone_sel.selecting)

code/modules/mob/living/carbon/human/species/station/golem.dm

@@ -816,7 +816,7 @@ var/global/list/golem_types = list(SPECIES_GOLEM_COAL,
 	death_message = "collapses into a pile of flesh!"
 	death_message_range = 7
 
-	death_sound = 'sound/magic/disintegrate.ogg'
+	death_sound = 'sound/magic/Disintegrate.ogg'
 
 	golem_designation = "Flesh"
 

code/modules/mob/living/living.dm

@@ -589,8 +589,7 @@ default behaviour is:
 
 		if (!restrained())
 			var/diag = get_dir(src, pulling)
-			if ((diag - 1) & diag)
-			else
+			if (!((diag - 1) & diag))
 				diag = null
 			if ((get_dist(src, pulling) > 1 || diag))
 				if (isliving(pulling))

code/modules/mob/living/silicon/ai/malf.dm

@@ -5,14 +5,14 @@
 	var/mob/living/silicon/ai/user = src
 	// Setup Variables
 	malfunctioning = 1
-	research = new/datum/malf_research()
+	research = /datum/malf_research
 	research.owner = src
 	hacked_apcs = list()
 	recalc_cpu()
 
-	add_verb(src, new/datum/game_mode/malfunction/verb/ai_select_hardware())
-	add_verb(src, new/datum/game_mode/malfunction/verb/ai_select_research())
-	add_verb(src, new/datum/game_mode/malfunction/verb/ai_help())
+	add_verb(src, /datum/game_mode/malfunction/verb/ai_select_hardware)
+	add_verb(src, /datum/game_mode/malfunction/verb/ai_select_research)
+	add_verb(src, /datum/game_mode/malfunction/verb/ai_help)
 
 	// And greet user with some OOC info.
 	to_chat(user, "You are malfunctioning, you do not have to follow any laws.")

code/modules/mob/living/silicon/robot/drone/drone_items.dm

@@ -120,7 +120,7 @@
 			if(wood)
 				wood.add_charge(4000)
 		else if(istype(W, /obj/item/pipe))
-			// This allows drones and engiborgs to clear pipe assemblies from floors.
+			continue // This allows drones and engiborgs to clear pipe assemblies from floors.
 		else if(istype(W, /obj/item/broken_bottle))
 			if(glass)
 				glass.add_charge(2000)
@@ -194,4 +194,4 @@
 
 	dat += resources
 
-	src << browse(dat, "window=robotmod")
+	src << browse(dat, "window=robotmod")

code/modules/mob/living/silicon/robot/robot.dm

@@ -17,7 +17,7 @@
 	var/icon_selected = 0		//If icon selection has been completed yet
 	var/spawn_sound = 'sound/voice/liveagain.ogg'
 	var/pitch_toggle = TRUE
-	var/datum/effect/effect/system/ion_trail_follow/ion_trail
+	var/datum/effect_system/ion_trail/ion_trail
 	var/datum/effect_system/sparks/spark_system
 
 	// Wiring

code/modules/mob/mob_defines.dm

@@ -33,7 +33,6 @@
 	var/obj/screen/gun/item/item_use_icon = null
 	var/obj/screen/gun/radio/radio_use_icon = null
 	var/obj/screen/gun/move/gun_move_icon = null
-	var/obj/screen/gun/run/gun_run_icon = null
 	var/obj/screen/gun/mode/gun_setting_icon = null
 	var/obj/screen/gun/unique_action_icon = null
 	var/obj/screen/gun/toggle_firing_mode = null
@@ -207,7 +206,6 @@
 
 //Monkey/infected mode
 	var/list/resistances = list()
-	var/datum/disease/virus = null
 
 	mouse_drag_pointer = MOUSE_ACTIVE_POINTER
 

code/modules/mob/transform_procs.dm

@@ -232,7 +232,7 @@
 		new_slime = new /mob/living/carbon/slime(loc)
 		if(adult)
 			new_slime.is_adult = 1
-		else
+
 	new_slime.key = key
 
 	to_chat(new_slime, "<B>You are now a slime. Skreee!</B>")