Modular PDAs: The End of an Era (#10319)

PDAs are dead, long live PDAs. All trace of old PDAs has been scoured from the codebase, and in its place are modular computer PDAs that are feature-equivalent. Essentially every PDA function except the Syndicate detonation feature and Notepad has been ported over, and battery life for handheld computers has been boosted alongside the addition of charging cables to make things easier.

code/controllers/configuration.dm

@@ -15,7 +15,7 @@ var/list/gamemode_cache = list()
 	var/log_emote = 0					// log emotes
 	var/log_attack = 0					// log attack messages
 	var/log_adminchat = 0				// log admin chat messages
-	var/log_pda = 0						// log pda messages
+	var/log_pda = 0						// log NTIRC messages
 	var/log_hrefs = 0					// logs all links clicked in-game. Could be used for debugging and tracking down exploits
 	var/log_runtime = 0					// logs world.log to a file
 	var/log_world_output = 0			// log world.log <<  messages

code/controllers/subsystems/garbage-debug.dm

@@ -312,6 +312,7 @@
 	SearchVar(skin_styles_female_list)
 	SearchVar(body_marking_styles_list)
 	SearchVar(backbaglist)
+	SearchVar(pdalist)
 	SearchVar(exclude_jobs)
 	SearchVar(visual_nets)
 	SearchVar(cameranet)

code/controllers/subsystems/news.dm

@@ -160,17 +160,6 @@
 		NEWSCASTER.newsAlert(annoncement)
 		NEWSCASTER.update_icon()
 
-	var/list/receiving_pdas = new
-	for (var/obj/item/device/pda/P in PDAs)
-		if (!P.owner)
-			continue
-		if (P.toff)
-			continue
-		receiving_pdas += P
-
-	for(var/obj/item/device/pda/PDA in receiving_pdas)
-		PDA.new_news(annoncement)
-
 /datum/controller/subsystem/news/proc/GetForumAuthor(topic_id, post_id)
 	topic_id = "[topic_id]"
 	post_id = text2num(post_id)

code/controllers/subsystems/statistics.dm

@@ -134,7 +134,6 @@
 	feedback_add_details("radio_usage","CAR-[msg_cargo.len]")
 	feedback_add_details("radio_usage","SRV-[msg_service.len]")
 	feedback_add_details("radio_usage","OTH-[messages.len]")
-	feedback_add_details("radio_usage","PDA-[pda_msg_amt]")
 	feedback_add_details("radio_usage","RC-[rc_msg_amt]")
 
 	for (var/key in simple_statistics)

code/controllers/subsystems/traumas.dm

@@ -63,7 +63,7 @@ var/datum/controller/subsystem/traumas/SStraumas
 
 					   "clowns"    = typecacheof(list(/obj/item/clothing/under/rank/clown, /obj/item/clothing/shoes/clown_shoes,
 												 /obj/item/clothing/mask/gas/clown_hat, /obj/item/bananapeel,
-												 /obj/item/bikehorn, /obj/item/device/pda/clown)),
+												 /obj/item/bikehorn, /obj/item/modular_computer/handheld/pda/civilian/clown)),
 
 					   "cats"  = typecacheof(list(/obj/item/clothing/head/tajaran, /obj/item/clothing/suit/storage/tajaran,
 												 /obj/item/clothing/suit/storage/toggle/labcoat/tajaran, /obj/item/clothing/suit/storage/tajaran,