Forum-Auth-Fixes (#12728)

Changes a Status-Code and a Description of the Forum-Auth-System to better reflect what is actually happening.

Co-authored-by: Werner <Arrow768@users.noreply.github.com>

code/modules/world_api/commands/api_helpers.dm

@@ -13,7 +13,7 @@
 	//The Version Number follows SemVer http://semver.org/
 	version["major"] = 3 //Major Version Number --> Increment when implementing breaking changes
 	version["minor"] = 0 //Minor Version Number --> Increment when adding features
-	version["patch"] = 0 //Patchlevel --> Increment when fixing bugs
+	version["patch"] = 1 //Patchlevel --> Increment when fixing bugs
 
 	versionstring = "[version["major"]].[version["minor"]].[version["patch"]]"
 

code/modules/world_api/commands/misc.dm

@@ -203,7 +203,7 @@
 	if(cl)
 		to_chat(cl, "Another connection has been made using your login key. This session has been terminated.")
 		del(cl)
-	
+
 	statuscode = 200
 	response = "Client has been authenticated sucessfully."
 	una.ClientLogin(queryparams["key"])
@@ -219,7 +219,7 @@
 /datum/topic_command/get_auth_client_ip/run_command(queryparams)
 	if(!(queryparams["clienttoken"] in unauthed))
 		statuscode = 404
-		response = "Client with such token is not found."
+		response = "Unauthed client with such token is not found."
 		return TRUE
 
 	var/mob/abstract/unauthed/una = unauthed[queryparams["clienttoken"]]
@@ -230,7 +230,7 @@
 		return TRUE
 
 	if(!config.external_auth)
-		statuscode = 500
+		statuscode = 403
 		response = "External auth is disallowed."
 		del(una.client)
 		del(una)
@@ -253,7 +253,7 @@
 		config.external_auth = !config.external_auth
 	else
 		config.external_auth = queryparams["state"]
-	
+
 	statuscode = 200
 	response = "External authentication state has been updated sucessfully."
 	data = config.external_auth

html/changelogs/arrow768-server-auth-fixes.yml

@@ -0,0 +1,41 @@
+################################
+# Example Changelog File
+#
+# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb.
+#
+# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.)
+# When it is, any changes listed below will disappear.
+#
+# Valid Prefixes:
+#   bugfix
+#   wip (For works in progress)
+#   tweak
+#   soundadd
+#   sounddel
+#   rscadd (general adding of nice things)
+#   rscdel (general deleting of nice things)
+#   imageadd
+#   imagedel
+#   maptweak
+#   spellcheck (typo fixes)
+#   experiment
+#   balance
+#   admin
+#   backend
+#   security
+#   refactor
+#################################
+
+# Your name.
+author: Arrow768
+
+# Optional: Remove this file after generating master changelog.  Useful for PR changelogs that won't get used again.
+delete-after: True
+
+# Any changes you've made.  See valid prefix list above.
+# INDENT WITH TWO SPACES.  NOT TABS.  SPACES.
+# SCREW THIS UP AND IT WON'T WORK.
+# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries.
+# Please surround your changes in  double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog.
+changes:
+  - backend: "Smaller Fixes to the Forum-Authentication-System."