cyberpresidentvanellope/Aurora.3
1
0
Fork 0
mirror of https://github.com/Aurorastation/Aurora.3.git synced 2026-08-29 16:10:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Implanted HUD Flicker Fix (#22191)

Browse Source 
closes #22079 
closes #21945

This bug was also my fault, and it happened when I decoupled organ
processing from the life() tick to prevent organs being processed twice.
Since Huds were generated during the Life() tick, but implants were
adding the Hud during Process(), a flicker occured whenever they fired
out of sync, with the Life() tick erasing the hud and Process() adding
it back. To significantly cut down on the time complexity of having to
iterate and fire every HUD producing implant and component during
Life(), I've instead reworked it into a Signal that permits the HUD
implants to inject hud elements into the Life() codepath dynamically.

Here is the fix in action now.


https://github.com/user-attachments/assets/18ccc80d-cb5f-4fd7-9ad5-28c91acf6ca5
This commit is contained in:
VMSolidus
2026-04-11 14:24:34 +00:00
committed by GitHub
parent 676919b876
commit 68892b7fb0
5 changed files with 48 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
code/modules/organs/subtypes/augment/augments/eye_sensors.dm
+35 -13
View File
@@ -15,17 +15,38 @@
var/selected_hud = "disabled"
/obj/item/organ/internal/augment/eye_sensors/attack_self(var/mob/user)
/obj/item/organ/internal/augment/eye_sensors/Initialize()
. = ..()
if(!owner)
return
RegisterSignal(owner, COMSIG_MOB_UPDATE_VISION, PROC_REF(handle_vision_update))
/obj/item/organ/internal/augment/eye_sensors/replaced(mob/living/carbon/human/target)
. = ..()
if(!owner)
return
RegisterSignal(owner, COMSIG_MOB_UPDATE_VISION, PROC_REF(handle_vision_update))
/obj/item/organ/internal/augment/eye_sensors/removed()
if(!owner)
return ..()
UnregisterSignal(owner, COMSIG_MOB_UPDATE_VISION)
return ..()
/obj/item/organ/internal/augment/eye_sensors/attack_self(mob/user)
. = ..()
if(!.)
return FALSE
/obj/item/organ/internal/augment/eye_sensors/process()
..()
// Update HUD immediately on toggle
handle_vision_update()
if(!owner)
return
/obj/item/organ/internal/augment/eye_sensors/proc/handle_vision_update(mob/living/carbon/human/H)
SIGNAL_HANDLER
/obj/item/organ/internal/augment/eye_sensors/emp_act(severity)
. = ..()
@@ -36,14 +57,14 @@
E.take_damage(5)
/obj/item/organ/internal/augment/eye_sensors/proc/check_hud(var/hud)
/obj/item/organ/internal/augment/eye_sensors/proc/check_hud(hud)
return (hud == active_hud)
/obj/item/organ/internal/augment/eye_sensors/security
name = "integrated security HUD sensors"
action_button_name = "Toggle Security Sensors"
/obj/item/organ/internal/augment/eye_sensors/security/attack_self(var/mob/user)
/obj/item/organ/internal/augment/eye_sensors/security/attack_self(mob/user)
. = ..()
if(selected_hud == "disabled")
@@ -53,11 +74,11 @@
selected_hud = "disabled"
to_chat(user, SPAN_NOTICE("You deactivate \the [src]."))
/obj/item/organ/internal/augment/eye_sensors/security/process()
..()
/obj/item/organ/internal/augment/eye_sensors/security/handle_vision_update(mob/living/carbon/human/H)
if(!owner)
return
switch(selected_hud)
if(SEC_HUDTYPE)
req_access = list(ACCESS_SECURITY)
if(allowed(owner))
@@ -72,7 +93,7 @@
name = "integrated medical HUD sensors"
action_button_name = "Toggle Medical Sensors"
/obj/item/organ/internal/augment/eye_sensors/medical/attack_self(var/mob/user)
/obj/item/organ/internal/augment/eye_sensors/medical/attack_self(mob/user)
. = ..()
if(selected_hud == "disabled")
@@ -82,8 +103,9 @@
selected_hud = "disabled"
to_chat(user, SPAN_NOTICE("You deactivate \the [src]."))
/obj/item/organ/internal/augment/eye_sensors/medical/process()
..()
/obj/item/organ/internal/augment/eye_sensors/medical/handle_vision_update(mob/living/carbon/human/H)
if(!owner)
return
switch(selected_hud)
code/modules/organs/subtypes/augment/augments/phalanx_facial_plate.dm
+3 -2
View File
@@ -29,8 +29,9 @@
to_chat(user, "You deactivate \the [src].")
return
/obj/item/organ/internal/augment/eye_sensors/phalanx/process()
..()
/obj/item/organ/internal/augment/eye_sensors/phalanx/handle_vision_update(mob/living/carbon/human/H)
if(!owner)
return
switch(selected_hud)
if(SEC_HUDTYPE)