From 689fe0c3462044c664143c4e7e582776cbd0de40 Mon Sep 17 00:00:00 2001 From: Geeves Date: Sat, 14 Nov 2020 16:42:02 +0200 Subject: [PATCH] Funky Verb Fix (#10549) --- code/modules/admin/verbs/debug.dm | 10 +++------- html/changelogs/geeves-funky_messages.yml | 6 ++++++ 2 files changed, 9 insertions(+), 7 deletions(-) create mode 100644 html/changelogs/geeves-funky_messages.yml diff --git a/code/modules/admin/verbs/debug.dm b/code/modules/admin/verbs/debug.dm index afebeec9085..f27e7c54be4 100644 --- a/code/modules/admin/verbs/debug.dm +++ b/code/modules/admin/verbs/debug.dm @@ -270,20 +270,16 @@ var/list/chosen_observers = list() var/next_observer = "NotGeeves" - while(next_observer != "== Finished ==") - var/list/valid_choices = player_list + while(next_observer) + var/list/valid_choices = player_list.Copy() for(var/choice in valid_choices) if(choice in chosen_observers) valid_choices -= choice if(!isobserver(choice)) valid_choices -= choice - valid_choices += "== Finished ==" next_observer = input("Choose an observer you want to add to the list.", "Choose Observer") as null|anything in valid_choices - if(!next_observer || isnull(next_observer)) - next_observer = "== Finished ==" - else + if(next_observer) chosen_observers += next_observer - chosen_observers -= "== Finished ==" for(var/spawn_observer in chosen_observers) var/mob/living/carbon/human/H = new /mob/living/carbon/human(get_turf(usr)) diff --git a/html/changelogs/geeves-funky_messages.yml b/html/changelogs/geeves-funky_messages.yml new file mode 100644 index 00000000000..c3513823897 --- /dev/null +++ b/html/changelogs/geeves-funky_messages.yml @@ -0,0 +1,6 @@ +author: Geeves + +delete-after: True + +changes: + - bugfix: "Fixed a verb that caused visible messages (and more) to break." \ No newline at end of file