From 71829343236e6e6ce8e907d0ed3f2a6f278b1701 Mon Sep 17 00:00:00 2001 From: "Wowzewow (Wezzy)" <42310821+alsoandanswer@users.noreply.github.com> Date: Tue, 17 Oct 2023 03:27:31 +0800 Subject: [PATCH] Friday the Thirteenth Bugfixes (#17594) Title --- code/game/objects/effects/chem/chemsmoke.dm | 10 ++++- .../core/assemblies/clothing.dm | 4 +- .../reagents/reagent_containers/spray.dm | 2 + html/changelogs/Wezzy_randobugfix.yml | 43 +++++++++++++++++++ 4 files changed, 55 insertions(+), 4 deletions(-) create mode 100644 html/changelogs/Wezzy_randobugfix.yml diff --git a/code/game/objects/effects/chem/chemsmoke.dm b/code/game/objects/effects/chem/chemsmoke.dm index a847454ebd6..81b0c17c5c4 100644 --- a/code/game/objects/effects/chem/chemsmoke.dm +++ b/code/game/objects/effects/chem/chemsmoke.dm @@ -48,13 +48,19 @@ /obj/effect/effect/smoke/chem/Crossed(atom/movable/AM) ..() if(!istype(AM, /obj/effect/effect/smoke/chem)) - reagents.splash(AM, splash_amount, copy = 1) + if(istype(AM, /obj/item/reagent_containers) && !AM.is_open_container()) + return + else + reagents.splash(AM, splash_amount, copy = 1) /obj/effect/effect/smoke/chem/proc/initial_splash() for(var/turf/T in view(1, src)) for(var/atom/movable/AM in T) if(!istype(AM, /obj/effect/effect/smoke/chem)) - reagents.splash(AM, splash_amount, copy = 1) + if(istype(AM, /obj/item/reagent_containers) && !AM.is_open_container()) + return + else + reagents.splash(AM, splash_amount, copy = 1) ///////////////////////////////////////////// // Chem Smoke Effect System diff --git a/code/modules/integrated_electronics/core/assemblies/clothing.dm b/code/modules/integrated_electronics/core/assemblies/clothing.dm index 780ebccffaa..28ec97d8815 100644 --- a/code/modules/integrated_electronics/core/assemblies/clothing.dm +++ b/code/modules/integrated_electronics/core/assemblies/clothing.dm @@ -62,13 +62,13 @@ . = ..() /obj/item/clothing/attackby(obj/item/I, mob/user) - if(IC) + if(IC && (istype(I, /obj/item/integrated_circuit) || I.iswrench() || I.iscrowbar() || istype(I, /obj/item/device/integrated_electronics/wirer) || istype(I, /obj/item/device/integrated_electronics/debugger) || I.ismultitool() || I.isscrewdriver() || istype(I, /obj/item/cell/device))) IC.attackby(I, user) else ..() /obj/item/clothing/attack_self(mob/user) - if(IC) + if(IC?.opened) IC.attack_self(user) else ..() diff --git a/code/modules/reagents/reagent_containers/spray.dm b/code/modules/reagents/reagent_containers/spray.dm index 65078ec6921..5e42990e42c 100644 --- a/code/modules/reagents/reagent_containers/spray.dm +++ b/code/modules/reagents/reagent_containers/spray.dm @@ -36,6 +36,8 @@ /obj/item/reagent_containers/spray/afterattack(atom/A as mob|obj, mob/user as mob, proximity) + if(A.loc == user) // don't spray yourself + return if(istype(A, /obj/item/reagent_containers)) . = ..() diff --git a/html/changelogs/Wezzy_randobugfix.yml b/html/changelogs/Wezzy_randobugfix.yml new file mode 100644 index 00000000000..d2007186add --- /dev/null +++ b/html/changelogs/Wezzy_randobugfix.yml @@ -0,0 +1,43 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# wip (For works in progress) +# tweak +# soundadd +# sounddel +# rscadd (general adding of nice things) +# rscdel (general deleting of nice things) +# imageadd +# imagedel +# maptweak +# spellcheck (typo fixes) +# experiment +# balance +# admin +# backend +# security +# refactor +################################# + +# Your name. +author: Wowzewow (Wezzy) + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries. +# Please surround your changes in double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Fixes odd interactions with webbing and integrated circuit clothing." + - bugfix: "Fixes spray containers playing a sound when being stored in webbing." + - bugfix: "Fixes scrubber backblasts filling closed reagent containers."