Turn more unmanaged global vars into GLOB (#20446)

Turned a ton of unmanaged globals into managed globals.
Refactored some UT output.
Removed some unused things, including vars.
Added a test to ensure people don't keep adding new unmanaged vars.
This commit is contained in:
Fluffy
2025-02-17 23:34:02 +00:00
committed by GitHub
parent eff1fb22de
commit 7265630dde
377 changed files with 1893 additions and 2288 deletions
@@ -124,7 +124,7 @@
var/datum/species/S = GLOB.all_species[pref.species]
if(href_list["open_culture_menu"])
var/list/options = list()
var/list/possible_cultures = Singletons.GetMap(S.possible_cultures)
var/list/possible_cultures = GLOB.Singletons.GetMap(S.possible_cultures)
for(var/decl_type in possible_cultures)
var/singleton/origin_item/culture/CL = possible_cultures[decl_type]
options[CL.name] = CL
@@ -137,7 +137,7 @@
if(href_list["open_origin_menu"])
var/list/options = list()
var/singleton/origin_item/culture/our_culture = GET_SINGLETON(text2path(pref.culture)) //plutonians be like
var/list/singleton/origin_item/origin/origins_list = Singletons.GetMap(our_culture.possible_origins)
var/list/singleton/origin_item/origin/origins_list = GLOB.Singletons.GetMap(our_culture.possible_origins)
for(var/decl_type in origins_list)
var/singleton/origin_item/origin/OR = origins_list[decl_type]
options[OR.name] = OR