Turn more unmanaged global vars into GLOB (#20446)

Turned a ton of unmanaged globals into managed globals.
Refactored some UT output.
Removed some unused things, including vars.
Added a test to ensure people don't keep adding new unmanaged vars.
This commit is contained in:
Fluffy
2025-02-18 00:34:02 +01:00
committed by GitHub
parent eff1fb22de
commit 7265630dde
377 changed files with 1893 additions and 2288 deletions
+5 -5
View File
@@ -1,10 +1,10 @@
var/global/list/datum/supply_drop_loot/supply_drop
GLOBAL_LIST_INIT_TYPED(supply_drop, /datum/supply_drop_loot, null)
/proc/supply_drop_random_loot_types()
if(!supply_drop)
supply_drop = init_subtypes(/datum/supply_drop_loot)
sortTim(supply_drop, GLOBAL_PROC_REF(cmp_supply_drop), FALSE)
return supply_drop
if(!GLOB.supply_drop)
GLOB.supply_drop = init_subtypes(/datum/supply_drop_loot)
sortTim(GLOB.supply_drop, GLOBAL_PROC_REF(cmp_supply_drop), FALSE)
return GLOB.supply_drop
/datum/supply_drop_loot
var/name = ""
+3 -3
View File
@@ -1,4 +1,4 @@
var/maze_cell_count = 0
GLOBAL_VAR_INIT(maze_cell_count, 0)
/datum/maze_cell
var/name
@@ -9,8 +9,8 @@ var/maze_cell_count = 0
var/oy
/datum/maze_cell/New(var/nx,var/ny,var/nox,var/noy)
maze_cell_count++
uid = maze_cell_count
GLOB.maze_cell_count++
uid = GLOB.maze_cell_count
name = "cell #[uid]"
x = nx
y = ny