From 72b9bd6bbfe2393cec0d467007a3e2dc2a64827d Mon Sep 17 00:00:00 2001 From: ElorgRHG <71735193+ElorgRHG@users.noreply.github.com> Date: Wed, 29 Jul 2026 18:21:44 +0200 Subject: [PATCH] Fixes the screens of unpowered PDAs disappearing (#22962) As the title says, it has bothered me for a bit. Now every PDA base sprite has a screen instead of relying on the overlays to add one on them. This _somewhat_ unfortunately resulted in the PDAs which had any alpha (transparency) on their screens to no longer have them. No big loss. From the changelog: > - bugfix: "The screens of unpowered PDAs no longer disappear" Most likely should have done it it properly with overlays, but this also works. --- .../modular_computers/computers/subtypes/dev_pda.dm | 6 ++++++ .../computers/subtypes/dev_wristbound.dm | 6 ++++++ html/changelogs/ElorgRHG-unpowered-pda-fix.yml | 13 +++++++++++++ 3 files changed, 25 insertions(+) create mode 100644 html/changelogs/ElorgRHG-unpowered-pda-fix.yml diff --git a/code/modules/modular_computers/computers/subtypes/dev_pda.dm b/code/modules/modular_computers/computers/subtypes/dev_pda.dm index 533248fe018..368e5149882 100644 --- a/code/modules/modular_computers/computers/subtypes/dev_pda.dm +++ b/code/modules/modular_computers/computers/subtypes/dev_pda.dm @@ -17,6 +17,12 @@ icon_state_unpowered = icon_state icon_state_broken = icon_state +/obj/item/modular_computer/handheld/pda/update_icon() + . = ..() + if(!enabled) + AddOverlays("off") + return + /obj/item/modular_computer/handheld/pda/old icon = 'icons/obj/modular_computers/pda_old.dmi' diff --git a/code/modules/modular_computers/computers/subtypes/dev_wristbound.dm b/code/modules/modular_computers/computers/subtypes/dev_wristbound.dm index 820c4b47023..bdb751589da 100644 --- a/code/modules/modular_computers/computers/subtypes/dev_wristbound.dm +++ b/code/modules/modular_computers/computers/subtypes/dev_wristbound.dm @@ -18,6 +18,12 @@ icon_state_unpowered = icon_state icon_state_broken = icon_state +/obj/item/modular_computer/handheld/wristbound/update_icon() + . = ..() + if(!enabled) + AddOverlays("off") + return + /obj/item/modular_computer/handheld/wristbound/attack_hand(mob/user) if(ishuman(user)) var/mob/living/carbon/human/H = user diff --git a/html/changelogs/ElorgRHG-unpowered-pda-fix.yml b/html/changelogs/ElorgRHG-unpowered-pda-fix.yml new file mode 100644 index 00000000000..b7ef72724cd --- /dev/null +++ b/html/changelogs/ElorgRHG-unpowered-pda-fix.yml @@ -0,0 +1,13 @@ +# Your name. +author: ElorgRHG + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "The screens of unpowered PDAs no longer disappear"