Fix persistence on non-Horizon and admin persistence toggle admin verb (#22301)

# Summary

This PR fixes persistence on non-Horizon maps and adds an admin verb to
toggle saving at round end.

## Changes

- Fixed persistency being used on non-Horizon maps, prevents loading and
saving.
- Added admin verb "Toggle persistence" to prevent saving at round end.

## Verb preview

Verb location
<img width="194" height="147" alt="Screenshot 2026-04-20 204519"
src="https://github.com/user-attachments/assets/bf043fd3-f021-4da8-b74f-f03373379e64"
/>

Input to disable
<img width="319" height="144" alt="Screenshot 2026-04-20 204628"
src="https://github.com/user-attachments/assets/a681d8d3-ce6b-49e1-a145-b994f40b3f6d"
/>

Disable output
<img width="897" height="50" alt="Screenshot 2026-04-20 204644"
src="https://github.com/user-attachments/assets/eedc04d1-31a1-4a49-854c-b78e43b41be5"
/>

Input to re-enable
<img width="318" height="132" alt="Screenshot 2026-04-20 204653"
src="https://github.com/user-attachments/assets/cdcf88f2-1a7e-4755-872e-613206756224"
/>

Re-enable output
<img width="898" height="48" alt="Screenshot 2026-04-20 204709"
src="https://github.com/user-attachments/assets/1a583342-45fb-41dd-ad21-f349c577646b"
/>

---------

Signed-off-by: FabianK3 <21039694+FabianK3@users.noreply.github.com>
Co-authored-by: SleepyGemmy <99297919+SleepyGemmy@users.noreply.github.com>
This commit is contained in:
FabianK3
2026-04-22 20:21:39 +00:00
committed by GitHub
co-authored by SleepyGemmy
parent 7221e0384a
commit 74a02b1f99
6 changed files with 147 additions and 73 deletions
@@ -13,13 +13,14 @@ SUBSYSTEM_DEF(persistence)
name = "Persistence"
init_order = INIT_ORDER_PERSISTENCE // The order is tied with the init and maploading subsystem.
flags = SS_NO_FIRE // This subsystem has no continues workload, it's init and shutdown only.
var/prevent_saving = FALSE // Toggle to prevent saving at round end, changed by toggle_persistence proc, used for admin purposes.
/**
* Subsystem info stub message generation.
*/
/datum/controller/subsystem/persistence/stat_entry(msg)
msg = ("Tracked object register: [length(GLOB.persistence_object_track_register)]")
return ..()
msg = ("Register: [length(GLOB.persistence_object_track_register)] | Prevent saving: [SSpersistence.prevent_saving ? "TRUE" : "FALSE"]")
return msg
/**
* Helper method to check and log database connection.
@@ -48,6 +49,36 @@ SUBSYSTEM_DEF(persistence)
return FALSE
return TRUE
/datum/admins/proc/toggle_persistence()
set name = "Toggle Persistence"
set category = "Special Verbs"
if(!check_rights(R_ADMIN))
return
var/message = ""
var/options = list()
if(SSpersistence.prevent_saving)
message = "The persistence subsystem will NOT save at the end of the round. Do you want to re-enable it?"
options = list("Re-enable saving", "Cancel")
else
message = "The persistence subsystem will save at the end of the round. Do you want to prevent this? This can be un-done before the round ends."
options = list("Prevent saving", "Cancel")
var/confirm = tgui_alert(usr, message, "Toggle Persistence Saving", options)
if(confirm == "Prevent saving")
SSpersistence.prevent_saving = TRUE
to_world(FONT_LARGE(EXAMINE_BLOCK_RED("Persistence saving at the end of the round has been [SPAN_BOLD(SPAN_WARNING("disabled"))] by an administrator.")))
log_and_message_admins("has toggled persistence saving at round end, it is now disabled", usr)
else if (confirm == "Re-enable saving")
SSpersistence.prevent_saving = FALSE
to_world(FONT_LARGE(EXAMINE_BLOCK_RED("Persistence saving at the end of the round has been [SPAN_BOLD(SPAN_GOOD("re-enabled"))] by an administrator.")))
log_and_message_admins("has toggled persistence saving at round end, it is now re-enabled", usr)
else
return
feedback_add_details("admin_verb","TP") //If you are copy-pasting this, ensure the 2nd parameter is unique to the new proc!
/**
* Initialization of the persistence subsystem.
* Includes generic startup checks and init of the different persistent data types.
@@ -74,6 +105,10 @@ SUBSYSTEM_DEF(persistence)
* The shutdown consists of finalization steps for each persistent data type.
*/
/datum/controller/subsystem/persistence/Shutdown()
if(prevent_saving)
log_subsystem_persistence_warning("Persistence subsystem was toggled to not save. Skipping subsystem finalization.")
return
if(!databaseCheckConnection("subsystem shutdown"))
log_subsystem_persistence_panic("SQL error during persistence subsystem shutdown. Cannot finalise persistence of the round.")
return
@@ -6,6 +6,10 @@
PRIVATE_PROC(TRUE)
GLOB.persistence_object_track_register = list()
if(SSatlas.current_map.path != "sccv_horizon") // The persistence system only supports objects from the main map levels for multiple reasons, e.g. Z level value, mapping support
log_subsystem_persistence_info("Persistent objects: Current map did not match SCCV Horizon, skipping persistent object initialization.")
return
// Delete all persistent objects in the database that have expired and have passed the cleanup grace period (PERSISTENT_EXPIRATION_CLEANUP_DELAY_DAYS)
objectsDatabaseCleanEntries()
@@ -36,6 +40,12 @@
/datum/controller/subsystem/persistence/proc/objectsFinalize()
PRIVATE_PROC(TRUE)
if(SSatlas.current_map.path != "sccv_horizon") // The persistence system only supports objects from the main map levels for multiple reasons, e.g. Z level value, mapping support
log_subsystem_persistence_info("Persistent objects: Current map did not match SCCV Horizon, skipping persistent object finalization.")
if(length(GLOB.persistence_object_track_register) > 0)
log_subsystem_persistence_warning("Persistent objects: There are [length(GLOB.persistence_object_track_register)] tracked objects at finalization, while the map is not supported! These track will not be saved! Verify that SSatlas.current_map.path has not changed during the round!")
return
// Subsystem shutdown:
// Create new persistent records for objects that have been created in the round
// Update tracked objects that have an ID (already existing from previous rounds)
@@ -10,7 +10,7 @@
return
var/turf/T = get_turf(new_track)
if(!T || !is_station_level(T.z)) // The persistence system only supports objects from the main map levels for multiple reasons, e.g. Z level value, mapping support
if(!T || !is_station_level(T.z) || SSatlas.current_map.path != "sccv_horizon") // The persistence system only supports objects from the main map levels for multiple reasons, e.g. Z level value, mapping support
return
new_track.persistent_objects_track_active = TRUE