Reworking Bot API and optimizing for loops in admin code (#6355)

code/modules/world_api/commands/admin.dm

@@ -105,7 +105,7 @@
 	sound_to(C, 'sound/effects/adminhelp.ogg')
 	to_chat(C, message)
 
-	for(var/client/A in admins)
+	for(var/client/A in staff)
 		if(A != C)
 			to_chat(A, amessage)
 

code/modules/world_api/commands/api_helpers.dm

@@ -12,7 +12,7 @@
 	var/versionstring = null
 	//The Version Number follows SemVer http://semver.org/
 	version["major"] = 2 //Major Version Number --> Increment when implementing breaking changes
-	version["minor"] = 5 //Minor Version Number --> Increment when adding features
+	version["minor"] = 6 //Minor Version Number --> Increment when adding features
 	version["patch"] = 0 //Patchlevel --> Increment when fixing bugs
 
 	versionstring = "[version["major"]].[version["minor"]].[version["patch"]]"

code/modules/world_api/commands/server_query.dm

@@ -21,12 +21,13 @@
 
 	s["players"] = clients.len
 	s["admins"] = 0
+	s["staff"] = staff.len
 
-	for(var/client/C in clients)
-		if(C.holder)
-			if(C.holder.fakekey)
-				continue
-
+	for(var/S in staff)
+		var/client/C = S
+		if(C.holder.fakekey)
+			continue
+		if(C.holder.rights & R_BAN) // we are doing R_BAN to not count retired admins, since they get R_MOD and R_ADMIN but not R_BAN.
 			s["admins"]++
 
 	statuscode = 200
@@ -42,7 +43,7 @@
 
 /datum/topic_command/get_stafflist/run_command(queryparams)
 	var/list/staff = list()
-	for (var/client/C in admins)
+	for (var/client/C in staff)
 		staff[C] = C.holder.rank
 
 	statuscode = 200