Lag War Day 2: TGUI performance improvements (#21848)

<img width="707" height="659" alt="image" src="https://github.com/user-attachments/assets/6c8db0bf-dec6-40f2-86e8-120531fa5693" /> the traitor uplink is causing a genuine hostage situation to the server by simply being open due to the frankly insane amount of data that it builds and ships every single UI process tick (which is very often!!!) i've never been ragebaited by a single .dm file before so hard in my entire developer career so I simply neutered it into using static data and hit the commit button. it might break, if it does we're burning it to the ground and remaking it. genuinely heinous crimes going on there In addition I'm porting: * [Fix several SHOULD_NOT_SLEEP hits in SStgui.update_uis() tgstation/tgstation#75411](https://github.com/tgstation/tgstation/pull/75411) * [Moves ui references from the tgui subsystem to datums themselves tgstation/tgstation#76215](https://github.com/tgstation/tgstation/pull/76215) * [Fixes some spurious runtimes in SStgui procs tgstation/tgstation#76251](https://github.com/tgstation/tgstation/pull/76251) * [Fixes tgui_open_uis tracking tgstation/tgstation#77101](https://github.com/tgstation/tgstation/pull/77101) moving ui references to the datums themselves is a pretty nice performance boost because otherwise we have to iterate across all open uis every time a list input closes which sucks! the rest are just fixes to that original PR. thank you for your attention to this matter
2026-07-13 00:47:31 +01:00 · 2026-02-13 21:17:23 -05:00
parent efe710f425
commit 84d3a447ab
7 changed files with 126 additions and 124 deletions
@@ -6,7 +6,7 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 	stat_tag = "A"

 	// NanoUI stuff.
-	var/list/open_uis = list()
+	var/list/open_nanouis = list()

 /**
 * Get an open /nanoui ui for the current user, src_object and ui_key and try to update it with data
@@ -43,10 +43,10 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 */
 /datum/controller/subsystem/processing/nanoui/proc/get_open_ui(mob/user, src_object, ui_key)
 	var/src_object_key = REF(src_object)
-	if (!LAZYLEN(open_uis[src_object_key]) || !LAZYLEN(open_uis[src_object_key][ui_key]))
+	if (!LAZYLEN(open_nanouis[src_object_key]) || !LAZYLEN(open_nanouis[src_object_key][ui_key]))
 		return null

-	for (var/datum/nanoui/ui in open_uis[src_object_key][ui_key])
+	for (var/datum/nanoui/ui in open_nanouis[src_object_key][ui_key])
 		if (ui.user == user)
 			return ui

@@ -62,11 +62,11 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 */
 /datum/controller/subsystem/processing/nanoui/proc/update_uis(src_object)
 	var/src_object_key = REF(src_object)
-	if (!LAZYLEN(open_uis[src_object_key]))
+	if (!LAZYLEN(open_nanouis[src_object_key]))
 		return 0

 	. = 0
-	var/list/obj_uis = open_uis[src_object_key]
+	var/list/obj_uis = open_nanouis[src_object_key]
 	for (var/ui_key in obj_uis)
 		for (var/thing in obj_uis[ui_key])
 			var/datum/nanoui/ui = thing
@@ -83,11 +83,11 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 */
 /datum/controller/subsystem/processing/nanoui/proc/close_uis(src_object)
 	var/src_object_key = REF(src_object)
-	if (!open_uis[src_object_key] || !islist(open_uis[src_object_key]))
+	if (!open_nanouis[src_object_key] || !islist(open_nanouis[src_object_key]))
 		return 0

 	. = 0
-	var/list/obj_uis = open_uis[src_object_key]
+	var/list/obj_uis = open_nanouis[src_object_key]
 	for (var/ui_key in obj_uis)
 		for (var/thing in obj_uis[ui_key])
 			var/datum/nanoui/ui = thing
@@ -105,27 +105,27 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 * Returns the number of UIs updated
 */
 /datum/controller/subsystem/processing/nanoui/proc/update_user_uis(mob/user, src_object, ui_key)
-	if (!LAZYLEN(user.open_uis))
+	if (!LAZYLEN(user.open_nanouis))
 		return 0 // has no open uis

 	. = 0
-	for (var/thing in user.open_uis)
+	for (var/thing in user.open_nanouis)
 		var/datum/nanoui/ui = thing
 		if (NULL_OR_EQUAL(src_object, ui.src_object) && NULL_OR_EQUAL(ui_key, ui.ui_key))
 			ui.process(1)
 			.++

 /datum/controller/subsystem/processing/nanoui/proc/close_user_uis(mob/user, src_object, ui_key)
-	if (!LAZYLEN(user.open_uis))
+	if (!LAZYLEN(user.open_nanouis))
 		return 0

-	for (var/thing in user.open_uis)
+	for (var/thing in user.open_nanouis)
 		var/datum/nanoui/ui = thing
 		if (NULL_OR_EQUAL(src_object, ui.src_object) && NULL_OR_EQUAL(ui_key, ui.ui_key))
 			ui.close()
 			.++

-	//testing("nanomanager/close_user_uis mob [user.name] closed [open_uis.len] of [.] uis")
+	//testing("nanomanager/close_user_uis mob [user.name] closed [open_nanouis.len] of [.] uis")

 /**
 * Add a /nanoui ui to the list of open uis
@@ -135,12 +135,12 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 */
 /datum/controller/subsystem/processing/nanoui/proc/ui_opened(datum/nanoui/ui)
 	var/src_object_key = REF(ui.src_object)
-	LAZYINITLIST(open_uis[src_object_key])
+	LAZYINITLIST(open_nanouis[src_object_key])

-	LAZYADD(ui.user.open_uis, ui)
-	LAZYADD(open_uis[src_object_key][ui.ui_key], ui)
+	LAZYADD(ui.user.open_nanouis, ui)
+	LAZYADD(open_nanouis[src_object_key][ui.ui_key], ui)
 	START_PROCESSING(SSnanoui, ui)
-	//testing("nanomanager/ui_opened mob [ui.user.name] [ui.src_object:name] [ui.ui_key] - user.open_uis [ui.user.open_uis.len] | uis [uis.len] | processing_uis [processing_uis.len]")
+	//testing("nanomanager/ui_opened mob [ui.user.name] [ui.src_object:name] [ui.ui_key] - user.open_nanouis [ui.user.open_nanouis.len] | uis [uis.len] | processing_uis [processing_uis.len]")

 /**
 * Remove a /nanoui ui from the list of open uis
@@ -153,14 +153,14 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 /datum/controller/subsystem/processing/nanoui/proc/ui_closed(datum/nanoui/ui)
 	var/src_object_key = REF(ui.src_object)
 	var/ui_key = ui.ui_key
-	var/list/obj_uis = open_uis[src_object_key]
+	var/list/obj_uis = open_nanouis[src_object_key]

 	if (!LAZYLEN(obj_uis) || !obj_uis[ui_key])
 		return 0	// Wasn't open.

 	STOP_PROCESSING(SSnanoui, ui)
 	if(ui.user)	// Sanity check in case a user has been deleted (say a blown up borg watching the alarm interface)
-		LAZYREMOVE(ui.user.open_uis, ui)
+		LAZYREMOVE(ui.user.open_nanouis, ui)

 	obj_uis[ui_key] -= ui

@@ -168,9 +168,9 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 		obj_uis -= ui_key

 	if (!LAZYLEN(obj_uis))
-		open_uis -= src_object_key
+		open_nanouis -= src_object_key

-	//testing("nanomanager/ui_closed mob [ui.user.name] [ui.src_object:name] [ui.ui_key] - user.open_uis [ui.user.open_uis.len] | uis [uis.len] | processing_uis [processing_uis.len]")
+	//testing("nanomanager/ui_closed mob [ui.user.name] [ui.src_object:name] [ui.ui_key] - user.open_nanouis [ui.user.open_nanouis.len] | uis [uis.len] | processing_uis [processing_uis.len]")

 	return 1

@@ -192,16 +192,16 @@ PROCESSING_SUBSYSTEM_DEF(nanoui)
 */
 /datum/controller/subsystem/processing/nanoui/proc/user_transferred(mob/oldMob, mob/newMob)
 	//testing("nanomanager/user_transferred from mob [oldMob.name] to mob [newMob.name]")
-	if (!oldMob || !LAZYLEN(oldMob.open_uis) || !LAZYLEN(open_uis))
+	if (!oldMob || !LAZYLEN(oldMob.open_nanouis) || !LAZYLEN(open_nanouis))
 		//testing("nanomanager/user_transferred mob [oldMob.name] has no open uis")
 		return 0 // has no open uis

-	for (var/thing in oldMob.open_uis)
+	for (var/thing in oldMob.open_nanouis)
 		var/datum/nanoui/ui = thing
 		ui.user = newMob
-		LAZYADD(newMob.open_uis, ui)
+		LAZYADD(newMob.open_nanouis, ui)

-	oldMob.open_uis = null
+	oldMob.open_nanouis = null

 	return 1 // success

@@ -19,10 +19,8 @@ PROCESSING_SUBSYSTEM_DEF(tgui)

 	/// A list of UIs scheduled to process
 	var/list/current_run = list()
-	/// A list of open UIs
-	var/list/open_uis = list()
-	/// A list of open UIs, grouped by src_object.
-	var/list/open_uis_by_src = list()
+	/// A list of all open UIs
+	var/list/all_uis = list()
 	/// The HTML base used for all UIs.
 	var/basehtml

@@ -58,13 +56,13 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 	close_all_uis()

 /datum/controller/subsystem/processing/tgui/stat_entry(msg)
-	msg = "P:[length(open_uis)]"
+	msg = "P:[length(all_uis)]"
 	return ..()

 /datum/controller/subsystem/processing/tgui/fire(resumed = FALSE)
 	CAN_BE_REDEFINED(TRUE)
 	if(!resumed)
-		src.current_run = open_uis.Copy()
+		src.current_run = all_uis.Copy()
 	// Cache for sanic speed (lists are references anyways)
 	var/list/current_run = src.current_run
 	while(current_run.len)
@@ -74,7 +72,7 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 		if(ui?.user && ui.src_object)
 			ui.process(wait * 0.1)
 		else
-			open_uis.Remove(ui)
+			ui.close(0)
 		if(MC_TICK_CHECK)
 			return

@@ -193,11 +191,9 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 * return datum/tgui The found UI.
 */
 /datum/controller/subsystem/processing/tgui/proc/get_open_ui(mob/user, datum/src_object)
-	var/key = text_ref(src_object)
-	// No UIs opened for this src_object
-	if(isnull(open_uis_by_src[key]) || !istype(open_uis_by_src[key], /list))
+	if(!LAZYLEN(src_object?.open_uis))
 		return null
-	for(var/datum/tgui/ui in open_uis_by_src[key])
+	for(var/datum/tgui/ui in src_object.open_uis)
 		// Make sure we have the right user
 		if(ui.user == user)
 			return ui
@@ -213,15 +209,13 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 * return int The number of UIs updated.
 */
 /datum/controller/subsystem/processing/tgui/proc/update_uis(datum/src_object)
+	if(!LAZYLEN(src_object?.open_uis))
+		return 0
 	var/count = 0
-	var/key = text_ref(src_object)
-	// No UIs opened for this src_object
-	if(isnull(open_uis_by_src[key]) || !istype(open_uis_by_src[key], /list))
-		return count
-	for(var/datum/tgui/ui in open_uis_by_src[key])
+	for(var/datum/tgui/ui in src_object.open_uis)
 		// Check if UI is valid.
 		if(ui?.src_object && ui.user && ui.src_object.ui_host(ui.user))
-			ui.process(wait * 0.1, force = 1)
+			INVOKE_ASYNC(ui, TYPE_PROC_REF(/datum/tgui, process), wait * 0.1, TRUE)
 			count++
 	return count

@@ -235,12 +229,11 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 * return int The number of UIs closed.
 */
 /datum/controller/subsystem/processing/tgui/proc/close_uis(datum/src_object)
-	var/count = 0
-	var/key = text_ref(src_object)
 	// No UIs opened for this src_object
-	if(isnull(open_uis_by_src[key]) || !istype(open_uis_by_src[key], /list))
-		return count
-	for(var/datum/tgui/ui in open_uis_by_src[key])
+	if(!LAZYLEN(src_object?.open_uis))
+		return 0
+	var/count = 0
+	for(var/datum/tgui/ui in src_object.open_uis)
 		// Check if UI is valid.
 		if(ui?.src_object && ui.user && ui.src_object.ui_host(ui.user))
 			ui.close()
@@ -256,12 +249,11 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 */
 /datum/controller/subsystem/processing/tgui/proc/close_all_uis()
 	var/count = 0
-	for(var/key in open_uis_by_src)
-		for(var/datum/tgui/ui in open_uis_by_src[key])
-			// Check if UI is valid.
-			if(ui?.src_object && ui.user && ui.src_object.ui_host(ui.user))
-				ui.close()
-				count++
+	for(var/datum/tgui/ui in all_uis)
+		// Check if UI is valid.
+		if(ui?.src_object && ui.user && ui.src_object.ui_host(ui.user))
+			ui.close()
+			count++
 	return count

 /**
@@ -312,13 +304,9 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 * required ui datum/tgui The UI to be added.
 */
 /datum/controller/subsystem/processing/tgui/proc/on_open(datum/tgui/ui)
-	var/key = text_ref(ui.src_object)
-	if(isnull(open_uis_by_src[key]) || !istype(open_uis_by_src[key], /list))
-		open_uis_by_src[key] = list()
-	ui.user.tgui_open_uis |= ui
-	var/list/uis = open_uis_by_src[key]
-	uis |= ui
-	open_uis |= ui
+	ui.user?.tgui_open_uis |= ui
+	LAZYOR(ui.src_object.open_uis, ui)
+	all_uis |= ui

 /**
 * private
@@ -330,19 +318,14 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 * return bool If the UI was removed or not.
 */
 /datum/controller/subsystem/processing/tgui/proc/on_close(datum/tgui/ui)
-	var/key = text_ref(ui.src_object)
-	if(isnull(open_uis_by_src[key]) || !istype(open_uis_by_src[key], /list))
-		return FALSE
 	// Remove it from the list of processing UIs.
-	open_uis.Remove(ui)
+	all_uis -= ui
+	current_run -= ui
 	// If the user exists, remove it from them too.
 	if(ui.user)
-		ui.user.tgui_open_uis.Remove(ui)
-		ui.user.unset_machine()
-	var/list/uis = open_uis_by_src[key]
-	uis.Remove(ui)
-	if(length(uis) == 0)
-		open_uis_by_src.Remove(key)
+		ui.user.tgui_open_uis -= ui
+	if(ui.src_object)
+		LAZYREMOVE(ui.src_object.open_uis, ui)
 	return TRUE

 /**
@@ -377,7 +360,7 @@ PROCESSING_SUBSYSTEM_DEF(tgui)
 	for(var/datum/tgui/ui in source.tgui_open_uis)
 		// Inform the UIs of their new owner.
 		ui.user = target
-		target.tgui_open_uis.Add(ui)
+		target.tgui_open_uis += ui
 	// Clear the old list.
 	source.tgui_open_uis.Cut()
 	return TRUE