Rogue process() calls in atmos machinery (#2840)

Fixes #2801 and renames a few more missing procs.

code/ATMOSPHERICS/components/binary_devices/pipeturbine.dm

@@ -50,7 +50,7 @@
 
 		return ..()
 
-	process()
+	machinery_process()
 		..()
 		if(anchored && !(stat&BROKEN))
 			kin_energy *= 1 - kin_loss
@@ -246,7 +246,7 @@
 			if (turbine.stat & (BROKEN) || !turbine.anchored || turn(turbine.dir,180) != dir)
 				turbine = null
 
-	process()
+	machinery_process()
 		updateConnection()
 		if(!turbine || !anchored || stat & (BROKEN))
 			return

code/ATMOSPHERICS/components/unary/heat_exchanger.dm

@@ -30,7 +30,7 @@
 
 		..()
 
-	process()
+	machinery_process()
 		..()
 		if(QDELETED(partner))
 			return 0

code/ATMOSPHERICS/components/unary/oxygen_generator.dm

@@ -28,7 +28,7 @@ obj/machinery/atmospherics/unary/oxygen_generator
 
 		air_contents.volume = 50
 
-	process()
+	machinery_process()
 		..()
 		if(!on)
 			return 0
@@ -46,4 +46,4 @@ obj/machinery/atmospherics/unary/oxygen_generator
 			if(network)
 				network.update = 1
 
-		return 1
+		return 1

code/ATMOSPHERICS/components/unary/thermal_plate.dm

@@ -18,7 +18,7 @@
 			icon_state = "exposed"
 		return
 
-	process()
+	machinery_process()
 		..()
 
 		var/datum/gas_mixture/environment = loc.return_air()
@@ -78,4 +78,4 @@
 		if (network)
 			network.update = 1
 
-		return 1
+		return 1

code/ATMOSPHERICS/he_pipes.dm

@@ -1,5 +1,4 @@
-
-obj/machinery/atmospherics/pipe/simple/heat_exchanging
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging
 	icon = 'icons/atmos/heat.dmi'
 	icon_state = "intact"
 	pipe_icon = "hepipe"
@@ -17,94 +16,93 @@ obj/machinery/atmospherics/pipe/simple/heat_exchanging
 	buckle_lying = 1
 
 	// BubbleWrap
-	New()
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging/New()
 		..()
 		initialize_directions_he = initialize_directions	// The auto-detection from /pipe is good enough for a simple HE pipe
 	// BubbleWrap END
 		color = "#404040" //we don't make use of the fancy overlay system for colours, use this to set the default.
 
-	atmos_init()
-		normalize_dir()
-		var/node1_dir
-		var/node2_dir
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging/atmos_init()
+	normalize_dir()
+	var/node1_dir
+	var/node2_dir
 
-		for(var/direction in cardinal)
-			if(direction&initialize_directions_he)
-				if (!node1_dir)
-					node1_dir = direction
-				else if (!node2_dir)
-					node2_dir = direction
+	for(var/direction in cardinal)
+		if(direction&initialize_directions_he)
+			if (!node1_dir)
+				node1_dir = direction
+			else if (!node2_dir)
+				node2_dir = direction
 
-		for(var/obj/machinery/atmospherics/pipe/simple/heat_exchanging/target in get_step(src,node1_dir))
-			if(target.initialize_directions_he & get_dir(target,src))
-				node1 = target
-				break
-		for(var/obj/machinery/atmospherics/pipe/simple/heat_exchanging/target in get_step(src,node2_dir))
-			if(target.initialize_directions_he & get_dir(target,src))
-				node2 = target
-				break
-		if(!node1 && !node2)
-			qdel(src)
-			return
-
-		update_icon()
+	for(var/obj/machinery/atmospherics/pipe/simple/heat_exchanging/target in get_step(src,node1_dir))
+		if(target.initialize_directions_he & get_dir(target,src))
+			node1 = target
+			break
+	for(var/obj/machinery/atmospherics/pipe/simple/heat_exchanging/target in get_step(src,node2_dir))
+		if(target.initialize_directions_he & get_dir(target,src))
+			node2 = target
+			break
+	if(!node1 && !node2)
+		qdel(src)
 		return
 
+	update_icon()
+	return
 
-	process()
-		if(!parent)
-			..()
-		else
-			var/datum/gas_mixture/pipe_air = return_air()
-			if(istype(loc, /turf/simulated/))
-				var/environment_temperature = 0
-				if(loc:blocks_air)
-					environment_temperature = loc:temperature
-				else
-					var/datum/gas_mixture/environment = loc.return_air()
-					environment_temperature = environment.temperature
-				if(abs(environment_temperature-pipe_air.temperature) > minimum_temperature_difference)
-					parent.temperature_interact(loc, volume, thermal_conductivity)
-			else if(istype(loc, /turf/space/))
-				parent.radiate_heat_to_space(surface, 1)
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging/machinery_process()
+	if(!parent)
+		..()
+	else
+		var/datum/gas_mixture/pipe_air = return_air()
+		if(istype(loc, /turf/simulated/))
+			var/environment_temperature = 0
+			if(loc:blocks_air)
+				environment_temperature = loc:temperature
+			else
+				var/datum/gas_mixture/environment = loc.return_air()
+				environment_temperature = environment.temperature
+			if(abs(environment_temperature-pipe_air.temperature) > minimum_temperature_difference)
+				parent.temperature_interact(loc, volume, thermal_conductivity)
+		else if(istype(loc, /turf/space/))
+			parent.radiate_heat_to_space(surface, 1)
 
-			if(buckled_mob)
-				var/hc = pipe_air.heat_capacity()
-				var/avg_temp = (pipe_air.temperature * hc + buckled_mob.bodytemperature * 3500) / (hc + 3500)
-				pipe_air.temperature = avg_temp
-				buckled_mob.bodytemperature = avg_temp
+		if(buckled_mob)
+			var/hc = pipe_air.heat_capacity()
+			var/avg_temp = (pipe_air.temperature * hc + buckled_mob.bodytemperature * 3500) / (hc + 3500)
+			pipe_air.temperature = avg_temp
+			buckled_mob.bodytemperature = avg_temp
 
-				var/heat_limit = 1000
+			var/heat_limit = 1000
 
-				var/mob/living/carbon/human/H = buckled_mob
-				if(istype(H) && H.species)
-					heat_limit = H.species.heat_level_3
+			var/mob/living/carbon/human/H = buckled_mob
+			if(istype(H) && H.species)
+				heat_limit = H.species.heat_level_3
 
-				if(pipe_air.temperature > heat_limit + 1)
-					buckled_mob.apply_damage(4 * log(pipe_air.temperature - heat_limit), BURN, "chest", used_weapon = "Excessive Heat")
+			if(pipe_air.temperature > heat_limit + 1)
+				buckled_mob.apply_damage(4 * log(pipe_air.temperature - heat_limit), BURN, "chest", used_weapon = "Excessive Heat")
 
-			//fancy radiation glowing
-			if(pipe_air.temperature && (icon_temperature > 500 || pipe_air.temperature > 500)) //start glowing at 500K
-				if(abs(pipe_air.temperature - icon_temperature) > 10)
-					icon_temperature = pipe_air.temperature
+		//fancy radiation glowing
+		if(pipe_air.temperature && (icon_temperature > 500 || pipe_air.temperature > 500)) //start glowing at 500K
+			if(abs(pipe_air.temperature - icon_temperature) > 10)
+				icon_temperature = pipe_air.temperature
 
-					var/h_r = heat2color_r(icon_temperature)
-					var/h_g = heat2color_g(icon_temperature)
-					var/h_b = heat2color_b(icon_temperature)
+				var/h_r = heat2color_r(icon_temperature)
+				var/h_g = heat2color_g(icon_temperature)
+				var/h_b = heat2color_b(icon_temperature)
 
-					if(icon_temperature < 2000) //scale up overlay until 2000K
-						var/scale = (icon_temperature - 500) / 1500
-						h_r = 64 + (h_r - 64)*scale
-						h_g = 64 + (h_g - 64)*scale
-						h_b = 64 + (h_b - 64)*scale
+				if(icon_temperature < 2000) //scale up overlay until 2000K
+					var/scale = (icon_temperature - 500) / 1500
+					h_r = 64 + (h_r - 64)*scale
+					h_g = 64 + (h_g - 64)*scale
+					h_b = 64 + (h_b - 64)*scale
 
-					var/list/animate_targets = get_above_oo() + src
-					for (var/thing in animate_targets)
-						var/atom/movable/AM = thing
-						animate(AM, color = rgb(h_r, h_g, h_b), time = 20, easing = SINE_EASING)
+				var/list/animate_targets = get_above_oo() + src
+				for (var/thing in animate_targets)
+					var/atom/movable/AM = thing
+					animate(AM, color = rgb(h_r, h_g, h_b), time = 20, easing = SINE_EASING)
 
 
-obj/machinery/atmospherics/pipe/simple/heat_exchanging/junction
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging/junction
 	icon = 'icons/atmos/junction.dmi'
 	icon_state = "intact"
 	pipe_icon = "hejunction"
@@ -114,36 +112,36 @@ obj/machinery/atmospherics/pipe/simple/heat_exchanging/junction
 	thermal_conductivity = WALL_HEAT_TRANSFER_COEFFICIENT
 
 	// BubbleWrap
-	New()
-		.. ()
-		switch ( dir )
-			if ( SOUTH )
-				initialize_directions = NORTH
-				initialize_directions_he = SOUTH
-			if ( NORTH )
-				initialize_directions = SOUTH
-				initialize_directions_he = NORTH
-			if ( EAST )
-				initialize_directions = WEST
-				initialize_directions_he = EAST
-			if ( WEST )
-				initialize_directions = EAST
-				initialize_directions_he = WEST
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging/junction/New()
+	.. ()
+	switch ( dir )
+		if ( SOUTH )
+			initialize_directions = NORTH
+			initialize_directions_he = SOUTH
+		if ( NORTH )
+			initialize_directions = SOUTH
+			initialize_directions_he = NORTH
+		if ( EAST )
+			initialize_directions = WEST
+			initialize_directions_he = EAST
+		if ( WEST )
+			initialize_directions = EAST
+			initialize_directions_he = WEST
 	// BubbleWrap END
 
-	atmos_init()
-		for(var/obj/machinery/atmospherics/target in get_step(src,initialize_directions))
-			if(target.initialize_directions & get_dir(target,src))
-				node1 = target
-				break
-		for(var/obj/machinery/atmospherics/pipe/simple/heat_exchanging/target in get_step(src,initialize_directions_he))
-			if(target.initialize_directions_he & get_dir(target,src))
-				node2 = target
-				break
+/obj/machinery/atmospherics/pipe/simple/heat_exchanging/junction/atmos_init()
+	for(var/obj/machinery/atmospherics/target in get_step(src,initialize_directions))
+		if(target.initialize_directions & get_dir(target,src))
+			node1 = target
+			break
+	for(var/obj/machinery/atmospherics/pipe/simple/heat_exchanging/target in get_step(src,initialize_directions_he))
+		if(target.initialize_directions_he & get_dir(target,src))
+			node2 = target
+			break
 
-		if(!node1&&!node2)
-			qdel(src)
-			return
-
-		update_icon()
+	if(!node1&&!node2)
+		qdel(src)
 		return
+
+	update_icon()
+	return