Text() away (#19850)

Refactored all the builtin text procs to use string interpolation
instead.
Added a linting for the above.

This is based on, and should only be merged after, #19847
This commit is contained in:
Fluffy
2024-09-21 12:46:31 +00:00
committed by GitHub
parent 1aeeb6827d
commit 8f9de7c3e2
76 changed files with 351 additions and 264 deletions
+2 -2
View File
@@ -517,7 +517,7 @@ var/list/ai_verbs_default = list(
if (href_list["mach_close"])
if (href_list["mach_close"] == "aialerts")
view_alerts = 0
var/t1 = text("window=[]", href_list["mach_close"])
var/t1 = "window=[href_list["mach_close"]]"
unset_machine()
src << browse(null, t1)
if (href_list["switchcamera"])
@@ -546,7 +546,7 @@ var/list/ai_verbs_default = list(
to_chat(src, SPAN_NOTICE("Unable to locate visual entry."))
return
var/info = cameraRecords[entry]
src << browse(text("<HTML><HEAD><TITLE>[]</TITLE></HEAD><BODY><TT>[]</TT></BODY></HTML>", info[1], info[2]), text("window=[]", html_encode(info[1])))
src << browse("<HTML><HEAD><TITLE>[info[1]]</TITLE></HEAD><BODY><TT>[info[2]]</TT></BODY></HTML>", "window=[html_encode(info[1])]")
return
return
@@ -197,11 +197,11 @@
for(var/O in module.modules)
var/module_string = ""
if(!O)
module_string += text("<B>Resource depleted</B><BR>")
module_string +="<B>Resource depleted</B><BR>"
else if(activated(O))
module_string += text("[O]: <B>Activated</B><BR>")
module_string += "[O]: <B>Activated</B><BR>"
else
module_string += text("[O]: <A HREF=?src=[REF(src)];act=[REF(O)]>Activate</A><BR>")
module_string += "[O]: <A HREF=?src=[REF(src)];act=[REF(O)]>Activate</A><BR>"
var/obj/item/I = O
if((istype(I, /obj/item) || istype(I, /obj/item/device)) && !(I.iscoil()))
@@ -213,11 +213,11 @@
if(emagged)
if(!module.emag)
dat += text("<B>Resource depleted</B><BR>")
dat += "<B>Resource depleted</B><BR>"
else if(activated(module.emag))
dat += text("[module.emag]: <B>Activated</B><BR>")
dat += "[module.emag]: <B>Activated</B><BR>"
else
dat += text("[module.emag]: <A HREF=?src=[REF(src)];act=[REF(module.emag)]>Activate</A><BR>")
dat += "[module.emag]: <A HREF=?src=[REF(src)];act=[REF(module.emag)]>Activate</A><BR>"
dat += resources
@@ -878,21 +878,21 @@
for(var/obj in module.modules)
if(!obj)
dat += text("<B>Resource depleted</B><BR>")
dat += "<B>Resource depleted</B><BR>"
else if(activated(obj))
dat += text("[obj]: <B>Activated</B><BR>")
dat += "[obj]: <B>Activated</B><BR>"
else
dat += text("[obj]: <A HREF=?src=[REF(src)];act=[REF(obj)]>Activate</A><BR>")
dat += "[obj]: <A HREF=?src=[REF(src)];act=[REF(obj)]>Activate</A><BR>"
if(emagged)
if(activated(module.emag))
dat += text("[module.emag]: <B>Activated</B><BR>")
dat += "[module.emag]: <B>Activated</B><BR>"
else
dat += text("[module.emag]: <A HREF=?src=[REF(src)];act=[REF(module.emag)]>Activate</A><BR>")
dat += "[module.emag]: <A HREF=?src=[REF(src)];act=[REF(module.emag)]>Activate</A><BR>"
if(malf_AI_module)
if(activated(module.malf_AI_module))
dat += text("[module.malf_AI_module]: <B>Activated</B><BR>")
dat += "[module.malf_AI_module]: <B>Activated</B><BR>"
else
dat += text("[module.malf_AI_module]: <A HREF=?src=[REF(src)];act=[REF(module.malf_AI_module)]>Activate</A><BR>")
dat += "[module.malf_AI_module]: <A HREF=?src=[REF(src)];act=[REF(module.malf_AI_module)]>Activate</A><BR>"
src << browse(dat, "window=robotmod")