From 947730bedebfb36d8095a766cd39495da48567d6 Mon Sep 17 00:00:00 2001 From: VMSolidus Date: Mon, 24 Nov 2025 09:03:57 -0500 Subject: [PATCH] Effects Hard Delete Fix (#21619) This fixes a hard delete sometimes caused by Effects. --- code/game/objects/effects/effect_system.dm | 3 +-- html/changelogs/hellfirejag-effects-hard-del.yml | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 html/changelogs/hellfirejag-effects-hard-del.yml diff --git a/code/game/objects/effects/effect_system.dm b/code/game/objects/effects/effect_system.dm index b764bc8b382..751f1ed62a0 100644 --- a/code/game/objects/effects/effect_system.dm +++ b/code/game/objects/effects/effect_system.dm @@ -15,8 +15,7 @@ would spawn and follow the beaker, even if it is carried or thrown. blocks_emissive = EMISSIVE_BLOCK_GENERIC /obj/effect/Destroy() - if(reagents) - reagents.delete() + QDEL_NULL(reagents) return ..() /datum/effect/effect/system diff --git a/html/changelogs/hellfirejag-effects-hard-del.yml b/html/changelogs/hellfirejag-effects-hard-del.yml new file mode 100644 index 00000000000..b5bececda13 --- /dev/null +++ b/html/changelogs/hellfirejag-effects-hard-del.yml @@ -0,0 +1,4 @@ +author: Hellfirejag +delete-after: True +changes: + - bugfix: "Fixed a lag inducing hard delete caused by Effects."