From 9af261ef8891b1a88842e319063046dcf7b3f813 Mon Sep 17 00:00:00 2001 From: mikomyazaki <47489928+mikomyazaki@users.noreply.github.com> Date: Mon, 26 Oct 2020 12:32:42 +0000 Subject: [PATCH] Changes footsteps to use client timers, hopefully this will make them delete themselves consistently. (#10340) --- code/modules/vision_cone/vision_cone.dm | 2 +- html/changelogs/client_time_footsteps.yml | 41 +++++++++++++++++++++++ 2 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/client_time_footsteps.yml diff --git a/code/modules/vision_cone/vision_cone.dm b/code/modules/vision_cone/vision_cone.dm index 90a51b75f35..9e324a84964 100644 --- a/code/modules/vision_cone/vision_cone.dm +++ b/code/modules/vision_cone/vision_cone.dm @@ -210,7 +210,7 @@ marker.filters += filter(type = "ripple", x=rand(-RIPPLE_POSITION_BOUNDS, RIPPLE_POSITION_BOUNDS), y=rand(-RIPPLE_POSITION_BOUNDS, RIPPLE_POSITION_BOUNDS), radius = RIPPLE_START_RADIUS, size = RIPPLE_START_SIZE, falloff = 0) viewer.client.images += marker - QDEL_IN(marker, 1.5 SECONDS) + addtimer(CALLBACK(GLOBAL_PROC, .proc/qdel, marker), 1.5 SECONDS, TIMER_CLIENT_TIME) animate(marker.filters[marker.filters.len], time = 1.5 SECONDS, radius = RIPPLE_END_RADIUS, size = RIPPLE_END_SIZE) #undef ALWAYS_FOOTSTEP_DISTANCE diff --git a/html/changelogs/client_time_footsteps.yml b/html/changelogs/client_time_footsteps.yml new file mode 100644 index 00000000000..8b3d6595034 --- /dev/null +++ b/html/changelogs/client_time_footsteps.yml @@ -0,0 +1,41 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# wip (For works in progress) +# tweak +# soundadd +# sounddel +# rscadd (general adding of nice things) +# rscdel (general deleting of nice things) +# imageadd +# imagedel +# maptweak +# spellcheck (typo fixes) +# experiment +# balance +# admin +# backend +# security +# refactor +################################# + +# Your name. +author: mikomyazaki + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, all entries are changed into a single [] after a master changelog generation. Just remove the brackets when you add new entries. +# Please surround your changes in double quotes ("), as certain characters otherwise screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Footstep animations from vision cones should now remove themselves a bit more promptly." \ No newline at end of file