From 9f84a4148c7f950596db8b7d224f1f869e35d5b1 Mon Sep 17 00:00:00 2001 From: hazelrat <83198434+hazelrat@users.noreply.github.com> Date: Sun, 22 Jun 2025 19:09:17 +0100 Subject: [PATCH] Allows Storytellers to go freely between z-levels (#20806) As title. Previously they were bound to only being able to move up or down in microgravity, like a regular mob. This is just using a proc copied straight from ghost/observer, there's probably a more elegant solution - I'm curious if there would be any negative implications to just giving everything under /ghost this behaviour. --- code/modules/multiz/movement.dm | 3 +- html/changelogs/hazelmouse-stmovement.yml | 58 +++++++++++++++++++++++ 2 files changed, 60 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/hazelmouse-stmovement.yml diff --git a/code/modules/multiz/movement.dm b/code/modules/multiz/movement.dm index ed7baa28984..ff0dcac7dc9 100644 --- a/code/modules/multiz/movement.dm +++ b/code/modules/multiz/movement.dm @@ -112,7 +112,8 @@ else to_chat(owner, SPAN_NOTICE("There is nothing of interest in this direction.")) -/mob/abstract/ghost/observer/zMove(direction) +// Both observers and storytellers depend on this to be able to move through z-levels freely! +/mob/abstract/ghost/zMove(direction) var/turf/T = get_turf(src) var/turf/destination = (direction == UP) ? GET_TURF_ABOVE(T) : GET_TURF_BELOW(T) if(destination) diff --git a/html/changelogs/hazelmouse-stmovement.yml b/html/changelogs/hazelmouse-stmovement.yml new file mode 100644 index 00000000000..95608648b19 --- /dev/null +++ b/html/changelogs/hazelmouse-stmovement.yml @@ -0,0 +1,58 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: hazelmouse + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - rscadd: "Storytellers can now move freely between z-levels, similarly to an observer."