Fix Improper Destroys (#22166)

We think the culprit behind this one was VSCode autofilling Destroy()
with . = ..()
which is improper. There's a **surprising** number of improper order
Destroy() procs in the repo, so I might as well get all of them in one
pass. Several of these files are associated with currently known hard
dels, such as the modular computer and organ related dels. More than a
couple were my own mistakes, since the Destroy() or Removed() . = ..()
behavior on signal registering objects also prevents the signal from
being unregistered, which similarly creates a hard del.

Signed-off-by: VMSolidus <evilexecutive@gmail.com>
This commit is contained in:
VMSolidus
2026-04-08 11:52:13 -04:00
committed by GitHub
parent 5cce3fe664
commit a290281d14
37 changed files with 52 additions and 48 deletions
@@ -23,7 +23,7 @@
set_icon()
/obj/item/modular_computer/handheld/Destroy()
. = ..()
return ..()
/obj/item/modular_computer/handheld/proc/set_icon()
icon_state_unpowered = icon_state
@@ -4,7 +4,7 @@
icon_state = "laptop-closed"
/obj/item/modular_computer/laptop/preset/Destroy()
. = ..()
return ..()
/obj/item/modular_computer/laptop/preset/install_default_hardware()
..()
@@ -1,5 +1,5 @@
/obj/item/modular_computer/telescreen/preset/Destroy()
. = ..()
return ..()
/obj/item/modular_computer/telescreen/preset/install_default_hardware()
..()