From a9796a01e6b11a817173cd44c7ab388191dd01af Mon Sep 17 00:00:00 2001 From: Cody Brittain <1779662+Generalcamo@users.noreply.github.com> Date: Mon, 11 May 2026 14:12:54 -0400 Subject: [PATCH] Resolve a runtime related to TGUI alert modals being deleted (#22443) Caught by sentry, was an easy fix though as lists already handle this correctly. Co-authored-by: GeneralCamo --- code/modules/tgui_input/alert.dm | 2 +- .../GeneralCamo - Fix TGUI Alert Crash.yml | 58 +++++++++++++++++++ 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 html/changelogs/GeneralCamo - Fix TGUI Alert Crash.yml diff --git a/code/modules/tgui_input/alert.dm b/code/modules/tgui_input/alert.dm index 9eb256a817c..469cd7831b1 100644 --- a/code/modules/tgui_input/alert.dm +++ b/code/modules/tgui_input/alert.dm @@ -72,7 +72,7 @@ /datum/tgui_alert/Destroy(force, ...) SStgui.close_uis(src) - QDEL_LIST(buttons) + buttons?.Cut() return ..() /** diff --git a/html/changelogs/GeneralCamo - Fix TGUI Alert Crash.yml b/html/changelogs/GeneralCamo - Fix TGUI Alert Crash.yml new file mode 100644 index 00000000000..f47ddddd4e6 --- /dev/null +++ b/html/changelogs/GeneralCamo - Fix TGUI Alert Crash.yml @@ -0,0 +1,58 @@ +################################ +# Example Changelog File +# +# Note: This file, and files beginning with ".", and files that don't end in ".yml" will not be read. If you change this file, you will look really dumb. +# +# Your changelog will be merged with a master changelog. (New stuff added only, and only on the date entry for the day it was merged.) +# When it is, any changes listed below will disappear. +# +# Valid Prefixes: +# bugfix +# - (fixes bugs) +# wip +# - (work in progress) +# qol +# - (quality of life) +# soundadd +# - (adds a sound) +# sounddel +# - (removes a sound) +# rscadd +# - (adds a feature) +# rscdel +# - (removes a feature) +# imageadd +# - (adds an image or sprite) +# imagedel +# - (removes an image or sprite) +# spellcheck +# - (fixes spelling or grammar) +# experiment +# - (experimental change) +# balance +# - (balance changes) +# code_imp +# - (misc internal code change) +# refactor +# - (refactors code) +# config +# - (makes a change to the config files) +# admin +# - (makes changes to administrator tools) +# server +# - (miscellaneous changes to server) +################################# + +# Your name. +author: GeneralCamo + +# Optional: Remove this file after generating master changelog. Useful for PR changelogs that won't get used again. +delete-after: True + +# Any changes you've made. See valid prefix list above. +# INDENT WITH TWO SPACES. NOT TABS. SPACES. +# SCREW THIS UP AND IT WON'T WORK. +# Also, this gets changed to [] after reading. Just remove the brackets when you add new shit. +# Please surround your changes in double quotes ("). It works without them, but if you use certain characters it screws up compiling. The quotes will not show up in the changelog. +changes: + - bugfix: "Resolve a runtime related to TGUI alert modals being deleted."