From ab4bc6a847f9db78e303c0a3ac22903b791340cb Mon Sep 17 00:00:00 2001 From: VisVirific Date: Sat, 30 Apr 2022 17:37:28 -0300 Subject: [PATCH] dropper reagent filling overlay bugfix (#13709) --- code/modules/reagents/reagent_containers/dropper.dm | 3 +-- html/changelogs/dropper_reagent_filling_overlay.yml | 6 ++++++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 html/changelogs/dropper_reagent_filling_overlay.yml diff --git a/code/modules/reagents/reagent_containers/dropper.dm b/code/modules/reagents/reagent_containers/dropper.dm index b81cc3b8ef3..f1b9eaa9bdb 100644 --- a/code/modules/reagents/reagent_containers/dropper.dm +++ b/code/modules/reagents/reagent_containers/dropper.dm @@ -77,7 +77,6 @@ to_chat(user, "You transfer [trans] units of the solution.") else // Taking from something - if(!target.is_open_container() && !istype(target,/obj/structure/reagent_dispensers)) to_chat(user, "You cannot directly remove reagents from [target].") return @@ -94,7 +93,7 @@ /obj/item/reagent_containers/dropper/update_icon() cut_overlays() - if(reagents) + if(reagents.total_volume) add_overlay(overlay_image('icons/obj/reagentfillings.dmi', "[icon_state]", color = reagents.get_color())) worn_overlay_color = reagents.get_color() // handles inhands update_held_icon() diff --git a/html/changelogs/dropper_reagent_filling_overlay.yml b/html/changelogs/dropper_reagent_filling_overlay.yml new file mode 100644 index 00000000000..95963da6b06 --- /dev/null +++ b/html/changelogs/dropper_reagent_filling_overlay.yml @@ -0,0 +1,6 @@ +author: Vrow + +delete-after: True + +changes: + - bugfix: "Fixed the Dropper's reagent filling overlay not clearing correctly."