From b14eed0efb3c386348907cb577f49e869bd03ebf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ji=C5=99=C3=AD=20Barou=C5=A1?=
 <Amunak@users.noreply.github.com>
Date: Mon, 26 Oct 2020 08:30:54 +0100
Subject: [PATCH] All atoms changing opacity will recalculate visibility
 (#10352)

---
 code/modules/lighting/__lighting_docs.dm      |  2 +-
 code/modules/lighting/lighting_atom.dm        |  9 +++++----
 .../mob/abstract/freelook/update_triggers.dm  | 19 ++++---------------
 code/modules/mob/mob.dm                       |  2 +-
 html/changelogs/amunak-visibility-fix.yml     |  4 ++++
 5 files changed, 15 insertions(+), 21 deletions(-)
 create mode 100755 html/changelogs/amunak-visibility-fix.yml

diff --git a/code/modules/lighting/__lighting_docs.dm b/code/modules/lighting/__lighting_docs.dm
index 2d1e8e00dea..03214872b1f 100644
--- a/code/modules/lighting/__lighting_docs.dm
+++ b/code/modules/lighting/__lighting_docs.dm
@@ -27,7 +27,7 @@
     no_update -> if TRUE, the light will not be updated. Useful for when making several of these calls to the same object. Optional.
 
 /atom/proc/set_opacity(new_opacity)
-  desc: Sets an atom's opacity, updating affecting lights' visibility.
+  desc: Sets an atom's opacity, updating affecting lights' visibility. Returns TRUE if opacity changed, FALSE otherwise.
   args:
     new_opacity -> the new opacity value.
 
diff --git a/code/modules/lighting/lighting_atom.dm b/code/modules/lighting/lighting_atom.dm
index 8819aac5758..35c9611e0d1 100644
--- a/code/modules/lighting/lighting_atom.dm
+++ b/code/modules/lighting/lighting_atom.dm
@@ -79,7 +79,7 @@
 			light = new/datum/light_source/sunlight(src, .)
 		else
 			light = new/datum/light_source(src, .)
-#else 
+#else
 		if (light)
 			light.update(.)
 		else
@@ -91,7 +91,7 @@
 	var/turf/T = loc
 
 	. = ..()
-	
+
 	if (opacity && istype(T))
 		T.recalc_atom_opacity()
 		T.reconsider_lights()
@@ -101,14 +101,14 @@
 // It notifies (potentially) affected light sources so they can update (if needed).
 /atom/proc/set_opacity(var/new_opacity)
 	if (new_opacity == opacity)
-		return
+		return FALSE
 
 	//L_PROF(src, "atom_setopacity")
 
 	opacity = new_opacity
 	var/turf/T = loc
 	if (!isturf(T))
-		return
+		return FALSE
 
 	if (new_opacity == TRUE)
 		T.has_opaque_atom = TRUE
@@ -121,6 +121,7 @@
 		T.recalc_atom_opacity()
 		if (old_has_opaque_atom != T.has_opaque_atom)
 			T.reconsider_lights()
+	return TRUE
 
 /atom/movable/forceMove()
 	. = ..()
diff --git a/code/modules/mob/abstract/freelook/update_triggers.dm b/code/modules/mob/abstract/freelook/update_triggers.dm
index 0c3dda3a858..fa3ba6ad0c7 100644
--- a/code/modules/mob/abstract/freelook/update_triggers.dm
+++ b/code/modules/mob/abstract/freelook/update_triggers.dm
@@ -1,20 +1,19 @@
 //UPDATE TRIGGERS, when the chunk (and the surrounding chunks) should update.
 
-// TURFS
-
 /proc/updateVisibility(atom/A, var/opacity_check = TRUE)
 	if(SSticker)
 		for(var/datum/visualnet/VN in visual_nets)
 			VN.update_visibility(A, opacity_check)
 
-/turf/drain_power()
-	return -1
-
 /atom/Destroy()
 	if(opacity)
 		updateVisibility(src)
 	. = ..()
 
+/atom/set_opacity()
+	. = ..()
+	if(.)
+		updateVisibility(src, FALSE)
 
 /atom/movable/Move()
 	. = ..()
@@ -26,16 +25,6 @@
 	if(opacity && .)
 		updateVisibility(src)
 
-// DOORS
-
-// Simply updates the visibility of the area when it opens/closes/destroyed.
-/obj/machinery/door/update_nearby_tiles(need_rebuild)
-	. = ..(need_rebuild)
-	// Glass door glass = 1
-	// don't check then?
-	if(!glass)
-		updateVisibility(src, FALSE)
-
 /turf/ChangeTurf()
 	. = ..()
 	if(.)
diff --git a/code/modules/mob/mob.dm b/code/modules/mob/mob.dm
index a6324af93a3..71f2d40d9e7 100644
--- a/code/modules/mob/mob.dm
+++ b/code/modules/mob/mob.dm
@@ -166,7 +166,7 @@
 // If drain_check is set it will not actually drain power, just return a value.
 // If surge is set, it will destroy/damage the recipient and not return any power.
 // Not sure where to define this, so it can sit here for the rest of time.
-/atom/proc/drain_power(var/drain_check,var/surge, var/amount = 0)
+/atom/proc/drain_power(var/drain_check, var/surge, var/amount = 0)
 	return -1
 
 // Show a message to all mobs and objects in earshot of this one
diff --git a/html/changelogs/amunak-visibility-fix.yml b/html/changelogs/amunak-visibility-fix.yml
new file mode 100755
index 00000000000..b93d9a49c9d
--- /dev/null
+++ b/html/changelogs/amunak-visibility-fix.yml
@@ -0,0 +1,4 @@
+author: Amunak
+delete-after: True
+changes:
+  - bugfix: "All opacity changes (like when you toggle tinted windows) should now trigger camera visibility update (so that the AI can't spy through tinted windows until something else triggers the update)."