Updates subsystem definitions to new standards. (#17470)

* My heart is dragging me down into...

...oblivion!

* drifting closer to the edge but she won't have me

* ever round me we are dead before we meet her

* for the last time

* wake up in sweat

* n

* fff

* uff

---------

Co-authored-by: Matt Atlas <liermattia@gmail.com>
This commit is contained in:
Matt Atlas
2023-10-01 14:24:40 +00:00
committed by GitHub
co-authored by Matt Atlas
parent aff9d2a1f3
commit baeb7c6afd
127 changed files with 406 additions and 720 deletions
@@ -2,9 +2,7 @@
var/datum/map/current_map // Whatever map is currently loaded. Null until SSatlas Initialize() starts.
var/datum/controller/subsystem/atlas/SSatlas
/datum/controller/subsystem/atlas
SUBSYSTEM_DEF(atlas)
name = "Atlas"
flags = SS_NO_FIRE
init_order = SS_INIT_MAPLOAD
@@ -141,9 +139,6 @@ var/datum/controller/subsystem/atlas/SSatlas
msg = "W:{X:[world.maxx] Y:[world.maxy] Z:[world.maxz]} ZL:[z_levels]"
return ..()
/datum/controller/subsystem/atlas/New()
NEW_SS_GLOBAL(SSatlas)
/datum/controller/subsystem/atlas/Initialize(timeofday)
// Quick sanity check.
if (world.maxx != WORLD_MIN_SIZE || world.maxy != WORLD_MIN_SIZE || world.maxz != 1)
@@ -1,13 +1,11 @@
#define SUBSYSTEM_INIT_SOURCE "subsystem init"
var/datum/controller/subsystem/atoms/SSatoms
#define BAD_INIT_QDEL_BEFORE 1
#define BAD_INIT_DIDNT_INIT 2
#define BAD_INIT_SLEPT 4
#define BAD_INIT_NO_HINT 8
/datum/controller/subsystem/atoms
SUBSYSTEM_DEF(atoms)
name = "Atoms"
init_order = SS_INIT_ATOMS
flags = SS_NO_FIRE
@@ -28,9 +26,6 @@ var/datum/controller/subsystem/atoms/SSatoms
var/list/BadInitializeCalls = list()
/datum/controller/subsystem/atoms/New()
NEW_SS_GLOBAL(SSatoms)
/datum/controller/subsystem/atoms/Initialize(timeofday)
initialized = INITIALIZATION_INNEW_MAPLOAD
InitializeAtoms()
@@ -1,9 +1,7 @@
// Minimap generation system adapted from vorestation, adapted from /vg/.
// Seems to be much simpler/saner than /vg/'s implementation.
/var/datum/controller/subsystem/holomap/SSholomap
/datum/controller/subsystem/holomap
SUBSYSTEM_DEF(holomap)
name = "Holomap"
flags = SS_NO_FIRE
init_order = SS_INIT_HOLOMAP
@@ -12,9 +10,6 @@
var/list/extra_minimaps = list()
var/list/station_holomaps = list()
/datum/controller/subsystem/holomap/New()
NEW_SS_GLOBAL(SSholomap)
/datum/controller/subsystem/holomap/Initialize()
holo_minimaps.len = world.maxz
for (var/z in 1 to world.maxz)
@@ -1,6 +1,6 @@
// The area list is put together here, because some things need it early on. Turrets controls, for example.
/datum/controller/subsystem/finalize
SUBSYSTEM_DEF(finalize)
name = "Map Finalization"
flags = SS_NO_FIRE | SS_NO_DISPLAY
init_order = SS_INIT_MAPFINALIZE
@@ -1,7 +1,7 @@
// This is one of the first subsystems initialized by the MC.
// Stuff that should be loaded before everything else that isn't significant enough to get its own SS goes here.
/datum/controller/subsystem/misc_early
SUBSYSTEM_DEF(misc_early)
name = "Early Miscellaneous Init"
init_order = SS_INIT_MISC_FIRST
flags = SS_NO_FIRE | SS_NO_DISPLAY
@@ -1,6 +1,6 @@
// This subsystem loads later in the init process. Not last, but after most major things are done.
/datum/controller/subsystem/misc_late
SUBSYSTEM_DEF(misc_late)
name = "Late Miscellaneous Init"
init_order = SS_INIT_MISC
flags = SS_NO_FIRE | SS_NO_DISPLAY
@@ -1,6 +1,4 @@
/var/datum/controller/subsystem/persistent_configuration/SSpersist_config = null
/datum/controller/subsystem/persistent_configuration
SUBSYSTEM_DEF(persistent_configuration)
name = "Persistent Configuration"
init_order = SS_INIT_PERSISTENT_CONFIG
flags = SS_NO_FIRE
@@ -17,7 +15,7 @@
var/forced_awaymission = FALSE
/datum/controller/subsystem/persistent_configuration/Initialize(timeofday)
SSpersist_config = src
SSpersistent_configuration = src
load_from_file("data/persistent_config.json")
@@ -25,7 +23,7 @@
var/file = file2text(filename)
if (!file)
log_config("SSpersist_config: file [filename] not found, falling back to default values.")
log_config("SSpersistent_configuration: file [filename] not found, falling back to default values.")
return
var/list/decoded = null
@@ -1,12 +1,10 @@
var/datum/controller/subsystem/xenoarch/SSxenoarch
#define XENOARCH_SPAWN_CHANCE 0.5
#define DIGSITESIZE_LOWER 4
#define DIGSITESIZE_UPPER 12
#define ARTIFACTSPAWNNUM_LOWER 6
#define ARTIFACTSPAWNNUM_UPPER 12
/datum/controller/subsystem/xenoarch
SUBSYSTEM_DEF(xenoarch)
name = "Xenoarchaeology"
flags = SS_NO_FIRE
init_order = SS_INIT_XENOARCH
@@ -14,11 +12,8 @@ var/datum/controller/subsystem/xenoarch/SSxenoarch
var/list/artifact_spawning_turfs = list()
var/list/digsite_spawning_turfs = list()
/datum/controller/subsystem/xenoarch/New()
NEW_SS_GLOBAL(SSxenoarch)
/datum/controller/subsystem/xenoarch/Initialize(timeofday)
set background=1
set background = TRUE
//create digsites
for(var/turf/TIW in world)