From bd418cfd8de3c23acb0b73a3a14071f00dba6de9 Mon Sep 17 00:00:00 2001 From: harry Date: Thu, 27 Mar 2025 11:17:00 +0000 Subject: [PATCH] 516: fixes tgui-say, chat flickering and chat crashing on export (#20667) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit title chat crashing on export fixed by https://github.com/VOREStation/VOREStation/pull/16713, chat flickering is fixed by https://github.com/VOREStation/VOREStation/pull/16734, tgui say is https://github.com/Monkestation/Monkestation2.0/pull/2116 also cleaned up some more html uis without skeletons 👻 --------- Co-authored-by: harryob <55142896+harryob@users.noreply.github.com> --- code/game/machinery/ai_slipper.dm | 2 +- code/game/machinery/navbeacon.dm | 2 +- code/game/machinery/requests_console.dm | 2 +- .../telecomms/computers/logbrowser.dm | 4 +- .../machinery/telecomms/computers/message.dm | 4 +- .../telecomms/computers/telemonitor.dm | 4 +- .../telecomms/computers/traffic_control.dm | 4 +- .../items/devices/radio/electropack.dm | 2 +- code/modules/admin/DB ban/functions.dm | 2 +- code/modules/admin/banjob.dm | 2 +- code/modules/tgui_panel/external.dm | 9 +- html/changelogs/20667-516fixes.yml | 8 + interface/skin.dmf | 36 +- tgui/.eslintrc.yml | 2 +- tgui/global.d.ts | 5 + tgui/packages/common/keys.ts | 139 +++++++ tgui/packages/tgui-panel/chat/middleware.js | 4 +- tgui/packages/tgui-panel/chat/renderer.js | 4 +- tgui/packages/tgui-panel/index.js | 10 +- .../packages/tgui-say/ChannelIterator.test.ts | 58 +++ tgui/packages/tgui-say/ChannelIterator.ts | 65 ++++ tgui/packages/tgui-say/ChatHistory.test.ts | 50 +++ tgui/packages/tgui-say/ChatHistory.ts | 59 +++ tgui/packages/tgui-say/TguiSay.tsx | 365 ++++++++++++++++++ .../packages/tgui-say/components/dragzone.tsx | 20 - tgui/packages/tgui-say/constants.ts | 37 ++ tgui/packages/tgui-say/constants/index.tsx | 93 ----- tgui/packages/tgui-say/handlers/arrowKeys.tsx | 22 -- .../tgui-say/handlers/backspaceDelete.tsx | 22 -- tgui/packages/tgui-say/handlers/click.tsx | 9 - .../tgui-say/handlers/componentMount.tsx | 23 -- .../tgui-say/handlers/componentUpdate.tsx | 6 - tgui/packages/tgui-say/handlers/enter.tsx | 23 -- tgui/packages/tgui-say/handlers/escape.tsx | 8 - tgui/packages/tgui-say/handlers/force.tsx | 19 - .../tgui-say/handlers/incrementChannel.tsx | 49 --- tgui/packages/tgui-say/handlers/index.tsx | 41 -- tgui/packages/tgui-say/handlers/input.tsx | 11 - tgui/packages/tgui-say/handlers/keyDown.tsx | 43 --- .../tgui-say/handlers/radioPrefix.tsx | 34 -- tgui/packages/tgui-say/handlers/reset.tsx | 22 -- tgui/packages/tgui-say/handlers/setSize.tsx | 22 -- .../tgui-say/handlers/viewHistory.tsx | 26 -- tgui/packages/tgui-say/helpers.ts | 46 +++ tgui/packages/tgui-say/helpers/index.tsx | 157 -------- tgui/packages/tgui-say/index.tsx | 20 +- tgui/packages/tgui-say/interfaces/TguiSay.tsx | 89 ----- tgui/packages/tgui-say/package.json | 4 +- tgui/packages/tgui-say/styles/button.scss | 40 +- tgui/packages/tgui-say/styles/colors.scss | 37 +- tgui/packages/tgui-say/styles/content.scss | 14 + tgui/packages/tgui-say/styles/dragzone.scss | 75 +--- tgui/packages/tgui-say/styles/main.scss | 59 ++- tgui/packages/tgui-say/styles/modal.scss | 71 ---- tgui/packages/tgui-say/styles/textarea.scss | 26 +- tgui/packages/tgui-say/styles/window.scss | 29 ++ tgui/packages/tgui-say/timers.ts | 19 + tgui/packages/tgui-say/types/index.tsx | 67 ---- tgui/yarn.lock | 29 +- 59 files changed, 1102 insertions(+), 1052 deletions(-) create mode 100644 html/changelogs/20667-516fixes.yml create mode 100644 tgui/packages/common/keys.ts create mode 100644 tgui/packages/tgui-say/ChannelIterator.test.ts create mode 100644 tgui/packages/tgui-say/ChannelIterator.ts create mode 100644 tgui/packages/tgui-say/ChatHistory.test.ts create mode 100644 tgui/packages/tgui-say/ChatHistory.ts create mode 100644 tgui/packages/tgui-say/TguiSay.tsx delete mode 100644 tgui/packages/tgui-say/components/dragzone.tsx create mode 100644 tgui/packages/tgui-say/constants.ts delete mode 100644 tgui/packages/tgui-say/constants/index.tsx delete mode 100644 tgui/packages/tgui-say/handlers/arrowKeys.tsx delete mode 100644 tgui/packages/tgui-say/handlers/backspaceDelete.tsx delete mode 100644 tgui/packages/tgui-say/handlers/click.tsx delete mode 100644 tgui/packages/tgui-say/handlers/componentMount.tsx delete mode 100644 tgui/packages/tgui-say/handlers/componentUpdate.tsx delete mode 100644 tgui/packages/tgui-say/handlers/enter.tsx delete mode 100644 tgui/packages/tgui-say/handlers/escape.tsx delete mode 100644 tgui/packages/tgui-say/handlers/force.tsx delete mode 100644 tgui/packages/tgui-say/handlers/incrementChannel.tsx delete mode 100644 tgui/packages/tgui-say/handlers/index.tsx delete mode 100644 tgui/packages/tgui-say/handlers/input.tsx delete mode 100644 tgui/packages/tgui-say/handlers/keyDown.tsx delete mode 100644 tgui/packages/tgui-say/handlers/radioPrefix.tsx delete mode 100644 tgui/packages/tgui-say/handlers/reset.tsx delete mode 100644 tgui/packages/tgui-say/handlers/setSize.tsx delete mode 100644 tgui/packages/tgui-say/handlers/viewHistory.tsx create mode 100644 tgui/packages/tgui-say/helpers.ts delete mode 100644 tgui/packages/tgui-say/helpers/index.tsx delete mode 100644 tgui/packages/tgui-say/interfaces/TguiSay.tsx create mode 100644 tgui/packages/tgui-say/styles/content.scss delete mode 100644 tgui/packages/tgui-say/styles/modal.scss create mode 100644 tgui/packages/tgui-say/styles/window.scss create mode 100644 tgui/packages/tgui-say/timers.ts delete mode 100644 tgui/packages/tgui-say/types/index.tsx diff --git a/code/game/machinery/ai_slipper.dm b/code/game/machinery/ai_slipper.dm index 3551afde9ec..5813afa387a 100644 --- a/code/game/machinery/ai_slipper.dm +++ b/code/game/machinery/ai_slipper.dm @@ -83,7 +83,7 @@ t += "Dispenser [(src.disabled ? "deactivated" : "activated")] - [(src.disabled ? "Enable" : "Disable")]?
\n" t += "Uses Left: [uses]. Activate the dispenser?
\n" - user << browse(t, "window=computer;size=575x450") + user << browse(HTML_SKELETON(t), "window=computer;size=575x450") onclose(user, "computer") return diff --git a/code/game/machinery/navbeacon.dm b/code/game/machinery/navbeacon.dm index f60ffd9cb24..a1e9c1affdf 100644 --- a/code/game/machinery/navbeacon.dm +++ b/code/game/machinery/navbeacon.dm @@ -216,7 +216,7 @@ t += "(add new)
" t+= "