Increase error logging to diagnose server conking (#15662)

* Increase error logging to diagnose server conking

* more logging and db retry

* whoops

* rename error() to log_error() to better reflect what it does
Move a bunch of world.log messages to log_error

* Fix compile error

---------

Co-authored-by: Werner <Arrow768@users.noreply.github.com>
This commit is contained in:
Wildkins
2023-03-13 21:51:39 +00:00
committed by GitHub
co-authored by Werner
parent 62e25f5890
commit c369124fe9
42 changed files with 94 additions and 91 deletions
+1 -1
View File
@@ -890,7 +890,7 @@ var/list/gamemode_cache = list()
if("fastboot")
fastboot = TRUE
world.log << "Fastboot is ENABLED."
log_debug("Fastboot is ENABLED.")
if("merchant_chance")
config.merchant_chance = text2num(value)
+2 -2
View File
@@ -26,14 +26,14 @@
/proc/callHook(hook, list/args=null)
var/hook_path = text2path("/hook/[hook]")
if(!hook_path)
error("Invalid hook '/hook/[hook]' called.")
log_error("Invalid hook '/hook/[hook]' called.")
return 0
var/caller = new hook_path
var/status = 1
for(var/P in typesof("[hook_path]/proc"))
if(!call(caller, P)(arglist(args)))
error("Hook '[P]' failed or runtimed.")
log_error("Hook '[P]' failed or runtimed.")
status = 0
return status
@@ -33,7 +33,7 @@
try
decoded = json_decode(file)
catch (var/exception/e)
error("SSperist_config: invalid JSON detected. Error: [e]")
log_error("SSperist_config: invalid JSON detected. Error: [e]")
return
if (!decoded || !decoded.len)
@@ -164,7 +164,7 @@ var/datum/controller/subsystem/shuttle/SSshuttle
S.motherdock = S.current_location.landmark_tag
mothership.shuttle_area |= S.shuttle_area
else
error("Shuttle [S] was unable to find mothership [mothership]!")
log_error("Shuttle [S] was unable to find mothership [mothership]!")
/datum/controller/subsystem/shuttle/proc/toggle_overmap(new_setting)
if(overmap_halted == new_setting)
+1 -1
View File
@@ -228,7 +228,7 @@
if(manifest.len)
return manifest
if(!SSjobs)
error("SSjobs not available, cannot build manifest")
log_error("SSjobs not available, cannot build manifest")
return
manifest = DEPARTMENTS_LIST_INIT
for(var/datum/record/general/t in records)