Increase error logging to diagnose server conking (#15662)

* Increase error logging to diagnose server conking

* more logging and db retry

* whoops

* rename error() to log_error() to better reflect what it does
Move a bunch of world.log messages to log_error

* Fix compile error

---------

Co-authored-by: Werner <Arrow768@users.noreply.github.com>
This commit is contained in:
Wildkins
2023-03-13 21:51:39 +00:00
committed by GitHub
co-authored by Werner
parent 62e25f5890
commit c369124fe9
42 changed files with 94 additions and 91 deletions
+1 -1
View File
@@ -83,7 +83,7 @@
/datum/mind/proc/transfer_to(mob/living/new_character)
if(!istype(new_character))
world.log << "## DEBUG: transfer_to(): Some idiot has tried to transfer_to( a non mob/living mob. Please inform Carn"
log_error("## DEBUG: transfer_to(): Some idiot has tried to transfer_to( a non mob/living mob. Please inform Carn")
var/datum/changeling/changeling = antag_datums[MODE_CHANGELING]
var/datum/vampire/vampire = antag_datums[MODE_VAMPIRE]
if(current) //remove ourself from our old body's mind variable
+4 -4
View File
@@ -216,8 +216,8 @@
try
call(listener, proc_call)(arglist(args))
catch (var/exception/e)
error("[e.name] - [e.file] - [e.line]")
error(e.desc)
log_error("[e.name] - [e.file] - [e.line]")
log_error(e.desc)
unregister_global(listener, proc_call)
// Call the listeners for this specific event source, if they exist.
@@ -232,8 +232,8 @@
try
call(listener, proc_call)(arglist(args))
catch (var/exception/e)
error("[e.name] - [e.file] - [e.line]")
error(e.desc)
log_error("[e.name] - [e.file] - [e.line]")
log_error(e.desc)
unregister(source, listener, proc_call)
return TRUE
+1 -1
View File
@@ -51,7 +51,7 @@ var/repository/unique/uniqueness_repository = new()
ids_by_key[key] = ids
if(ids.len >= (max - min) + 1)
error("Random ID limit reached for key [key].")
log_error("Random ID limit reached for key [key].")
ids.Cut()
if(ids.len >= 0.6 * ((max-min) + 1)) // if more than 60% of possible ids used